From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDB0CC54FD0 for ; Mon, 27 Apr 2020 06:04:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C22CA2080C for ; Mon, 27 Apr 2020 06:04:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gagTFX7g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C22CA2080C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Bd9fyrhGF1GstR+V/yvSIgB8Nl2GQUV6n6eSzxuND0=; b=gagTFX7gHDFUMk 8TqoYWIbjtqlsdznIrbMV0xnDJzW2KmlQ90EWYnUe8NzZskq+i50ZWZEwnmvga90CwgDQf82etMCn ixmGwAEjg6QJcVBDFErH1kTl4fzf8UvkMzIS69Ta4yU5Cnw5nmaekRniCA2brNoD4zQiaIBrCpT4p RZ/1+tEWKI7c/wJuUT8G7/h/KaLG6A4qo20yVNW8vL/nScZdNjJUmXRAtVXB7qD+CDncfAEY9+40Q s2CGDYX3vYkZ3MvCwjUuUgVf7cCDGZNNCLbaNK0dwHMkJzGqD93cFA7EPATvkcdyf7lklXNnjWrWx qDoa4Ifs0RFA+Ujh+zEA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSwsR-0003HV-Kq; Mon, 27 Apr 2020 06:04:23 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jSwsN-0003GH-5a for linux-nvme@lists.infradead.org; Mon, 27 Apr 2020 06:04:20 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 3D5D268CF0; Mon, 27 Apr 2020 08:04:12 +0200 (CEST) Date: Mon, 27 Apr 2020 08:04:11 +0200 From: Christoph Hellwig To: Max Gurtovoy Subject: Re: [PATCH 05/17] nvme-fabrics: Allow user enabling metadata/T10-PI support Message-ID: <20200427060411.GA16186@lst.de> References: <20200327171545.98970-1-maxg@mellanox.com> <20200327171545.98970-7-maxg@mellanox.com> <20200421151747.GA10837@lst.de> <54c05d2d-2ea5-bf58-455f-91efa085aa9b@mellanox.com> <70f40e49-d9d7-68fe-6a63-a73fabcd146d@gmail.com> <172c1860-bebe-04b2-a9ab-2c03c7cfbf18@mellanox.com> <20200423055447.GB9486@lst.de> <639d6edd-ffa6-f08a-9fa2-047ca97c47ee@mellanox.com> <20200424070647.GB24059@lst.de> <7ff771eb-078e-7eb1-d363-11f96b78eb64@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7ff771eb-078e-7eb1-d363-11f96b78eb64@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200426_230419_359074_07FD24D3 X-CRM114-Status: UNSURE ( 8.51 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, James Smart , sagi@grimberg.me, martin.petersen@oracle.com, shlomin@mellanox.com, linux-rdma@vger.kernel.org, israelr@mellanox.com, vladimirk@mellanox.com, linux-nvme@lists.infradead.org, idanb@mellanox.com, jgg@mellanox.com, oren@mellanox.com, kbusch@kernel.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sun, Apr 26, 2020 at 12:48:18PM +0300, Max Gurtovoy wrote: >> I see no reason not to support a simple Format NVM for our fabrics target >> implementation. But that isn't the point - you don't really need Format >> as you can also control it from configfs in your series. So for the >> initial version I don't think we need Format NVM, but I don't mind >> adding it later. > > so we're ok with passing -p in nvme-cli during connect command ? PI should be enable by default. We can think of a hook disabling it, but please keep it at the end of the series. _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B18BC54FD0 for ; Mon, 27 Apr 2020 06:04:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 214312080C for ; Mon, 27 Apr 2020 06:04:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726231AbgD0GEQ (ORCPT ); Mon, 27 Apr 2020 02:04:16 -0400 Received: from verein.lst.de ([213.95.11.211]:45564 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726221AbgD0GEQ (ORCPT ); Mon, 27 Apr 2020 02:04:16 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 3D5D268CF0; Mon, 27 Apr 2020 08:04:12 +0200 (CEST) Date: Mon, 27 Apr 2020 08:04:11 +0200 From: Christoph Hellwig To: Max Gurtovoy Cc: Christoph Hellwig , James Smart , linux-nvme@lists.infradead.org, kbusch@kernel.org, sagi@grimberg.me, martin.petersen@oracle.com, linux-rdma@vger.kernel.org, idanb@mellanox.com, axboe@kernel.dk, vladimirk@mellanox.com, oren@mellanox.com, shlomin@mellanox.com, israelr@mellanox.com, jgg@mellanox.com Subject: Re: [PATCH 05/17] nvme-fabrics: Allow user enabling metadata/T10-PI support Message-ID: <20200427060411.GA16186@lst.de> References: <20200327171545.98970-1-maxg@mellanox.com> <20200327171545.98970-7-maxg@mellanox.com> <20200421151747.GA10837@lst.de> <54c05d2d-2ea5-bf58-455f-91efa085aa9b@mellanox.com> <70f40e49-d9d7-68fe-6a63-a73fabcd146d@gmail.com> <172c1860-bebe-04b2-a9ab-2c03c7cfbf18@mellanox.com> <20200423055447.GB9486@lst.de> <639d6edd-ffa6-f08a-9fa2-047ca97c47ee@mellanox.com> <20200424070647.GB24059@lst.de> <7ff771eb-078e-7eb1-d363-11f96b78eb64@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ff771eb-078e-7eb1-d363-11f96b78eb64@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Sun, Apr 26, 2020 at 12:48:18PM +0300, Max Gurtovoy wrote: >> I see no reason not to support a simple Format NVM for our fabrics target >> implementation. But that isn't the point - you don't really need Format >> as you can also control it from configfs in your series. So for the >> initial version I don't think we need Format NVM, but I don't mind >> adding it later. > > so we're ok with passing -p in nvme-cli during connect command ? PI should be enable by default. We can think of a hook disabling it, but please keep it at the end of the series.