From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Iskren Chernev <iskren.chernev@gmail.com>,
Saravanan Sekar <sravanhome@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] dt-bindings: Fix erroneous 'additionalProperties'
Date: Mon, 27 Apr 2020 07:52:01 +0100 [thread overview]
Message-ID: <20200427065201.GD3559@dell> (raw)
In-Reply-To: <20200424161708.2906-1-robh@kernel.org>
On Fri, 24 Apr 2020, Rob Herring wrote:
> There's several cases of json-schema 'additionalProperties' at the wrong
> indentation level which has the effect of making them DT properties. This
> is harmless, but let's fix them so a meta-schema check for this can be
> added.
>
> In all the cases, either the 'additionalProperties' was extra or doesn't
> work because there's a $ref to more properties. In the latter case, we
> can use 'unevaluatedProperties' instead.
>
> Reported-by: Iskren Chernev <iskren.chernev@gmail.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Saravanan Sekar <sravanhome@gmail.com>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 2 --
Acked-by: Lee Jones <lee.jones@linaro.org>
> Documentation/devicetree/bindings/regulator/mps,mp5416.yaml | 1 -
> .../devicetree/bindings/regulator/mps,mpq7920.yaml | 3 ++-
> .../bindings/regulator/rohm,bd71828-regulator.yaml | 6 +++++-
> .../bindings/regulator/rohm,bd71837-regulator.yaml | 6 +++++-
> .../bindings/regulator/rohm,bd71847-regulator.yaml | 6 +++++-
> 6 files changed, 17 insertions(+), 7 deletions(-)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-04-27 6:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 16:17 [PATCH] dt-bindings: Fix erroneous 'additionalProperties' Rob Herring
2020-04-24 16:19 ` Mark Brown
2020-04-27 6:52 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427065201.GD3559@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iskren.chernev@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sravanhome@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.