Re: [PATCH] mtd: physmap: Fix mtd device name

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Victor Fusco <victor@cartesi.io>
Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: physmap: Fix mtd device name
Date: Mon, 27 Apr 2020 15:19:07 +0200	[thread overview]
Message-ID: <20200427151153.0104ce07@xps13> (raw)
In-Reply-To: <20200319143833.24767-1-victor@cartesi.io>

Hi Victor,

Please add the maintainers in copy of your patch next time. Otherwise
you might wait a lot before we even figure that you sent us something.

Victor Fusco <victor@cartesi.io> wrote on Thu, 19 Mar
2020 14:38:33 +0000:

> This patch fixes the mtd device name when the "linux,mtd-name" field is
> defined on the Device Tree. A verification to check if the name was
> already defined was missing causing the name to be overwritten with a
> default value.
> 
> Signed-off-by: Victor Fusco <victor@cartesi.io>
> ---
>  drivers/mtd/maps/physmap-core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/maps/physmap-core.c b/drivers/mtd/maps/physmap-core.c
> index 8f7f966fa9a7..6372197ad865 100644
> --- a/drivers/mtd/maps/physmap-core.c
> +++ b/drivers/mtd/maps/physmap-core.c
> @@ -515,7 +515,8 @@ static int physmap_flash_probe(struct platform_device *dev)
>  		dev_notice(&dev->dev, "physmap platform flash device: %pR\n",
>  			   res);
>  
> -		info->maps[i].name = dev_name(&dev->dev);
> +		if (!info->maps[i].name)
> +			info->maps[i].name = dev_name(&dev->dev);
>  
>  		if (!info->maps[i].phys)
>  			info->maps[i].phys = res->start;
> 

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/