From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC7ACC54FD0 for ; Mon, 27 Apr 2020 14:22:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A0FD206B9 for ; Mon, 27 Apr 2020 14:22:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="scVQFwst" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A0FD206B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hIHMfCwzbseJFbeZrSZGOGvtxtFl71jPGbtHcVUKAEk=; b=scVQFwstRfCUBO EdXnPZgboj6sdIwl4DpunJTpTz1WEbqyYXWUSE0gawCHVgj7Ddqt1xxVAFkrCtI04pVzui7nLTFWw VlUxYqCYbU7fJTSH/zmXzU/d8xZqXnTigSHyTeEo2E6X+0QmFwmRKiGftf3ntU66wFkbI4l60AKQ+ zsWqQ7vDFfd0XZYPb0TeWXOxSCPgZzXgmHE9mtBMfpo2OAYKZLn6LJqiWOv3mjtp50vPnwq73Myxg AX9Ux9AQH49tEwY4n/Z93KBlVsf7vF8A6LS/B1tbXXciXho3rRMJT38iqxn2pDYm4bqGRti5e0tjg vJZdrKMSO0zJCtU5ZxdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT4ea-0002hf-Fy; Mon, 27 Apr 2020 14:22:36 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT4eW-0002gZ-Sd for linux-mtd@lists.infradead.org; Mon, 27 Apr 2020 14:22:34 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AB04AFF810; Mon, 27 Apr 2020 14:22:23 +0000 (UTC) Date: Mon, 27 Apr 2020 16:22:22 +0200 From: Miquel Raynal To: Ricardo Ribalda Delgado Subject: Re: [PATCH v2] mtd: Fix mtd not the same name not registered if nvmem Message-ID: <20200427162222.1c2b2c85@xps13> In-Reply-To: References: <20200401100240.445447-1-ribalda@kernel.org> <20200402065953.9974-1-ribalda@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_072233_056460_670D4FA2 X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Richard Weinberger , LKML , Boris Brezillon , linux-mtd@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgUmljYXJkbywKClJpY2FyZG8gUmliYWxkYSBEZWxnYWRvIDxyaWJhbGRhQGtlcm5lbC5vcmc+ IHdyb3RlIG9uIFR1ZSwgMTQgQXByIDIwMjAKMTU6NDc6MjMgKzAyMDA6Cgo+IFBpbmc/Cj4gCj4g T24gVGh1LCBBcHIgMiwgMjAyMCBhdCA4OjU5IEFNIFJpY2FyZG8gUmliYWxkYSBEZWxnYWRvCj4g PHJpYmFsZGFAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4gV2hlbiB0aGUgbnZtZW0gZnJhbWV3 b3JrIGlzIGVuYWJsZWQsIGEgbnZtZW0gZGV2aWNlIGlzIGNyZWF0ZWQgcGVyIG10ZAo+ID4gZGV2 aWNlL3BhcnRpdGlvbi4KPiA+Cj4gPiBJdCBpcyBub3QgdW5jb21tb24gdGhhdCBhIGRldmljZSBj YW4gaGF2ZSBtdWx0aXBsZSBtdGQgZGV2aWNlcyB3aXRoCj4gPiBwYXJ0aXRpb25zIHRoYXQgaGF2 ZSB0aGUgc2FtZSBuYW1lLiBFZywgd2hlbiB0aGVyZSBEVCBvdmVybGF5IGlzIGFsbG93ZWQKPiA+ IGFuZCB0aGUgc2FtZSBkZXZpY2Ugd2l0aCBtdGQgaXMgYXR0YWNoZWQgdHdpY2UuCj4gPgo+ID4g VW5kZXIgdGhhdCBjaXJjdW1zdGFuY2VzLCB0aGUgbXRkIGZhaWxzIHRvIHJlZ2lzdGVyIGR1ZSB0 byBhIG5hbWUKPiA+IGR1cGxpY2F0aW9uIG9uIHRoZSBudm1lbSBmcmFtZXdvcmsuCj4gPgo+ID4g V2l0aCB0aGlzIHBhdGNoIHdlIGFkZCBhIF8xLCBfMiwgX1ggdG8gdGhlIHN1YnNlcXVlbnQgbmFt ZXMgaWYgdGhlcmUgaXMKPiA+IGEgY29sbGl0aW9uLCBhbmQgdGhyb3cgYSB3YXJuaW5nLCBpbnN0 ZWFkIG9mIG5vdCBzdGFydGluZyB0aGUgbXRkCj4gPiBkZXZpY2UuCj4gPgo+ID4gWyAgICA4Ljk0 ODk5MV0gc3lzZnM6IGNhbm5vdCBjcmVhdGUgZHVwbGljYXRlIGZpbGVuYW1lICcvYnVzL252bWVt L2RldmljZXMvUHJvZHVjdGlvbiBEYXRhJwo+ID4gWyAgICA4Ljk0ODk5Ml0gQ1BVOiA3IFBJRDog MjQ2IENvbW06IHN5c3RlbWQtdWRldmQgTm90IHRhaW50ZWQgNS41LjAtcXRlYy1zdGFuZGFyZCAj MTMKPiA+IFsgICAgOC45NDg5OTNdIEhhcmR3YXJlIG5hbWU6IEFNRCBEaWJibGVyL0RpYmJsZXIs IEJJT1MgMDUuMjIuMDQuMDAxOSAxMC8yNi8yMDE5Cj4gPiBbICAgIDguOTQ4OTk0XSBDYWxsIFRy YWNlOgo+ID4gWyAgICA4Ljk0ODk5Nl0gIGR1bXBfc3RhY2srMHg1MC8weDcwCj4gPiBbICAgIDgu OTQ4OTk4XSAgc3lzZnNfd2Fybl9kdXAuY29sZCsweDE3LzB4MmQKPiA+IFsgICAgOC45NDkwMDBd ICBzeXNmc19kb19jcmVhdGVfbGlua19zZC5pc3JhLjArMHhjMi8weGQwCj4gPiBbICAgIDguOTQ5 MDAyXSAgYnVzX2FkZF9kZXZpY2UrMHg3NC8weDE0MAo+ID4gWyAgICA4Ljk0OTAwNF0gIGRldmlj ZV9hZGQrMHgzNGIvMHg4NTAKPiA+IFsgICAgOC45NDkwMDZdICBudm1lbV9yZWdpc3Rlci5wYXJ0 LjArMHgxYmYvMHg2NDAKPiA+IC4uLgo+ID4gWyAgICA4Ljk0ODkyNl0gbXRkIG10ZDg6IEZhaWxl ZCB0byByZWdpc3RlciBOVk1FTSBkZXZpY2UKPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBSaWNhcmRv IFJpYmFsZGEgRGVsZ2FkbyA8cmliYWxkYUBrZXJuZWwub3JnPgoKVGhhbmtzIGZvciBwcm9wb3Np bmcgdGhpcyBjaGFuZ2UuIEluZGVlZCB3ZSBhcmUgYXdhcmUgb2YgdGhlIHByb2JsZW0KYW5kIHRo ZSBiZXN0IHNvbHV0aW9uIHRoYXQgd2UgY291bGQgY29tZSB1cCB3aXRoIHdhcyB0byBjcmVhdGUg YW4KYWRkaXRpb25hbCAidW5pcXVlX25hbWUiIGZpZWxkIHRvIHRoZSBtdGRfaW5mbyBzdHJ1Y3R1 cmUuIFRoaXMgbmV3CmZpZWxkIHdvdWxkIGhhdmUgdGhlIGZvcm06CgogICAgWzxwYXJlbnQtdW5p cXVlLW5hbWU+PHNlcGFyYXRvcj5dPG10ZC1uYW1lPgoKVGhlIHNlcGFyYXRvciBtaWdodCBiZSAn ficgKGJ1dCBJIGFtIGNvbXBsZXRlbHkgb3BlbiBvbiB0aGF0KSwgYW5kIHRoYXQKd291bGQgZ2l2 ZSBmb3IgaW5zdGFuY2U6CgogICAgbXktY29udHJvbGxlcn5teS1kZXZpY2V+bXktcGFydH5teXN1 Yi1wYXJ0CgpUaGVuLCB5b3UgbWlnaHQgdXNlIHRoaXMgbXRkLT51bmlxdWVfbmFtZSBpbnN0ZWFk IG9mIG10ZC0+bmFtZS4gV291bGQKeW91IGdpdmUgdGhpcyBsb2dpYyBhIHRyeT8KClRoYW5rcywK TWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7974AC54FD0 for ; Mon, 27 Apr 2020 14:22:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E87F206B9 for ; Mon, 27 Apr 2020 14:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728018AbgD0OWc convert rfc822-to-8bit (ORCPT ); Mon, 27 Apr 2020 10:22:32 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:49261 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727073AbgD0OWc (ORCPT ); Mon, 27 Apr 2020 10:22:32 -0400 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id AB04AFF810; Mon, 27 Apr 2020 14:22:23 +0000 (UTC) Date: Mon, 27 Apr 2020 16:22:22 +0200 From: Miquel Raynal To: Ricardo Ribalda Delgado Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, LKML , Boris Brezillon , Tudor Ambarus Subject: Re: [PATCH v2] mtd: Fix mtd not the same name not registered if nvmem Message-ID: <20200427162222.1c2b2c85@xps13> In-Reply-To: References: <20200401100240.445447-1-ribalda@kernel.org> <20200402065953.9974-1-ribalda@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ricardo, Ricardo Ribalda Delgado wrote on Tue, 14 Apr 2020 15:47:23 +0200: > Ping? > > On Thu, Apr 2, 2020 at 8:59 AM Ricardo Ribalda Delgado > wrote: > > > > When the nvmem framework is enabled, a nvmem device is created per mtd > > device/partition. > > > > It is not uncommon that a device can have multiple mtd devices with > > partitions that have the same name. Eg, when there DT overlay is allowed > > and the same device with mtd is attached twice. > > > > Under that circumstances, the mtd fails to register due to a name > > duplication on the nvmem framework. > > > > With this patch we add a _1, _2, _X to the subsequent names if there is > > a collition, and throw a warning, instead of not starting the mtd > > device. > > > > [ 8.948991] sysfs: cannot create duplicate filename '/bus/nvmem/devices/Production Data' > > [ 8.948992] CPU: 7 PID: 246 Comm: systemd-udevd Not tainted 5.5.0-qtec-standard #13 > > [ 8.948993] Hardware name: AMD Dibbler/Dibbler, BIOS 05.22.04.0019 10/26/2019 > > [ 8.948994] Call Trace: > > [ 8.948996] dump_stack+0x50/0x70 > > [ 8.948998] sysfs_warn_dup.cold+0x17/0x2d > > [ 8.949000] sysfs_do_create_link_sd.isra.0+0xc2/0xd0 > > [ 8.949002] bus_add_device+0x74/0x140 > > [ 8.949004] device_add+0x34b/0x850 > > [ 8.949006] nvmem_register.part.0+0x1bf/0x640 > > ... > > [ 8.948926] mtd mtd8: Failed to register NVMEM device > > > > Signed-off-by: Ricardo Ribalda Delgado Thanks for proposing this change. Indeed we are aware of the problem and the best solution that we could come up with was to create an additional "unique_name" field to the mtd_info structure. This new field would have the form: [] The separator might be '~' (but I am completely open on that), and that would give for instance: my-controller~my-device~my-part~mysub-part Then, you might use this mtd->unique_name instead of mtd->name. Would you give this logic a try? Thanks, Miquèl