From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C60CBC55199 for ; Mon, 27 Apr 2020 16:46:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D74E2084D for ; Mon, 27 Apr 2020 16:46:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="I0t7k9Rl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726306AbgD0QqX (ORCPT ); Mon, 27 Apr 2020 12:46:23 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38772 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbgD0QqX (ORCPT ); Mon, 27 Apr 2020 12:46:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=tP8rD2QRrQA4OB+TWtA7Qhd+z+Cz4MCa/3wl3NgU3xM=; b=I0t7k9Rlus5qnaf5BP8KN6wKIc gG69s564/7nlx4KKJiGjLeNhfHPpVDLR0qLylDfWwGzYkNpuSoDKby1fpTnv/4gU3LL1XFieFaNur uKI55p+XSjhFGZesbqFg1Qs8kr7CefLpyOzS1KSI0qZv7HTMzZTgV/mVKorRjcMh2j0s=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jT6tg-005FOU-V3; Mon, 27 Apr 2020 18:46:20 +0200 Date: Mon, 27 Apr 2020 18:46:20 +0200 From: Andrew Lunn To: Leonard Crestez Cc: Andy Duan , David Miller , netdev , Chris Healy , dl-linux-imx , Chris Healy Subject: Re: [PATCH] net: ethernet: fec: Replace interrupt driven MDIO with polled IO Message-ID: <20200427164620.GD1250287@lunn.ch> References: <20200414004551.607503-1-andrew@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Apr 27, 2020 at 03:19:54PM +0000, Leonard Crestez wrote: > Hello, > > This patch breaks network boot on at least imx8mm-evk. Boot works if I > revert just commit 29ae6bd1b0d8 ("net: ethernet: fec: Replace interrupt > driven MDIO with polled IO") on top of next-20200424. Hi Leonard Please could you try this: diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts index 951e14a3de0e..3c1adaf7affa 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts @@ -109,6 +109,7 @@ &fec1 { phy-handle = <ðphy0>; phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; phy-reset-duration = <10>; + phy-reset-post-delay = <100>; fsl,magic-packet; status = "okay"; There is an interesting post from Fabio Estevam https://u-boot.denx.narkive.com/PlutD3Rg/patch-1-3-phy-atheros-use-ar8035-config-for-ar8031 Thanks Andrew