From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53E4AC54FCB for ; Mon, 27 Apr 2020 15:38:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35250206BF for ; Mon, 27 Apr 2020 15:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbgD0Piz convert rfc822-to-8bit (ORCPT ); Mon, 27 Apr 2020 11:38:55 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47463 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbgD0Piz (ORCPT ); Mon, 27 Apr 2020 11:38:55 -0400 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2D5C0C0011; Mon, 27 Apr 2020 15:38:48 +0000 (UTC) Date: Mon, 27 Apr 2020 17:38:46 +0200 From: Miquel Raynal To: Boris Brezillon Cc: "Ramuthevar,Vadivel MuruganX" , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, richard@nod.at, vigneshr@ti.com, arnd@arndb.de, brendanhiggins@google.com, tglx@linutronix.de, anders.roxell@linaro.org, masonccyang@mxic.com.tw, piotrs@cadence.com, robh+dt@kernel.org, linux-mips@vger.kernel.org, hauke.mehrtens@intel.com, andriy.shevchenko@intel.com, qi-ming.wu@intel.com, cheol.yong.kim@intel.com Subject: Re: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Message-ID: <20200427173846.3866c506@xps13> In-Reply-To: <20200418105533.477ce529@collabora.com> References: <20200417082147.43384-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200417082147.43384-3-vadivel.muruganx.ramuthevar@linux.intel.com> <20200418105533.477ce529@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Boris, Boris Brezillon wrote on Sat, 18 Apr 2020 10:55:33 +0200: > On Fri, 17 Apr 2020 16:21:47 +0800 > "Ramuthevar,Vadivel MuruganX" > wrote: > > > From: Ramuthevar Vadivel Murugan > > > > This patch adds the new IP of Nand Flash Controller(NFC) support > > on Intel's Lightning Mountain(LGM) SoC. > > > > DMA is used for burst data transfer operation, also DMA HW supports > > aligned 32bit memory address and aligned data access by default. > > DMA burst of 8 supported. Data register used to support the read/write > > operation from/to device. > > > > NAND controller driver implements ->exec_op() to replace legacy hooks, > > these specific call-back method to execute NAND operations. > > > > Signed-off-by: Ramuthevar Vadivel Murugan > > --- > > drivers/mtd/nand/raw/Kconfig | 7 + > > drivers/mtd/nand/raw/Makefile | 1 + > > drivers/mtd/nand/raw/intel_lgm_nand.c | 740 ++++++++++++++++++++++++++++++++++ > > I wonder if we shouldn't name the driver infineon-nand-controller.c > since the original design comes from Infineon IIUC. intel_lgm_nand.c is > definitely misleading, as we also have a nand_intel.c file which is for > Intel NAND chips (not NAND controllers). If we keep intel in the name, > let's at least add a "-controller" suffix to make it clear. > > Side note for Miquel: I guess we would also benefit from having a clear > core vs controller-drivers split as recently done for spi-nor (a > controller subdir has been created). I would even like a core vs controller drivers vs nand chips drivers. Macronix for instance has a NAND controller driver and a NAND chip driver, that's why, even if it is a bit long, I enforce the -nfc or -nand-controller (my favorite) suffix now. Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A158AC54FD0 for ; Mon, 27 Apr 2020 15:39:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4776420656 for ; Mon, 27 Apr 2020 15:39:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rKboozW9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4776420656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m/pKcMiP0h6TePB1uzVvJ+C8waEBhOx2RXnmeffX6AA=; b=rKboozW98PDCpj tdKjU81PyIAaCnTcTUU631hOMSRhbchgZaKrg7UoMX8qUmc04+SkV1VpNYuGhSuZrtTdTDFkIWSg5 g/E5qg95b28TnTYwktYdjNvmR1tJOY4d31vD5ARB/BC9D20pvOQ8ynQ/TiF7JbsFW7h9/QK0JlIHD JdzWUg4ng5VTdm9pArqu+Y6WzsZO59HC2AV5ZLZ/paigluzO7RstwMBERu149Z3O0OdLoDSlWamQu 89eYLpd63ndKJGCU5B63JMpyJX9D1Cm5itGXYL10AVw7pgLuAE5sH/mPhd61IGB97F58G9W3A/jG2 ssS9jNCO/JMEBUWoSVwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT5qX-0001Li-9b; Mon, 27 Apr 2020 15:39:01 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT5qR-0001Eo-Dh for linux-mtd@lists.infradead.org; Mon, 27 Apr 2020 15:38:57 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2D5C0C0011; Mon, 27 Apr 2020 15:38:48 +0000 (UTC) Date: Mon, 27 Apr 2020 17:38:46 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v2 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Message-ID: <20200427173846.3866c506@xps13> In-Reply-To: <20200418105533.477ce529@collabora.com> References: <20200417082147.43384-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200417082147.43384-3-vadivel.muruganx.ramuthevar@linux.intel.com> <20200418105533.477ce529@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_083855_606112_47F91E9A X-CRM114-Status: GOOD ( 14.90 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cheol.yong.kim@intel.com, devicetree@vger.kernel.org, andriy.shevchenko@intel.com, anders.roxell@linaro.org, vigneshr@ti.com, arnd@arndb.de, hauke.mehrtens@intel.com, richard@nod.at, qi-ming.wu@intel.com, brendanhiggins@google.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, "Ramuthevar, Vadivel MuruganX" , robh+dt@kernel.org, linux-mtd@lists.infradead.org, tglx@linutronix.de, masonccyang@mxic.com.tw, piotrs@cadence.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQm9yaXMsCgpCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBjb2xsYWJvcmEuY29t PiB3cm90ZSBvbiBTYXQsIDE4IEFwcgoyMDIwIDEwOjU1OjMzICswMjAwOgoKPiBPbiBGcmksIDE3 IEFwciAyMDIwIDE2OjIxOjQ3ICswODAwCj4gIlJhbXV0aGV2YXIsVmFkaXZlbCBNdXJ1Z2FuWCIK PiA8dmFkaXZlbC5tdXJ1Z2FueC5yYW11dGhldmFyQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4g Cj4gPiBGcm9tOiBSYW11dGhldmFyIFZhZGl2ZWwgTXVydWdhbiA8dmFkaXZlbC5tdXJ1Z2FueC5y YW11dGhldmFyQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gVGhpcyBwYXRjaCBhZGRzIHRoZSBu ZXcgSVAgb2YgTmFuZCBGbGFzaCBDb250cm9sbGVyKE5GQykgc3VwcG9ydAo+ID4gb24gSW50ZWwn cyBMaWdodG5pbmcgTW91bnRhaW4oTEdNKSBTb0MuCj4gPiAKPiA+IERNQSBpcyB1c2VkIGZvciBi dXJzdCBkYXRhIHRyYW5zZmVyIG9wZXJhdGlvbiwgYWxzbyBETUEgSFcgc3VwcG9ydHMKPiA+IGFs aWduZWQgMzJiaXQgbWVtb3J5IGFkZHJlc3MgYW5kIGFsaWduZWQgZGF0YSBhY2Nlc3MgYnkgZGVm YXVsdC4KPiA+IERNQSBidXJzdCBvZiA4IHN1cHBvcnRlZC4gRGF0YSByZWdpc3RlciB1c2VkIHRv IHN1cHBvcnQgdGhlIHJlYWQvd3JpdGUKPiA+IG9wZXJhdGlvbiBmcm9tL3RvIGRldmljZS4KPiA+ IAo+ID4gTkFORCBjb250cm9sbGVyIGRyaXZlciBpbXBsZW1lbnRzIC0+ZXhlY19vcCgpIHRvIHJl cGxhY2UgbGVnYWN5IGhvb2tzLAo+ID4gdGhlc2Ugc3BlY2lmaWMgY2FsbC1iYWNrIG1ldGhvZCB0 byBleGVjdXRlIE5BTkQgb3BlcmF0aW9ucy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogUmFtdXRo ZXZhciBWYWRpdmVsIE11cnVnYW4gPHZhZGl2ZWwubXVydWdhbngucmFtdXRoZXZhckBsaW51eC5p bnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9LY29uZmlnICAgICAg ICAgIHwgICA3ICsKPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9NYWtlZmlsZSAgICAgICAgIHwg ICAxICsKPiA+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9pbnRlbF9sZ21fbmFuZC5jIHwgNzQwICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysgIAo+IAo+IEkgd29uZGVyIGlmIHdlIHNo b3VsZG4ndCBuYW1lIHRoZSBkcml2ZXIgaW5maW5lb24tbmFuZC1jb250cm9sbGVyLmMKPiBzaW5j ZSB0aGUgb3JpZ2luYWwgZGVzaWduIGNvbWVzIGZyb20gSW5maW5lb24gSUlVQy4gaW50ZWxfbGdt X25hbmQuYyBpcwo+IGRlZmluaXRlbHkgbWlzbGVhZGluZywgYXMgd2UgYWxzbyBoYXZlIGEgbmFu ZF9pbnRlbC5jIGZpbGUgd2hpY2ggaXMgZm9yCj4gSW50ZWwgTkFORCBjaGlwcyAobm90IE5BTkQg Y29udHJvbGxlcnMpLiBJZiB3ZSBrZWVwIGludGVsIGluIHRoZSBuYW1lLAo+IGxldCdzIGF0IGxl YXN0IGFkZCBhICItY29udHJvbGxlciIgc3VmZml4IHRvIG1ha2UgaXQgY2xlYXIuCj4gCj4gU2lk ZSBub3RlIGZvciBNaXF1ZWw6IEkgZ3Vlc3Mgd2Ugd291bGQgYWxzbyBiZW5lZml0IGZyb20gaGF2 aW5nIGEgY2xlYXIKPiBjb3JlIHZzIGNvbnRyb2xsZXItZHJpdmVycyBzcGxpdCBhcyByZWNlbnRs eSBkb25lIGZvciBzcGktbm9yIChhCj4gY29udHJvbGxlciBzdWJkaXIgaGFzIGJlZW4gY3JlYXRl ZCkuCgpJIHdvdWxkIGV2ZW4gbGlrZSBhIGNvcmUgdnMgY29udHJvbGxlciBkcml2ZXJzIHZzIG5h bmQgY2hpcHMgZHJpdmVycy4KCk1hY3Jvbml4IGZvciBpbnN0YW5jZSBoYXMgYSBOQU5EIGNvbnRy b2xsZXIgZHJpdmVyIGFuZCBhIE5BTkQgY2hpcApkcml2ZXIsIHRoYXQncyB3aHksIGV2ZW4gaWYg aXQgaXMgYSBiaXQgbG9uZywgSSBlbmZvcmNlIHRoZSAtbmZjIG9yCi1uYW5kLWNvbnRyb2xsZXIg KG15IGZhdm9yaXRlKSBzdWZmaXggbm93LgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1 c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtbXRkLwo=