Re: [PATCH 2/2] mtd: rawnand: atmel: Convert the driver to exec_op()

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Boris,

Boris Brezillon <boris.brezillon@collabora.com> wrote on Mon, 27 Apr
2020 20:27:51 +0200:

> On Mon, 27 Apr 2020 17:17:19 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> > > +	NAND_OP_PARSER_PATTERN(atmel_hsmc_exec_waitrdy,
> > > +		NAND_OP_PARSER_PAT_WAITRDY_ELEM(false)),
> > > +);
> > > +
> > > +static int atmel_hsmc_nand_exec_op(struct atmel_nand *nand,
> > > +				   const struct nand_operation *op,
> > > +				   bool check_only)
> > > +{
> > > +	int ret;
> > > +
> > > +	if (check_only)
> > > +		return nand_op_parser_exec_op(&nand->base,
> > > +					      &atmel_hsmc_op_parser, op, true);
> > > +
> > > +	atmel_hsmc_nand_select_die(nand, op->cs);
> > > +	ret = nand_op_parser_exec_op(&nand->base, &atmel_hsmc_op_parser, op,
> > > +				     false);
> > > +	atmel_hsmc_nand_unselect_die(nand);
> > > +
> > > +	return ret;
> > >  }
> > >      
> > 
> > With the above fixed, please add my
> > 
> > Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> 
> One, more thing. I'll probably split the conversion in 2 steps to make
> the diffstat more readable (add exec_op() + get rid of legacy implem).
> That's what I did for the bcm47xx driver and I find it easier to
> review. Let me know if you'd rather keep things as they are now.


Both are totally fine, if it's okay for you to split then please do it
(And I think you can already add my R-b to both) :)

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/