From: Stefano Brivio <sbrivio@redhat.com>
To: Veronika Kabatova <vkabatov@redhat.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests: introduce gen_tar Makefile target
Date: Mon, 27 Apr 2020 21:24:05 +0200 [thread overview]
Message-ID: <20200427212405.2747394d@redhat.com> (raw)
In-Reply-To: <20200427192141.2926018-1-vkabatov@redhat.com>
On Mon, 27 Apr 2020 21:21:41 +0200
Veronika Kabatova <vkabatov@redhat.com> wrote:
> The gen_kselftest_tar.sh always packages *all* selftests and doesn't
> pass along any variables to `make install` to influence what should be
> built. This can result in an early error on the command line ("Unknown
> tarball format TARGETS=XXX"), or unexpected test failures as the
> tarball contains tests people wanted to skip on purpose.
>
> Since the makefile already contains all the logic, we can add a target
> for packaging. Keep the default .gz target the script uses, and actually
> extend the supported formats by using tar's autodetection.
>
> To not break current workflows, keep the gen_kselftest_tar.sh script as
> it is, with an added suggestion to use the makefile target instead.
>
> Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
next parent reply other threads:[~2020-04-27 19:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200427192141.2926018-1-vkabatov@redhat.com>
2020-04-27 19:24 ` Stefano Brivio [this message]
2020-04-28 0:17 ` [PATCH] selftests: introduce gen_tar Makefile target shuah
2020-04-28 7:07 ` Stefano Brivio
2020-04-28 12:46 ` Veronika Kabatova
2020-04-28 12:34 Veronika Kabatova
-- strict thread matches above, loose matches on Subject: below --
2020-04-28 12:38 Veronika Kabatova
2020-05-01 14:49 ` shuah
2020-05-04 11:50 ` Veronika Kabatova
2020-05-06 14:56 ` shuah
2020-05-19 18:39 ` shuah
2020-05-19 19:50 ` Veronika Kabatova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427212405.2747394d@redhat.com \
--to=sbrivio@redhat.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=vkabatov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.