From: Kalle Valo <kvalo@codeaurora.org>
To: <yhchuang@realtek.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] rtw88: fix sparse warnings for download firmware routine
Date: Tue, 28 Apr 2020 08:44:48 +0000 (UTC) [thread overview]
Message-ID: <20200428084448.7D63BC433F2@smtp.codeaurora.org> (raw)
In-Reply-To: <20200424101255.28239-1-yhchuang@realtek.com>
<yhchuang@realtek.com> wrote:
> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> sparse warnings: (new ones prefixed by >>)
>
> >> drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse:
> symbol '__rtw_download_firmware' was not declared. Should it be static?
> >> drivers/net/wireless/realtek/rtw88/mac.c:817:5: sparse: sparse:
> symbol '__rtw_download_firmware_legacy' was not declared. Should it be
> static?
>
> Fixes: 15d2fcc6b2de ("rtw88: add legacy firmware download for 8723D devices")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Patch applied to wireless-drivers-next.git, thanks.
3d8bf50860c7 rtw88: fix sparse warnings for download firmware routine
--
https://patchwork.kernel.org/patch/11507425/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-04-28 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 10:12 [PATCH] rtw88: fix sparse warnings for download firmware routine yhchuang
2020-04-28 8:44 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428084448.7D63BC433F2@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.