From: Kalle Valo <kvalo@codeaurora.org>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/6] ath9k: fix AR9002 ADC and NF calibrations
Date: Tue, 28 Apr 2020 09:07:59 +0000 (UTC) [thread overview]
Message-ID: <20200428090759.06F8AC44788@smtp.codeaurora.org> (raw)
In-Reply-To: <20200424004923.17129-2-ryazanov.s.a@gmail.com>
Sergey Ryazanov <ryazanov.s.a@gmail.com> wrote:
> ADC calibration is only required for a 80 MHz sampling rate (i.e. for
> 40 MHz channels), when the chip utilizes the pair of ADCs in interleved
> mode. Calibration on a 20 MHz channel will never be completed.
>
> Previous channel check is trying to exclude all channels where the
> calibration will get stuck. It effectively blocks the calibration run
> for HT20 channels, but fails to exclude 20 MHz channels without HT (e.g.
> legacy mode channels).
>
> Fix this issue by reworking the channel check to explicitly allow ADCs
> gain & DC offset calibrations for HT40 channels only. Also update the
> complicated comment to make it clear that these calibrations are for
> multi-ADC mode only.
>
> Stuck ADCs calibration blocks the NF calibration, what could make it
> impossible to work in a noisy evironment: too big Rx attentuation,
> invalid RSSI value, etc. So this change is actually more of a NF
> calibration fix rather then the ADC calibration fix.
>
> Run tested with AR9220.
>
> Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
6 patches applied to ath-next branch of ath.git, thanks.
d6cae2bc195b ath9k: fix AR9002 ADC and NF calibrations
93f8d4223163 ath9k: remove needless NFCAL_PENDING flag setting
41ba50fd6cac ath9k: do not miss longcal on AR9002
2bb7027b64b6 ath9k: interleaved NF calibration on AR9002
ded6ff15a191 ath9k: invalidate all calibrations at once
d8d20845c7f1 ath9k: add calibration timeout for AR9002
--
https://patchwork.kernel.org/patch/11506891/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-28 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 0:49 [PATCH 0/6] ath9k: AR9002 calibration fixes Sergey Ryazanov
2020-04-24 0:49 ` [PATCH 1/6] ath9k: fix AR9002 ADC and NF calibrations Sergey Ryazanov
2020-04-28 9:07 ` Kalle Valo [this message]
2020-04-24 0:49 ` [PATCH 2/6] ath9k: remove needless NFCAL_PENDING flag setting Sergey Ryazanov
2020-04-24 0:49 ` [PATCH 3/6] ath9k: do not miss longcal on AR9002 Sergey Ryazanov
2020-04-24 0:49 ` [PATCH 4/6] ath9k: interleaved NF calibration " Sergey Ryazanov
2020-04-24 0:49 ` [PATCH 5/6] ath9k: invalidate all calibrations at once Sergey Ryazanov
2020-04-24 0:49 ` [PATCH 6/6] ath9k: add calibration timeout for AR9002 Sergey Ryazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428090759.06F8AC44788@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.