From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96989C83004 for ; Tue, 28 Apr 2020 10:33:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 781DA20737 for ; Tue, 28 Apr 2020 10:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588069986; bh=1clsmZJegjw8HaJ5Njou1QrUs1up4U7zJZaJATRxhWg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vDt8z+rDXHqmyhPI85/lbDuBxmE25e5/GXFS/gXTCgF3UaJqndKWJ9p29d7Itody2 EYt/n6VpFOSgrZNRnqPXdnX41/Dq95jdfhqZQtmEarFaBB6K8HPVomgl3diR7Ewa9c 0UpIG1iUKYhVBbztpJGkdGJG1gF0HlEAOxt08OQ8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726328AbgD1KdD (ORCPT ); Tue, 28 Apr 2020 06:33:03 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:40428 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbgD1KdD (ORCPT ); Tue, 28 Apr 2020 06:33:03 -0400 Received: by mail-ed1-f67.google.com with SMTP id d16so15981718edq.7; Tue, 28 Apr 2020 03:33:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3D2uMdzrOa8rVE8whnBxczkr3C+t2CoAy11SOmQRQD8=; b=kh3V/Sxb1F3U5B/AIL8eVXrxlqactmu1bnT5rW0GEI5Pwrn2Dh6It6uWRyqcgU0gI/ kZ2cORojJ+JsDTVypsfrncIisZn30OVc0HujLiQLcpOEU0gnvq2Nz7Dm+4qzU7LbviK6 OnUQCGRnUyuOZrvOjT9P3XDIkqwGDz4/4cUPHjRZKH7pKK8K+Lv8lG/w4J4Z9n5hFck2 mk3lGPUfzq4C/92ILFs4KB9SD5F+YKaPmrCYts37vBZ5FyVTESeDD8137CWwxB6s6pik bxlzVcmTclEuoEUae7C9Q2c1Z82ROLAMbi42JNe2YD6935Fixutis3+2I9coT10RQqV4 YMsQ== X-Gm-Message-State: AGi0PuaWKtZvbuU7GBFHeBfBJcpKajovRiSVvVAhcWMLAeZPK66ulR2V wucibn4iUEYi4lfJf7gxUFE= X-Google-Smtp-Source: APiQypKul1M9hkner9c2dBAchlt9cSNlRgYLaNiYw2GS2Dty7nUnjKL4Mbse6v9dCx57cSCvUOLYIA== X-Received: by 2002:a50:951c:: with SMTP id u28mr21259827eda.310.1588069980922; Tue, 28 Apr 2020 03:33:00 -0700 (PDT) Received: from kozik-lap ([194.230.155.237]) by smtp.googlemail.com with ESMTPSA id ce18sm414140ejb.61.2020.04.28.03.32.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Apr 2020 03:33:00 -0700 (PDT) Date: Tue, 28 Apr 2020 12:32:27 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Cc: kgene@kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/13] arm: dts: s5pv210: Correct FIMC definitions Message-ID: <20200428103227.GE23963@kozik-lap> References: <20200426183604.28494-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Sun, Apr 26, 2020 at 11:36:03AM -0700, Jonathan Bakker wrote: > The extended mainscaler is only available on FIMC1 and there > are minimum pixel alignments that differ from the default. > Additionally, the cam-if interface is available on all three > while FIMC2 has no rotators. The lcd-wb interface is supported > on FIMC1. > > Signed-off-by: Jonathan Bakker > --- > arch/arm/boot/dts/s5pv210.dtsi | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > index b3b6ad2889f9..3cbf6c05f42a 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -626,7 +626,7 @@ > clock-names = "fimc", > "sclk_fimc"; > samsung,pix-limits = <4224 8192 1920 4224>; > - samsung,mainscaler-ext; > + samsung,min-pix-alignment = <16 8>; > samsung,cam-if; > }; > > @@ -639,9 +639,11 @@ > <&clocks SCLK_FIMC1>; > clock-names = "fimc", > "sclk_fimc"; > - samsung,pix-limits = <4224 8192 1920 4224>; > samsung,mainscaler-ext; > + samsung,min-pix-alignment = <1 1>; > + samsung,pix-limits = <4224 8192 1920 4224>; The line just moved around. I guess this was not intended? Best regards, Krzysztof > samsung,cam-if; > + samsung,lcd-wb; > }; > > fimc2: fimc@fb400000 { > @@ -653,9 +655,10 @@ > <&clocks SCLK_FIMC2>; > clock-names = "fimc", > "sclk_fimc"; > - samsung,pix-limits = <4224 8192 1920 4224>; > - samsung,mainscaler-ext; > - samsung,lcd-wb; > + samsung,pix-limits = <1920 8192 1280 1920>; > + samsung,min-pix-alignment = <16 8>; > + samsung,rotators = <0>; > + samsung,cam-if; > }; > }; > > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49BD9C83000 for ; Tue, 28 Apr 2020 10:33:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EB3E206D9 for ; Tue, 28 Apr 2020 10:33:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="R7IRPLXb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EB3E206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+UKpVv55Ezz8Oj8WE0gxvJpwFZxys3xg0iUtgf9KjTQ=; b=R7IRPLXbJkIuJI dlI2otwOyXn4/4EvuP1fzi2KyR1f++kHJv22vKYZ1rMjyVor7JN+nBmpbyZkTVjx7pChbOpjDFiLU rmRTFsLRodM7TriXv32Bd4MLar+bKEvmi2iEs4Qhj0Vkv3bgLIvR9jEj/dNwX+tfTR+F90HsAr4qI 8xNKdAuI7/6mDVlEAqNivjav52jlYTTyDPQUT02djLSmuZlm7L4Os2yD8L9xtFw73e3Hb/XtfWA82 B6m7nPO5H3lFCMhL6zzmdJO3OMt3Uljhix2Di0b20sDkD++chhDsN2jcB7Vnki8vS3ja1HLyNfMw9 xQqQZvVTg8Ep4tfIQofg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTNY1-000536-Lj; Tue, 28 Apr 2020 10:33:05 +0000 Received: from mail-ed1-f68.google.com ([209.85.208.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTNXy-00051B-9j for linux-arm-kernel@lists.infradead.org; Tue, 28 Apr 2020 10:33:04 +0000 Received: by mail-ed1-f68.google.com with SMTP id s10so15979862edy.9 for ; Tue, 28 Apr 2020 03:33:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3D2uMdzrOa8rVE8whnBxczkr3C+t2CoAy11SOmQRQD8=; b=iYSK4qK107i9qVd97uJu7INLCqB2RtP9Ad7Cgi+yNY3PE0fdMpTUOEmErWYHSQNMax 2SwvHgXKmCHwAvlMu9uhvLp84MaOak5aU/7Nn2rwZ3LIIC8LVBOCBAMHkFW5j7AHZGKd zpoUNoQeWTs7rx3D9/PXp57ZtFjKXwGigPlXlyoHRew88MBhgwznnRLvoSISu4k/jI85 nXeXAsvWe14iLJTBPJ7JqVjeEJr6MPhidW68TNMdKSoADx+JF4y+SUSuD1iboYOteFKR Jr7O3sWQZiGnduUs9ICgbqAGHpHIB5P0plFupMu+4LHG27PkAiNY5wtPTFCLSPt8tnf2 C+VQ== X-Gm-Message-State: AGi0PuaVzMc2psRmSCSvyoq6P44b412Ib/GqQ+uNl94qtBr5p52M4daF 59wr7MangouAn3UyewjPGs0= X-Google-Smtp-Source: APiQypKul1M9hkner9c2dBAchlt9cSNlRgYLaNiYw2GS2Dty7nUnjKL4Mbse6v9dCx57cSCvUOLYIA== X-Received: by 2002:a50:951c:: with SMTP id u28mr21259827eda.310.1588069980922; Tue, 28 Apr 2020 03:33:00 -0700 (PDT) Received: from kozik-lap ([194.230.155.237]) by smtp.googlemail.com with ESMTPSA id ce18sm414140ejb.61.2020.04.28.03.32.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Apr 2020 03:33:00 -0700 (PDT) Date: Tue, 28 Apr 2020 12:32:27 +0200 From: Krzysztof Kozlowski To: Jonathan Bakker Subject: Re: [PATCH 12/13] arm: dts: s5pv210: Correct FIMC definitions Message-ID: <20200428103227.GE23963@kozik-lap> References: <20200426183604.28494-1-xc-racer2@live.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200428_033302_336773_11685AEC X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Apr 26, 2020 at 11:36:03AM -0700, Jonathan Bakker wrote: > The extended mainscaler is only available on FIMC1 and there > are minimum pixel alignments that differ from the default. > Additionally, the cam-if interface is available on all three > while FIMC2 has no rotators. The lcd-wb interface is supported > on FIMC1. > > Signed-off-by: Jonathan Bakker > --- > arch/arm/boot/dts/s5pv210.dtsi | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi > index b3b6ad2889f9..3cbf6c05f42a 100644 > --- a/arch/arm/boot/dts/s5pv210.dtsi > +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -626,7 +626,7 @@ > clock-names = "fimc", > "sclk_fimc"; > samsung,pix-limits = <4224 8192 1920 4224>; > - samsung,mainscaler-ext; > + samsung,min-pix-alignment = <16 8>; > samsung,cam-if; > }; > > @@ -639,9 +639,11 @@ > <&clocks SCLK_FIMC1>; > clock-names = "fimc", > "sclk_fimc"; > - samsung,pix-limits = <4224 8192 1920 4224>; > samsung,mainscaler-ext; > + samsung,min-pix-alignment = <1 1>; > + samsung,pix-limits = <4224 8192 1920 4224>; The line just moved around. I guess this was not intended? Best regards, Krzysztof > samsung,cam-if; > + samsung,lcd-wb; > }; > > fimc2: fimc@fb400000 { > @@ -653,9 +655,10 @@ > <&clocks SCLK_FIMC2>; > clock-names = "fimc", > "sclk_fimc"; > - samsung,pix-limits = <4224 8192 1920 4224>; > - samsung,mainscaler-ext; > - samsung,lcd-wb; > + samsung,pix-limits = <1920 8192 1280 1920>; > + samsung,min-pix-alignment = <16 8>; > + samsung,rotators = <0>; > + samsung,cam-if; > }; > }; > > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel