From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C8FC83000 for ; Tue, 28 Apr 2020 10:39:24 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8804206A1 for ; Tue, 28 Apr 2020 10:39:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="YgOwvpTz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CW1WJz+v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8804206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0A7C316AB; Tue, 28 Apr 2020 12:38:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0A7C316AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588070362; bh=dAfElojX/Z6FylzbUorhE6A688Cdj1Orv2AZs+2E4c4=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YgOwvpTzTXvYKiGsr0c+0VQRPV1Gv7Dt77hsFVOEPyc4MXXvZSxLHPw+/lJycVnJA /z/2SJsLZSq+kpDaWUAHeKxPKhcVek75y5y7//xRLCr9tbxrRQ2WDX+4ZhHBpkAK/g 2hKnmgTWB/3Ae+OVhPxSNx2qQMyvA1Kb4YjVywMo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 75DD9F8027D; Tue, 28 Apr 2020 12:37:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 681BEF8028C; Tue, 28 Apr 2020 12:37:22 +0200 (CEST) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E055EF8021C for ; Tue, 28 Apr 2020 12:37:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E055EF8021C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CW1WJz+v" Received: by mail-wr1-x444.google.com with SMTP id s10so24065388wrr.0 for ; Tue, 28 Apr 2020 03:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=7MejAFBM22X91TMwqTDKSAeWhAdaxEoe9krCl6slZcg=; b=CW1WJz+v+l5HJMoPdvjvjK/VgsrHkwFr4WsjHdgLJGBXnep8kEZ68Z+I1d60yQVsg5 8ycIUR4EOnZSldddQ+VA7nG8H5wj91eIDi7sDP6g+dV+NEku+iLIaTzcJz7qCDOqdhPu oHa6deCp/HBKhISiwFkT5Eb0yXwnC26RyKbmpEq4iz7DNDud5v2lSggY0aJpoE1x1Lue jJoI2KGhD2+wXreNYy2XH1+RgVAiHfgVlfkWtkNuGzIgyq2g02Sw3UbOA6i2Et+ltdha tWuZmqrrgavp+4B2q+n3dCe2wDA4gSfV7+Mo+rABKEyziPx26InaOZOfzgeIzu/98O+w MWPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7MejAFBM22X91TMwqTDKSAeWhAdaxEoe9krCl6slZcg=; b=C+wEWsVSdd4SijCvZy/1QE2+gEClb4MyauqHcXbzz7yn94c1XyNS7wFaSiXPyfHxUJ jNYmHp4h5ALuiJd0x5OYtpV4U/ohkDSTR/v6jkqbjKtxSQNwiPvNhaoKp69vyA1dd18/ 4AAibFEZq/NzeyuZB6AhqLer5W3kAZz4v15dCwO0gEsU7HfCg+fuJyaLK5nwKaRwdOa7 funT8rPpm3U7wh/FH3TNJ3ujCioQuW59eAZ1YCdDQEaVQuomTM3K5brY1JYLsGCLKLcz IU+yz0cyHa8ljzSsBie5SEjRLj8W+QPzlTENMiYb/tFWdatxvWcCDjf2eWJBbycXglKH 9C/w== X-Gm-Message-State: AGi0Pub1PXQk++RCIbb/C9AGsTi6bToJ9RHa1fNU2wo51PLev44U7FJJ rlO5Auz3ad5zS0fsA2045KfbvA== X-Google-Smtp-Source: APiQypKdoep9dH64db2eqNaZcKDzXAa4SCLSqqV2lBPjzT69msPFvROIeGblV3W9BBHviXISbLazmA== X-Received: by 2002:a05:6000:f:: with SMTP id h15mr31915700wrx.408.1588070238317; Tue, 28 Apr 2020 03:37:18 -0700 (PDT) Received: from dell ([2.31.163.63]) by smtp.gmail.com with ESMTPSA id h188sm2986813wme.8.2020.04.28.03.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 03:37:17 -0700 (PDT) Date: Tue, 28 Apr 2020 11:37:16 +0100 From: Lee Jones To: Marek Szyprowski Subject: Re: [PATCH 2/4] mfd: wm8994: Fix unbalanced calls to regulator_bulk_disable() Message-ID: <20200428103716.GR3559@dell> References: <20200427074832.22134-1-m.szyprowski@samsung.com> <20200427074832.22134-3-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200427074832.22134-3-m.szyprowski@samsung.com> Cc: alsa-devel@alsa-project.org, Charles Keepax , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 27 Apr 2020, Marek Szyprowski wrote: > When runtime PM is enabled, regulators are being controlled by the > driver's suspend and resume callbacks. They are also unconditionally > enabled at driver's probe(), and disabled in remove() functions. Add > more calls to runtime PM framework to ensure that the device's runtime > PM state matches the regulators state: > 1. at the end of probe() function: set runtime PM state to active, so > there will be no spurious call to resume(); > 2. in remove(), ensure that resume() is called before disabling runtime PM > management and unconditionally disabling the regulators. > > Signed-off-by: Marek Szyprowski > Acked-by: Charles Keepax > --- > drivers/mfd/wm8994-core.c | 3 +++ > 1 file changed, 3 insertions(+) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55822C83000 for ; Tue, 28 Apr 2020 10:37:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32B74206D9 for ; Tue, 28 Apr 2020 10:37:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CW1WJz+v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbgD1KhU (ORCPT ); Tue, 28 Apr 2020 06:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726328AbgD1KhT (ORCPT ); Tue, 28 Apr 2020 06:37:19 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CB84C03C1A9 for ; Tue, 28 Apr 2020 03:37:19 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id j1so24052956wrt.1 for ; Tue, 28 Apr 2020 03:37:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=7MejAFBM22X91TMwqTDKSAeWhAdaxEoe9krCl6slZcg=; b=CW1WJz+v+l5HJMoPdvjvjK/VgsrHkwFr4WsjHdgLJGBXnep8kEZ68Z+I1d60yQVsg5 8ycIUR4EOnZSldddQ+VA7nG8H5wj91eIDi7sDP6g+dV+NEku+iLIaTzcJz7qCDOqdhPu oHa6deCp/HBKhISiwFkT5Eb0yXwnC26RyKbmpEq4iz7DNDud5v2lSggY0aJpoE1x1Lue jJoI2KGhD2+wXreNYy2XH1+RgVAiHfgVlfkWtkNuGzIgyq2g02Sw3UbOA6i2Et+ltdha tWuZmqrrgavp+4B2q+n3dCe2wDA4gSfV7+Mo+rABKEyziPx26InaOZOfzgeIzu/98O+w MWPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=7MejAFBM22X91TMwqTDKSAeWhAdaxEoe9krCl6slZcg=; b=PXNcEZWreYmBwhj3gzxr8TX1s1mn/DdYOtJ3lRpsspoELkViqt39Jr/MCoq9aMNK71 mM3Fq9j69z/2kwY7EcY2nRn4vMjiEJiswy8Xe+ynlgVPvD19ztjswrx2pw1D5pPT8HwK fCXd78gWGaldTcsxPa9Bz/SbTMvmEQb8W2KWBe6j6t+ARi3VNlB9EicaMjTJa6bbTs0N nekgR1wVBDyYGwnq6aiGRP5erzniVOmhSdJLZL5sGQrDsH1klS0FexMvwGgB45tBCm+h fjyTjX/qH4tg9l6m4RuyiEFphzvXye1fkuMtjfYxvfQeHPrzeGgcc+ZMXf+RH0kS43/p MqsA== X-Gm-Message-State: AGi0PubIwdtUoWS2PmuBnvWNSA6CfUktcoxgl9h9fT04m96NECri5T2b lcvd4QtCwitTDioAcL/R88c4Fw== X-Google-Smtp-Source: APiQypKdoep9dH64db2eqNaZcKDzXAa4SCLSqqV2lBPjzT69msPFvROIeGblV3W9BBHviXISbLazmA== X-Received: by 2002:a05:6000:f:: with SMTP id h15mr31915700wrx.408.1588070238317; Tue, 28 Apr 2020 03:37:18 -0700 (PDT) Received: from dell ([2.31.163.63]) by smtp.gmail.com with ESMTPSA id h188sm2986813wme.8.2020.04.28.03.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 03:37:17 -0700 (PDT) Date: Tue, 28 Apr 2020 11:37:16 +0100 From: Lee Jones To: Marek Szyprowski Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Mark Brown , Sylwester Nawrocki , Charles Keepax , Liam Girdwood Subject: Re: [PATCH 2/4] mfd: wm8994: Fix unbalanced calls to regulator_bulk_disable() Message-ID: <20200428103716.GR3559@dell> References: <20200427074832.22134-1-m.szyprowski@samsung.com> <20200427074832.22134-3-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200427074832.22134-3-m.szyprowski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Apr 2020, Marek Szyprowski wrote: > When runtime PM is enabled, regulators are being controlled by the > driver's suspend and resume callbacks. They are also unconditionally > enabled at driver's probe(), and disabled in remove() functions. Add > more calls to runtime PM framework to ensure that the device's runtime > PM state matches the regulators state: > 1. at the end of probe() function: set runtime PM state to active, so > there will be no spurious call to resume(); > 2. in remove(), ensure that resume() is called before disabling runtime PM > management and unconditionally disabling the regulators. > > Signed-off-by: Marek Szyprowski > Acked-by: Charles Keepax > --- > drivers/mfd/wm8994-core.c | 3 +++ > 1 file changed, 3 insertions(+) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog