Re: [PATCH 01/10] mtd: rawnand: Translate obscure bitfields into readable macros

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Boris,

Boris Brezillon <boris.brezillon@collabora.com> wrote on Sat, 25 Apr
2020 10:33:20 +0200:

> On Fri, 24 Apr 2020 19:36:22 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> >  /*
> >   * This option could be defined by controller drivers to protect against
> >   * kmap'ed, vmalloc'ed highmem buffers being passed from upper layers
> >   */
> > -#define NAND_USE_BOUNCE_BUFFER	0x00100000
> > +#define NAND_USE_BOUNCE_BUFFER	BIT(22)  
> 
> 					^BIT(20)
> 
> >  
> >  /*
> >   * In case your controller is implementing ->legacy.cmd_ctrl() and is relying
> > @@ -207,20 +207,20 @@ enum nand_ecc_algo {
> >   * If your controller already takes care of this delay, you don't need to set
> >   * this flag.
> >   */
> > -#define NAND_WAIT_TCCS		0x00200000
> > +#define NAND_WAIT_TCCS		BIT(21)
> >  
> >  /*
> >   * Whether the NAND chip is a boot medium. Drivers might use this information
> >   * to select ECC algorithms supported by the boot ROM or similar restrictions.
> >   */
> > -#define NAND_IS_BOOT_MEDIUM	0x00400000
> > +#define NAND_IS_BOOT_MEDIUM	BIT(20)  
> 
> 				^ BIT(22)
> 
> The rest looks good, feel fre to add
> 
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> 
> once those 2 mistakes are fixed.

Mmh yeah absolutely, fixed.


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/