From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6CC9C83000 for ; Tue, 28 Apr 2020 13:57:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83CD4206B9 for ; Tue, 28 Apr 2020 13:57:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83CD4206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2107F6E484; Tue, 28 Apr 2020 13:57:49 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B4566E484 for ; Tue, 28 Apr 2020 13:57:47 +0000 (UTC) IronPort-SDR: jyhs0Z4FeWNYJGwgVKTj8pJ5eNrU0b9fzwsBXEpG2GWj/7UIoIqBIIZwXIPXekuTbQHX7+Da2O 10+bK0AfGxiA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 06:57:46 -0700 IronPort-SDR: zNs/PEXBb6f7QE0ZtvbO+JcK8+dHxAk02X5RBzIuiPILZKYc+IeeiYkrZswZ2QQS8py/KeSanJ Yr+O2Nr5DO/A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,327,1583222400"; d="scan'208";a="261104452" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga006.jf.intel.com with SMTP; 28 Apr 2020 06:57:44 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 28 Apr 2020 16:57:44 +0300 Date: Tue, 28 Apr 2020 16:57:44 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Alexei Podtelezhnikov Message-ID: <20200428135744.GI6112@intel.com> References: <20200428034705.3907-1-apodtele@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428034705.3907-1-apodtele@gmail.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [patch] drm/i915: Add PCI IDs for Skylake GT1.5 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Apr 27, 2020 at 11:47:05PM -0400, Alexei Podtelezhnikov wrote: > These devices are also known as iSKLULTGT15 and iSKLDTGT15. > = > Signed-off-by: Alexei Podtelezhnikov > --- > include/drm/i915_pciids.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/src/i915_pciids.h b/src/i915_pciids.h > index 1d2c1221..a9c88eab 100644 > --- a/include/drm/i915_pciids.h > +++ b/include/drm/i915_pciids.h > @@ -331,7 +355,8 @@ Add SKL GT1.5 > INTEL_VGA_DEVICE(0x22b3, info) > = > #define INTEL_SKL_ULT_GT1_IDS(info) \ > - INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */ > + INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \ > + INTEL_VGA_DEVICE(0x1913, info) /* ULT GT1.5 */ > = > #define INTEL_SKL_ULX_GT1_IDS(info) \ > INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */ We also seem to be missing 0x1915 from the ulx list. Another odd things I noticed in our SKL PCI ID lists is that that 0x1923 and 0x1927 are potentially miscategorized. They are listed as ULT in some parts of the spec whereas we have them in the non-ULT/ULX list. Also 0x1927 is listed as Iris graphics 550, and ark.intel.com says that it can be found in the i5-6267U CPU, which is ULT. The other one is listed as HD Graphics 535 which does give some ULT google hits based on the Windows drivers. So looks like we should make these ULT. The third odd thing is that 0x192a is listed as both GT3 and GT4 in the spec. Not really able to find corroborating evidence one way or the other unfortunately. > @@ -340,6 +365,7 @@ Add SKL GT1.5 > INTEL_SKL_ULT_GT1_IDS(info), \ > INTEL_SKL_ULX_GT1_IDS(info), \ > INTEL_VGA_DEVICE(0x1902, info), /* DT GT1 */ \ > + INTEL_VGA_DEVICE(0x1917, info), /* DT GT1.5 */ \ > INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \ > INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */ > = > -- > 2.26.2 > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx