From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Alexei Podtelezhnikov <apodtele@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [patch] drm/i915: Remove dubious Valleyview PCI IDs
Date: Tue, 28 Apr 2020 17:09:31 +0300 [thread overview]
Message-ID: <20200428140931.GJ6112@intel.com> (raw)
In-Reply-To: <20200428034752.3975-1-apodtele@gmail.com>
On Mon, Apr 27, 2020 at 11:47:52PM -0400, Alexei Podtelezhnikov wrote:
> 0x0155 is rather Ivy Bridge PCI-E Root Port.
A bit surprising we've not had any reports of the driver biding to the
wrong device.
> 0x0157 from the same commit ff049b6ce21d2814451afd4a116d001712e0116b
> is likely wrong too. Nowhere is it independetly confirmed or mentioned.
Can' find these in the spec so they do seem bogus. Also can't remember
ever seeing one of these.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com>
> ---
> include/drm/i915_pciids.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/src/i915_pciids.h b/src/i915_pciids.h
> index 1d2c1221..a9c88eab 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -258,9 +284,7 @@ Remove wrong and non-existent devices
> INTEL_VGA_DEVICE(0x0f30, info), \
> INTEL_VGA_DEVICE(0x0f31, info), \
> INTEL_VGA_DEVICE(0x0f32, info), \
> - INTEL_VGA_DEVICE(0x0f33, info), \
> - INTEL_VGA_DEVICE(0x0157, info), \
> - INTEL_VGA_DEVICE(0x0155, info)
> + INTEL_VGA_DEVICE(0x0f33, info)
>
> #define INTEL_BDW_ULT_GT1_IDS(info) \
> INTEL_VGA_DEVICE(0x1606, info), /* GT1 ULT */ \
> --
> 2.26.2
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-04-28 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 3:47 [Intel-gfx] [patch] drm/i915: Remove dubious Valleyview PCI IDs Alexei Podtelezhnikov
2020-04-28 4:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-04-28 4:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-28 7:17 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-04-28 14:09 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428140931.GJ6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=apodtele@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.