From: Johannes Weiner <hannes@cmpxchg.org>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCH 2/4] block: cleanup the memory stall accounting in submit_bio
Date: Tue, 28 Apr 2020 11:06:51 -0400 [thread overview]
Message-ID: <20200428150651.GA78497@cmpxchg.org> (raw)
In-Reply-To: <20200428112756.1892137-3-hch@lst.de>
On Tue, Apr 28, 2020 at 01:27:54PM +0200, Christoph Hellwig wrote:
> Instead of a convoluted chain just check for REQ_OP_READ directly,
> and keep all the memory stall code together in a single unlikely
> branch.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Hm, I have to say I don't prefer one version over the other here.
Keeping the the stall annotation code more compact is nice, but the
duplicate generic_make_request() seems to suggest that the requests
themselves are also somehow made differently, when it's really just
the annotation that's conditional.
That said, the patch looks correct to me.
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2020-04-28 15:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 11:27 a few small bio related cleanups Christoph Hellwig
2020-04-28 11:27 ` [PATCH 1/4] block: improve the submit_bio and generic_make_request documentation Christoph Hellwig
2020-04-28 14:16 ` Johannes Thumshirn
2020-04-28 14:17 ` Keith Busch
2020-04-28 11:27 ` [PATCH 2/4] block: cleanup the memory stall accounting in submit_bio Christoph Hellwig
2020-04-28 14:12 ` Johannes Thumshirn
2020-04-28 14:21 ` Christoph Hellwig
2020-04-28 15:06 ` Johannes Weiner [this message]
2020-04-28 11:27 ` [PATCH 3/4] block: replace BIO_QUEUE_ENTERED with BIO_CGROUP_ACCT Christoph Hellwig
2020-04-28 14:23 ` Johannes Thumshirn
2020-04-28 14:24 ` Christoph Hellwig
2020-04-28 14:26 ` Johannes Thumshirn
2020-04-28 11:27 ` [PATCH 4/4] block: add a bio_queue_enter helper Christoph Hellwig
2020-04-28 14:55 ` Johannes Thumshirn
2020-04-29 15:33 ` a few small bio related cleanups Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428150651.GA78497@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.