All of lore.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Stahl, Manuel" <manuel.stahl@iis-extern.fraunhofer.de>
Cc: "hjk@linutronix.de" <hjk@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"sojkam1@fel.cvut.cz" <sojkam1@fel.cvut.cz>
Subject: Re: [PATCH v4] Add new uio device for PCI with dynamic memory allocation
Date: Tue, 28 Apr 2020 17:58:45 +0200	[thread overview]
Message-ID: <20200428155845.GA1611284@kroah.com> (raw)
In-Reply-To: <6e93bbcb4ba85b4cc143aa8e3e7254071b3c8bdb.camel@iis-extern.fraunhofer.de>

On Tue, Apr 28, 2020 at 03:47:42PM +0000, Stahl, Manuel wrote:
> > 
> > > +		return err;
> > > +	}
> > > +	pci_set_master(pdev);
> > > +
> > > +	dev_info(&pdev->dev, "Legacy IRQ: %i", pdev->irq);
> > 
> > Again, remove, be quiet :)
> 
> Use dev_dbg() or remove completely?

If it helps in debugging, dev_dbg() is fine to use.

thanks,

greg k-h

  reply	other threads:[~2020-04-28 15:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 13:31 [PATCH 1/2 v3] Add new uio device for PCI with dynamic memory allocation Stahl, Manuel
2017-10-06 13:33 ` [PATCH 2/2] uio: Prefer MSI(X) interrupts in PCI drivers Stahl, Manuel
2017-10-06 13:45   ` gregkh
2017-10-06 13:50     ` Stahl, Manuel
2017-10-06 14:57       ` Stephen Hemminger
2017-10-20 12:50         ` gregkh
2017-10-20 12:58           ` Stahl, Manuel
2020-03-04 15:19             ` Stahl, Manuel
2020-03-04 15:44               ` gregkh
2017-10-24 13:11           ` Stephen Hemminger
2020-04-16 16:38 ` [PATCH v4] Add new uio device for PCI with dynamic memory allocation Manuel Stahl
2020-04-28 13:54   ` gregkh @ linuxfoundation . org
2020-04-28 15:47     ` Stahl, Manuel
2020-04-28 15:58       ` gregkh [this message]
2020-04-29  7:51     ` Stahl, Manuel
2020-04-29  9:41       ` gregkh
2020-04-29 13:53         ` Stahl, Manuel
2023-05-18  4:48           ` Hongren Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200428155845.GA1611284@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=hjk@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manuel.stahl@iis-extern.fraunhofer.de \
    --cc=sojkam1@fel.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.