Re: [PATCH] mtd: physmap_of_gemini: remove defined but not used symbol 'syscon_match'

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Richard Weinberger <richard@nod.at>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-mtd@lists.infradead.org, Vignesh R <vigneshr@ti.com>,
	Jason Yan <yanaijie@huawei.com>
Subject: Re: [PATCH] mtd: physmap_of_gemini: remove defined but not used symbol 'syscon_match'
Date: Tue, 28 Apr 2020 16:20:13 +0200	[thread overview]
Message-ID: <20200428162013.6ac67b15@xps13> (raw)
In-Reply-To: <CACRpkdY06GvLRcfD0pjhJ6woHUY8rxi5hqKPmyS7nrhJ_BXrQA@mail.gmail.com>

Hi Linus,

Linus Walleij <linus.walleij@linaro.org> wrote on Tue, 28 Apr 2020
16:16:55 +0200:

> On Mon, Apr 27, 2020 at 3:53 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > Jason Yan <yanaijie@huawei.com> wrote on Fri, 3 Apr 2020 16:15:44 +0800:
> >  
> > > It's not used by anyone now, remove it. Fix the following gcc warning:
> > >
> > > drivers/mtd/maps/physmap-gemini.c:49:34: warning: ‘syscon_match’ defined
> > > but not used [-Wunused-const-variable=]
> > >  static const struct of_device_id syscon_match[] = {
> > >                                   ^~~~~~~~~~~~
> > >
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Signed-off-by: Jason Yan <yanaijie@huawei.com>
> > > ---  
> >
> > I am not sure this is the right solution. This compatible has been
> > added in this driver by Linus in 9d3b5086f6d4 ("mtd: physmap_of_gemini:
> > Handle pin control"). I believe he had a good reason to do so but you
> > are right that it is not used. Linus, any input?  
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> It's probably just a remnant of earlier development, sorry for that.
> We now locate the syscon by phandle:
> rmap = syscon_regmap_lookup_by_phandle(np, "syscon");

No problem, thanks for the confirmation.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/