From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:52b1:0:0:0:0:0 with SMTP id r17csp5737040lfm; Tue, 28 Apr 2020 09:42:59 -0700 (PDT) X-Google-Smtp-Source: APiQypIfrxZI/fu+e/qBsXA9ZPwwG3jm5MhAP74brOOxcziwiPRG/pDm1h+fgsXwi39qt5qqjhph X-Received: by 2002:ac8:3844:: with SMTP id r4mr28559258qtb.32.1588092179785; Tue, 28 Apr 2020 09:42:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588092179; cv=none; d=google.com; s=arc-20160816; b=oUAKWtHrYLIw4bLXHmXCFXahld1iHvW/Ea6LBJ5AQsA9eHOCnozkY7IwS13+QZ+8mg A3lwZjwZ8qtsFuiD1PSdTb+dcxoKjDsSbeKyH5Su+IDsrgXx+bAquVBAIkSDXmyySffS xr3AJaZ9dB74hC+3GC3U0A0FLtzUHH2uwI2S1kwGCvN+8p4j2MHYo6jEMokL2TI7WCqB 360udfz/RRG9YrqbHZ+SEx3oGPYdf3xKoN6ucLkycBEuI7XovQ8ScjOMfqpJKF0VMWMC h51IWLsRZkfM6ER0zt9VlqorM6HnKs0BS7AaGopi+a5RYImlVkFrwi+ISm3BH0gNYK6+ HKVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature; bh=F/qJFRK2xdLo2lszjG6qf99vwjDSSthRThTt33h6GNQ=; b=SzI/0p2urVJ5zoNQz82j5eF1JPTTTDw4gu8fDu/smUffuTe+HtjCRbAakTJECqbSz5 7pZ67pKckk+qysypTTNIeDCvOJyOgIzu//Cjz0Frp7gPZ7Ulvmqp7P07A/K/W7dWjoM7 Xa4JwDrqhd1//QFDqhmW6dghIEU/aXuYASFLQFPS6iZHOZzPFF7mKY7161wUSUTxUv5i pzZGnx8j86dpVGFrBwujXVza8MNJsgEwKryazHzpGfMgNZ/0J2oJp4zL6HG0PP/wsNEA HjZF5OoH91IyOX/9olajIdFLzHJHer/I5IKRN31iwWbqjLE5F8hYtzqVuCkN0ilKVEwY 5puA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="qVK/hTwI"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i4si10848683qkm.135.2020.04.28.09.42.59 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Apr 2020 09:42:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="qVK/hTwI"; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1]:38834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTTJz-0005zN-4O for alex.bennee@linaro.org; Tue, 28 Apr 2020 12:42:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34290) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTTF5-0006OV-7O for qemu-devel@nongnu.org; Tue, 28 Apr 2020 12:38:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTTBc-0000pN-CV for qemu-devel@nongnu.org; Tue, 28 Apr 2020 12:37:54 -0400 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]:35309) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTTBb-0000ot-Sj; Tue, 28 Apr 2020 12:34:19 -0400 Received: by mail-lj1-x244.google.com with SMTP id g4so22196367ljl.2; Tue, 28 Apr 2020 09:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=F/qJFRK2xdLo2lszjG6qf99vwjDSSthRThTt33h6GNQ=; b=qVK/hTwI5G+iBJRnYmHoEXEODGgN2hnNhyVigd4vVQ/YG4RNy6uuWFoN53W4Trg7l4 FRcn6S+6k00cDBo/JW/E17Z+wOPW5oVn68ISQeO7rK5sDT5ewk7bmhuOjf8JNVMa051I fuIdh0I+yNZKAwmfUapgb9CZdHtR6mGTaPtgyxgQ7SEmN6x8Bshq70+SitWMLYSJgv+r 3UL7742NtAsTz1rHnDFWIcBtEjCb6tBA7KOHECkydKYSU/RtBTlgP7qil8k+ee4RKPRc EydGakQNTsJHSL3VK5/jgh+pSfQsLdTGWGGuVFvvgEKg6nXuRlsIfaeibE0Ec3BSHJms TSXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F/qJFRK2xdLo2lszjG6qf99vwjDSSthRThTt33h6GNQ=; b=Ia6b6C0rfIU07li0MYM7i5IaN29D5IGBUj8jaP4VdAyAKStg8WFWZuZBI1KdLHnvgj 2MuhYDEv9D/X6gkYDliWPMixYhDPXZCud2rrliNpCDbIu2IgtuJtXgt2vpX8Vdf1+nC/ yKEPwEzjmt2Po3d/Lbf1pZZPbRNsM9WFRxAqUT1i0xU33OtUF6DxwyHMPyrqjJcG+OlL rtCzubYiK9YqG4lk2leInEy7T4Gpt7bEossftPR3c7kRwQ7AuX9qE3QcwT2LAcScj7V4 tLamXHPcNmbwYtdm1OwlRFmzlL1IwC2zOe/7v4ot+BZHjNheJMlKVTQSceJLs1+zQVqv SbXw== X-Gm-Message-State: AGi0PubZIcIOxipbH6OHroWH3MyehWDCtUaC4NN2JP0S01WDKAw5tRxk 6zWplvSYWWEMF/7XBz4vQbc= X-Received: by 2002:a2e:b0c5:: with SMTP id g5mr18233121ljl.203.1588091657503; Tue, 28 Apr 2020 09:34:17 -0700 (PDT) Received: from localhost (81-231-232-130-no39.tbcn.telia.com. [81.231.232.130]) by smtp.gmail.com with ESMTPSA id k18sm17383787lfg.81.2020.04.28.09.34.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 09:34:16 -0700 (PDT) Date: Tue, 28 Apr 2020 18:33:44 +0200 From: "Edgar E. Iglesias" To: Vikram Garhwal Subject: Re: [PATCH v3 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controller Message-ID: <20200428163344.GM2669@toto> References: <1587603369-14644-1-git-send-email-fnu.vikram@xilinx.com> <1587603369-14644-3-git-send-email-fnu.vikram@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1587603369-14644-3-git-send-email-fnu.vikram@xilinx.com> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=2a00:1450:4864:20::244; envelope-from=edgar.iglesias@gmail.com; helo=mail-lj1-x244.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::244 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Alistair Francis , qemu-devel@nongnu.org, "open list:Xilinx ZynqMP" Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: IZvudfZ5rizy On Wed, Apr 22, 2020 at 05:56:07PM -0700, Vikram Garhwal wrote: > Connect CAN0 and CAN1 to ZCU102 board. Comments inline. > > Signed-off-by: Vikram Garhwal > --- > hw/arm/xlnx-zynqmp.c | 26 ++++++++++++++++++++++++++ > include/hw/arm/xlnx-zynqmp.h | 3 +++ > 2 files changed, 29 insertions(+) > > diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c > index b84d153..e5f0d9f 100644 > --- a/hw/arm/xlnx-zynqmp.c > +++ b/hw/arm/xlnx-zynqmp.c > @@ -81,6 +81,14 @@ static const int uart_intr[XLNX_ZYNQMP_NUM_UARTS] = { > 21, 22, > }; > > +static const uint64_t can_addr[XLNX_ZYNQMP_NUM_CAN] = { > + 0xFF060000, 0xFF070000, > +}; > + > +static const int can_intr[XLNX_ZYNQMP_NUM_CAN] = { > + 23, 24, > +}; > + > static const uint64_t sdhci_addr[XLNX_ZYNQMP_NUM_SDHCI] = { > 0xFF160000, 0xFF170000, > }; > @@ -254,6 +262,11 @@ static void xlnx_zynqmp_init(Object *obj) > TYPE_CADENCE_UART); > } > > + for (i = 0; i < XLNX_ZYNQMP_NUM_CAN; i++) { > + sysbus_init_child_obj(obj, "can[*]", &s->can[i], sizeof(s->can[i]), > + TYPE_XLNX_ZYNQMP_CAN); > + } > + > sysbus_init_child_obj(obj, "sata", &s->sata, sizeof(s->sata), > TYPE_SYSBUS_AHCI); > > @@ -508,6 +521,19 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp) > gic_spi[uart_intr[i]]); > } > > + for (i = 0; i < XLNX_ZYNQMP_NUM_CAN; i++) { > + object_property_set_int(OBJECT(&s->can[i]), i, "ctrl-idx", > + &error_abort); > + object_property_set_bool(OBJECT(&s->can[i]), true, "realized", &err); > + if (err) { > + error_propagate(errp, err); > + return; > + } > + sysbus_mmio_map(SYS_BUS_DEVICE(&s->can[i]), 0, can_addr[i]); > + sysbus_connect_irq(SYS_BUS_DEVICE(&s->can[i]), 0, > + gic_spi[can_intr[i]]); > + } > + > object_property_set_int(OBJECT(&s->sata), SATA_NUM_PORTS, "num-ports", > &error_abort); > object_property_set_bool(OBJECT(&s->sata), true, "realized", &err); > diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h > index 53076fa..2be0ff9 100644 > --- a/include/hw/arm/xlnx-zynqmp.h > +++ b/include/hw/arm/xlnx-zynqmp.h > @@ -22,6 +22,7 @@ > #include "hw/intc/arm_gic.h" > #include "hw/net/cadence_gem.h" > #include "hw/char/cadence_uart.h" > +#include "hw/net/xlnx-zynqmp-can.h" > #include "hw/ide/ahci.h" > #include "hw/sd/sdhci.h" > #include "hw/ssi/xilinx_spips.h" > @@ -41,6 +42,7 @@ > #define XLNX_ZYNQMP_NUM_RPU_CPUS 2 > #define XLNX_ZYNQMP_NUM_GEMS 4 > #define XLNX_ZYNQMP_NUM_UARTS 2 > +#define XLNX_ZYNQMP_NUM_CAN 2 > #define XLNX_ZYNQMP_NUM_SDHCI 2 > #define XLNX_ZYNQMP_NUM_SPIS 2 > #define XLNX_ZYNQMP_NUM_GDMA_CH 8 > @@ -92,6 +94,7 @@ typedef struct XlnxZynqMPState { > > CadenceGEMState gem[XLNX_ZYNQMP_NUM_GEMS]; > CadenceUARTState uart[XLNX_ZYNQMP_NUM_UARTS]; > + XlnxZynqMPCANState can[XLNX_ZYNQMP_NUM_CAN]; All those spaces between type and array look odd here. Without those spaces: Reviewed-by: Edgar E. Iglesias > SysbusAHCIState sata; > SDHCIState sdhci[XLNX_ZYNQMP_NUM_SDHCI]; > XilinxSPIPS spi[XLNX_ZYNQMP_NUM_SPIS]; > -- > 2.7.4 >