All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: dm-devel@redhat.com, kernel@collabora.com, khazhy@google.com,
	agk@redhat.com
Subject: Re: [PATCH v2 1/3] md: multipath: Encapsulate parameters passed to selectors
Date: Tue, 28 Apr 2020 13:20:29 -0400	[thread overview]
Message-ID: <20200428172028.GA17285@redhat.com> (raw)
In-Reply-To: <20200428005146.242231-2-krisman@collabora.com>

On Mon, Apr 27 2020 at  8:51pm -0400,
Gabriel Krisman Bertazi <krisman@collabora.com> wrote:

> Different selector will use different parameters, which means .io_start
> and .io_end will get their signatures modified to include more and more
> parameters.  This encapsulates the data in a structure so we can
> simplify the interface for future users.  For now it only passes
> nr_bytes, but HST will require start_time already.
> 
> Cc: Khazhismel Kumykov <khazhy@google.com>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>

I really don't see HST's need for start_time_ns in the path selector's
end_io hook as a solid justification for this encapsulation.

Especially in that the parameters needed for ps's start_io and end_io
really aren't symmetric.  Imposing that they are just causes needless
code (an example of that is in patch 2/3).

So please drop this encapsulation.

Thanks,
Mike

  reply	other threads:[~2020-04-28 17:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  0:51 [PATCH v2 0/3] Historical Service Time Path Selector Gabriel Krisman Bertazi
2020-04-28  0:51 ` [PATCH v2 1/3] md: multipath: Encapsulate parameters passed to selectors Gabriel Krisman Bertazi
2020-04-28 17:20   ` Mike Snitzer [this message]
2020-04-28  0:51 ` [PATCH v2 2/3] md: multipath: Pass io_start_time to the path selector Gabriel Krisman Bertazi
2020-04-28 17:25   ` Mike Snitzer
2020-04-28  0:51 ` [PATCH v2 3/3] md: Add Historical Service Time Path Selector Gabriel Krisman Bertazi
2020-04-30 17:49 ` [PATCH v2 0/3] " Gabriel Krisman Bertazi
2020-04-30 18:33   ` Mike Snitzer
2020-05-01 18:03     ` Mikulas Patocka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200428172028.GA17285@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=kernel@collabora.com \
    --cc=khazhy@google.com \
    --cc=krisman@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.