From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
Linux Network Development Mailing List <netdev@vger.kernel.org>,
Netfilter Development Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] do not typedef socklen_t on Android
Date: Wed, 29 Apr 2020 00:21:57 +0200 [thread overview]
Message-ID: <20200428222157.GA30125@salvia> (raw)
In-Reply-To: <CANP3RGewkX54pqZtironHRCrEYdMF2FZLdKzJz=4GU2CgC=1Mg@mail.gmail.com>
On Mon, Apr 27, 2020 at 05:26:44PM -0700, Maciej Żenczykowski wrote:
> I don't know all that much about it. Mostly it just seems to work.
>
> I'm quoting from: https://en.wikipedia.org/wiki/Bionic_(software) ;-)
>
> Bionic is basically a BSD licensed C library for use with Linux.
> This differs from other BSD C libraries which require a BSD kernel,
> and from the GNU C Library (glibc) which uses the GNU Lesser General
> Public License.
>
> For the most part it's supposed to be drop-in compatible I think,
> and the kernel headers (uapi) come from some recent version of Linux.
>
> The license and smaller size are AFAIK the main benefits.
>
> ---
>
> Got me curious and:
>
> I'm not actually sure what defines __ANDROID__, maybe __BIONIC__ would
> be a better guard?
>
> That seems to be defined in bionic/libc/include/sys/cdefs.h
>
> https://android.googlesource.com/platform/bionic/+/master/libc/include/sys/cdefs.h#43
>
> And the docs here:
>
> https://android.googlesource.com/platform/bionic/+/master/docs/defines.md
>
> do seem to suggest that __BIONIC__ is more equivalent to __GLIBC__
https://sourceforge.net/p/predef/wiki/Libraries/
This one also refers to the existing C library definitions which makes
more sense to me too.
prev parent reply other threads:[~2020-04-28 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 8:15 [PATCH] do not typedef socklen_t on Android Maciej Żenczykowski
2020-04-28 0:06 ` Pablo Neira Ayuso
2020-04-28 0:26 ` Maciej Żenczykowski
2020-04-28 22:21 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428222157.GA30125@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.