From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 031C4C83006 for ; Wed, 29 Apr 2020 06:27:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4CB62072A for ; Wed, 29 Apr 2020 06:27:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I4vZV4PA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726539AbgD2G1c (ORCPT ); Wed, 29 Apr 2020 02:27:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726436AbgD2G1b (ORCPT ); Wed, 29 Apr 2020 02:27:31 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC0ECC035495 for ; Tue, 28 Apr 2020 23:27:29 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id j1so1058811wrt.1 for ; Tue, 28 Apr 2020 23:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wv05h1X7qRrPjYPf9y0VD7+PHwezUYitVP0Fh0igQuY=; b=I4vZV4PACb5f7K2uxifM99GPqkcfyrpLc74PzSrCUF61KrqkAGgKNBFNHr+XiC1Zzr XqIjNrgmZ91TIAda8FEWPq1gg3Xaa84/0qQWu5Ae3sW4csU35iEp2O/nwCWdMpbr7El6 eoZD/tvPP5RteAWgnhbWIY/PMqJ+ssDOZvekrrEimOB3ENhCiVutsoNIJ5zLGgynqmXb 8Rc5rpcdAkqbshwzs7C11AcGOjJ9hcJFu+NIFlqEadlAtAupqh+9vJ50K1QkhtgQmjWR R9djt4X9WtAHl95Nhhfz3sSbWTT0MATduTJ2F9hJdP0sNOI+tsziWlYROFDtUt7Fy1Op uYQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wv05h1X7qRrPjYPf9y0VD7+PHwezUYitVP0Fh0igQuY=; b=JBIILmB8QlIen8SFmyvhM7+ijTR6gEdDR4/N+nLm+ZTDb/HvBPMCgtVbJU9gRRnnQu 9T3XN1qPdhQvDSnZEw2zeNXEHps2xIJwV/vXBJaY+ODJD93t6RgeupopJEjQQOSzdM/Q RUlUFWHIeBHv4tAv64EWG2o4Xo6ihJ45KpBijW1CXAaF45uzjjAuIA5pF0FiShnTl5xl 153LNrgji7z0dfoMpMzfvFVBV5mWQiralbfzQH/88a6dFAY/GHUNXXwaHcV1dN0/tB/A BKn7NJNMUsXLePUV0Z8biUnYjB3u0OKrm4uQubls41tr6cbJQpSzVtJmczMUYNKgh/rb fm2Q== X-Gm-Message-State: AGi0PuaiP2enK8kFeC00vzuyVJ51VcEvrVUQteFXWdDjKBAoPlUZhhXk ZSJiJliAp49Nsom+wNfDta3YAw== X-Google-Smtp-Source: APiQypKTqIt46QQB2nB/SSJZXWRFVeB9A294fdRkNMgBYLOeiiFcpBnVXBSKVh/jOHoB1iCbHHyjSA== X-Received: by 2002:adf:f187:: with SMTP id h7mr37818290wro.331.1588141648280; Tue, 28 Apr 2020 23:27:28 -0700 (PDT) Received: from dell ([2.31.163.63]) by smtp.gmail.com with ESMTPSA id t17sm27729510wro.2.2020.04.28.23.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 23:27:27 -0700 (PDT) Date: Wed, 29 Apr 2020 07:27:25 +0100 From: Lee Jones To: Andy Shevchenko Cc: Michael Walle , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman Subject: Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller Message-ID: <20200429062725.GU3559@dell> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-6-michael@walle.cc> <20200428125049.GU185537@smile.fi.intel.com> <5e2d486077f9e2ce8bd9b171cf806fd9@walle.cc> <20200428144958.GZ185537@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200428144958.GZ185537@smile.fi.intel.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, 28 Apr 2020, Andy Shevchenko wrote: > On Tue, Apr 28, 2020 at 04:43:24PM +0200, Michael Walle wrote: > > Am 2020-04-28 14:50, schrieb Andy Shevchenko: > > > On Thu, Apr 23, 2020 at 07:45:32PM +0200, Michael Walle wrote: > > > > This patch adds core support for the board management controller found > > > > on the SMARC-sAL28 board. It consists of the following functions: > > > > - watchdog > > > > - GPIO controller > > > > - PWM controller > > > > - fan sensor > > > > - interrupt controller > > > > > > ... > > > > > > > obj-$(CONFIG_MFD_STMFX) += stmfx.o > > > > > > > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > > > > + > > > > +obj-$(CONFIG_MFD_SL28CPLD) += sl28cpld.o > > > > > > Perhaps keep an order? > > > > I don't see any order in that makefile. Looked to me like every new > > file was added at the end. > > Okay, just didn't note from above context. Yes, this is historical. I've been meaning to visit this for ~7 years! -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller Date: Wed, 29 Apr 2020 07:27:25 +0100 Message-ID: <20200429062725.GU3559@dell> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-6-michael@walle.cc> <20200428125049.GU185537@smile.fi.intel.com> <5e2d486077f9e2ce8bd9b171cf806fd9@walle.cc> <20200428144958.GZ185537@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20200428144958.GZ185537@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Michael Walle , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier List-Id: linux-pwm@vger.kernel.org On Tue, 28 Apr 2020, Andy Shevchenko wrote: > On Tue, Apr 28, 2020 at 04:43:24PM +0200, Michael Walle wrote: > > Am 2020-04-28 14:50, schrieb Andy Shevchenko: > > > On Thu, Apr 23, 2020 at 07:45:32PM +0200, Michael Walle wrote: > > > > This patch adds core support for the board management controller found > > > > on the SMARC-sAL28 board. It consists of the following functions: > > > > - watchdog > > > > - GPIO controller > > > > - PWM controller > > > > - fan sensor > > > > - interrupt controller > > > > > > ... > > > > > > > obj-$(CONFIG_MFD_STMFX) += stmfx.o > > > > > > > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > > > > + > > > > +obj-$(CONFIG_MFD_SL28CPLD) += sl28cpld.o > > > > > > Perhaps keep an order? > > > > I don't see any order in that makefile. Looked to me like every new > > file was added at the end. > > Okay, just didn't note from above context. Yes, this is historical. I've been meaning to visit this for ~7 years! -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39027C83003 for ; Wed, 29 Apr 2020 06:27:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 029EB2072A for ; Wed, 29 Apr 2020 06:27:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iWs9qwWu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I4vZV4PA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 029EB2072A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qwmYhqMR8RFlJCSg2ZLTM9m2RwbAUs1DtYlUqXBCdBc=; b=iWs9qwWujb/0Va PctLKGJ1X/YCiLwyByR/h6wdr7+8smn0jMhIv7fzuyBdUixExv863f43hjRkcTqUrItw7Zl8VFaGM HZ2dsFOxbggClPtSH5VQnWLhHSKEB2wTlh/Ry/02WKenbUAFfccjTRiDhqCywX2LRX1Pa5IuUgq8E lhzQph6/2W2s2Prmm+va+6FJ8Y/PXGBRgTQf1zqVTV3LjCaVjQOsi1kX1w7nXMcvwlJY2uuqhcr1t DK9B0GLrlaoD6P8d+6rQ1e+33eVnmo0c9gUedtugfE1MHXUV98dLUwT/I27ePjTzvr1/U+nIfn9Kl mz0GUKAGf8E3mor5qdvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTgBx-0000wT-Eb; Wed, 29 Apr 2020 06:27:33 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTgBu-0000w9-Ho for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 06:27:32 +0000 Received: by mail-wr1-x443.google.com with SMTP id i10so1005880wrv.10 for ; Tue, 28 Apr 2020 23:27:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wv05h1X7qRrPjYPf9y0VD7+PHwezUYitVP0Fh0igQuY=; b=I4vZV4PACb5f7K2uxifM99GPqkcfyrpLc74PzSrCUF61KrqkAGgKNBFNHr+XiC1Zzr XqIjNrgmZ91TIAda8FEWPq1gg3Xaa84/0qQWu5Ae3sW4csU35iEp2O/nwCWdMpbr7El6 eoZD/tvPP5RteAWgnhbWIY/PMqJ+ssDOZvekrrEimOB3ENhCiVutsoNIJ5zLGgynqmXb 8Rc5rpcdAkqbshwzs7C11AcGOjJ9hcJFu+NIFlqEadlAtAupqh+9vJ50K1QkhtgQmjWR R9djt4X9WtAHl95Nhhfz3sSbWTT0MATduTJ2F9hJdP0sNOI+tsziWlYROFDtUt7Fy1Op uYQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wv05h1X7qRrPjYPf9y0VD7+PHwezUYitVP0Fh0igQuY=; b=HswyX8kwvE2BDao//nU90XYTiSmfTyi7HKtlfJoQQTwUaX+p2uE84ccbgqfv7713VB C1pClUUgcUUQlXz9zPdyX0pLnmRYobcCPxsg3CZ950B2K+5ZjtlOSjnfRABDM1p5sOuv ZGxxrxhUkXk0em8hvXM40GWAnUgLpXw/iyGr/wiLU9di52fFAUOg8lbF7nt/kvUcaRRa wntHdLEuX20ccovhhXV1VrEzagz/jjfFd3O1vx01J3k6OzSuRd/3oMOtU8UnqMhcMYNt ewQua8za9BXN0IBR45I/Hsk7CWN6ZwhadQHMh/Aws4I8gMwOON2dOwcl4GilpmtgBMZU 571A== X-Gm-Message-State: AGi0PuZZM8CRT7y08ukBfRV2lWTvhX+qC+IdWI69bmbU/IC4dab8jDDr BTXA2/RZ6U0ZNOoM1uAWu1TWHQ== X-Google-Smtp-Source: APiQypKTqIt46QQB2nB/SSJZXWRFVeB9A294fdRkNMgBYLOeiiFcpBnVXBSKVh/jOHoB1iCbHHyjSA== X-Received: by 2002:adf:f187:: with SMTP id h7mr37818290wro.331.1588141648280; Tue, 28 Apr 2020 23:27:28 -0700 (PDT) Received: from dell ([2.31.163.63]) by smtp.gmail.com with ESMTPSA id t17sm27729510wro.2.2020.04.28.23.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2020 23:27:27 -0700 (PDT) Date: Wed, 29 Apr 2020 07:27:25 +0100 From: Lee Jones To: Andy Shevchenko Subject: Re: [PATCH v3 05/16] mfd: Add support for Kontron sl28cpld management controller Message-ID: <20200429062725.GU3559@dell> References: <20200423174543.17161-1-michael@walle.cc> <20200423174543.17161-6-michael@walle.cc> <20200428125049.GU185537@smile.fi.intel.com> <5e2d486077f9e2ce8bd9b171cf806fd9@walle.cc> <20200428144958.GZ185537@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200428144958.GZ185537@smile.fi.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200428_232730_755577_158C0CE4 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Linus Walleij , Thierry Reding , Jason Cooper , Marc Zyngier , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Guenter Roeck , linux-pwm@vger.kernel.org, Jean Delvare , linux-watchdog@vger.kernel.org, linux-gpio@vger.kernel.org, Mark Brown , Thomas Gleixner , Wim Van Sebroeck , linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Li Yang , Michael Walle , Rob Herring , Shawn Guo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyOCBBcHIgMjAyMCwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgoKPiBPbiBUdWUsIEFw ciAyOCwgMjAyMCBhdCAwNDo0MzoyNFBNICswMjAwLCBNaWNoYWVsIFdhbGxlIHdyb3RlOgo+ID4g QW0gMjAyMC0wNC0yOCAxNDo1MCwgc2NocmllYiBBbmR5IFNoZXZjaGVua286Cj4gPiA+IE9uIFRo dSwgQXByIDIzLCAyMDIwIGF0IDA3OjQ1OjMyUE0gKzAyMDAsIE1pY2hhZWwgV2FsbGUgd3JvdGU6 Cj4gPiA+ID4gVGhpcyBwYXRjaCBhZGRzIGNvcmUgc3VwcG9ydCBmb3IgdGhlIGJvYXJkIG1hbmFn ZW1lbnQgY29udHJvbGxlciBmb3VuZAo+ID4gPiA+IG9uIHRoZSBTTUFSQy1zQUwyOCBib2FyZC4g SXQgY29uc2lzdHMgb2YgdGhlIGZvbGxvd2luZyBmdW5jdGlvbnM6Cj4gPiA+ID4gIC0gd2F0Y2hk b2cKPiA+ID4gPiAgLSBHUElPIGNvbnRyb2xsZXIKPiA+ID4gPiAgLSBQV00gY29udHJvbGxlcgo+ ID4gPiA+ICAtIGZhbiBzZW5zb3IKPiA+ID4gPiAgLSBpbnRlcnJ1cHQgY29udHJvbGxlcgo+ID4g PiAKPiA+ID4gLi4uCj4gPiA+IAo+ID4gPiA+ICBvYmotJChDT05GSUdfTUZEX1NUTUZYKSAJKz0g c3RtZngubwo+ID4gPiA+IAo+ID4gPiA+ICBvYmotJChDT05GSUdfU0dJX01GRF9JT0MzKQkrPSBp b2MzLm8KPiA+ID4gPiArCj4gPiA+ID4gK29iai0kKENPTkZJR19NRkRfU0wyOENQTEQpCSs9IHNs MjhjcGxkLm8KPiA+ID4gCj4gPiA+IFBlcmhhcHMga2VlcCBhbiBvcmRlcj8KPiA+IAo+ID4gSSBk b24ndCBzZWUgYW55IG9yZGVyIGluIHRoYXQgbWFrZWZpbGUuIExvb2tlZCB0byBtZSBsaWtlIGV2 ZXJ5IG5ldwo+ID4gZmlsZSB3YXMgYWRkZWQgYXQgdGhlIGVuZC4KPiAKPiBPa2F5LCBqdXN0IGRp ZG4ndCBub3RlIGZyb20gYWJvdmUgY29udGV4dC4KClllcywgdGhpcyBpcyBoaXN0b3JpY2FsLiAg SSd2ZSBiZWVuIG1lYW5pbmcgdG8gdmlzaXQgdGhpcyBmb3IgfjcgeWVhcnMhCgotLSAKTGVlIEpv bmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNobmljYWwgTGVhZApMaW5hcm8ub3Jn IOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFj ZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=