From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC1AC83004 for ; Wed, 29 Apr 2020 09:13:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58CD420775 for ; Wed, 29 Apr 2020 09:13:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rFSWUVwA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58CD420775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0o7PpvR+nVocoUd4TsZzGFe0+ZpxocaPujGwCIJNPcg=; b=rFSWUVwAbJVpqT izK0ECl/xJQjCIOxT6MOvPy27OQpGDlffmhhnh9Rz3xCVUMklOMN5ti5HqgstuiNbqlZD+G2qSmMI dQC8k56cVjrBmdwRUNMxHU1s+obQLcWL7CmBr8D7JtHyprsobqGbfCwvlSBkTfzjMwdaQehn9ypRr tK27lXcJFHJHPPvlwc5J3+41ktmkf3VBLhqcEJPROapX5GztjUmZEGf6KPrNdtoL138p5Buan1+CM 9ooJjx7VINNgCkCGakMhvOStsOs6sW6QRerS5p8dIgMQCdKIkTagn+jg2AKbGhqEpErhpjy+WGGHG fksjZIuYHQimOw+/tHmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTimT-0004nR-9Q; Wed, 29 Apr 2020 09:13:25 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTimP-0004mC-L7; Wed, 29 Apr 2020 09:13:23 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 4AC02FF803; Wed, 29 Apr 2020 09:13:16 +0000 (UTC) Date: Wed, 29 Apr 2020 11:13:14 +0200 From: Miquel Raynal To: Johan Jonker Subject: Re: [PATCH v5 1/7] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Message-ID: <20200429111314.5f15d72b@xps13> In-Reply-To: <4a83e5d2-90cc-1db7-cdfd-47b7ceb4fcef@gmail.com> References: <20200426100250.14678-1-yifeng.zhao@rock-chips.com> <20200426100250.14678-2-yifeng.zhao@rock-chips.com> <4a83e5d2-90cc-1db7-cdfd-47b7ceb4fcef@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_021321_826452_21F2B986 X-CRM114-Status: GOOD ( 13.43 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, vigneshr@ti.com, richard@nod.at, Yifeng Zhao , linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-mtd@lists.infradead.org, heiko@sntech.de Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgSm9oYW4sCgpKb2hhbiBKb25rZXIgPGpieDYyNDRAZ21haWwuY29tPiB3cm90ZSBvbiBXZWQs IDI5IEFwciAyMDIwIDEwOjUzOjMwCiswMjAwOgoKPiBIaSBZaWZlbmcsCj4gCj4gPiBPbiBTdW4s IEFwciAyNiwgMjAyMCBhdCAwNjowMjo0NFBNICswODAwLCBZaWZlbmcgWmhhbyB3cm90ZTogIAo+ ID4+IERvY3VtZW50YXRpb24gc3VwcG9ydCBmb3IgUm9ja2NoaXAgUkszeHh4IE5BTkQgZmxhc2gg Y29udHJvbGxlcnMKPiA+PiAKPiA+PiBTaWduZWQtb2ZmLWJ5OiBZaWZlbmcgWmhhbyA8eWlmZW5n LnpoYW9Acm9jay1jaGlwcy5jb20+Cj4gPj4gLS0tCj4gPj4gCj4gPj4gQ2hhbmdlcyBpbiB2NToK PiA+PiAtIEZpeCBzb21lIHdyb25nIGRlZmluZQo+ID4+IC0gQWRkIGJvb3QtbWVkaXVtIGRlZmlu ZQo+ID4+IC0gUmVtb3ZlIHNvbWUgY29tcGF0aWJsZSBkZWZpbmUKPiA+PiAKPiA+PiBDaGFuZ2Vz IGluIHY0Ogo+ID4+IC0gVGhlIGNvbXBhdGlibGUgZGVmaW5lIHdpdGggcmt4eF9uZmMKPiA+PiAt IEFkZCBhc3NpZ25lZC1jbG9ja3MKPiA+PiAtIEZpeCBzb21lIHdyb25nIGRlZmluZQo+ID4+IAo+ ID4+IENoYW5nZXMgaW4gdjM6Cj4gPj4gLSBDaGFuZ2UgdGhlIHRpdGxlIGZvciB0aGUgZHQtYmlu ZGluZ3MKPiA+PiAKPiA+PiBDaGFuZ2VzIGluIHYyOiBOb25lCj4gPj4gCj4gPj4gIC4uLi9tdGQv cm9ja2NoaXAsbmFuZC1jb250cm9sbGVyLnlhbWwgICAgICAgICB8IDEyNCArKysrKysrKysrKysr KysrKysKPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDEyNCBpbnNlcnRpb25zKCspCj4gPj4gIGNyZWF0 ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL3JvY2tj aGlwLG5hbmQtY29udHJvbGxlci55YW1sCj4gPj4gCj4gPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tdGQvcm9ja2NoaXAsbmFuZC1jb250cm9sbGVyLnlh bWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbXRkL3JvY2tjaGlwLG5hbmQt Y29udHJvbGxlci55YW1sICAKPiAKPiBUaGUgbmFtZSBvZiB0aGlzIGZpbGUgaXMgYmFzZWQgb24g TWlxdWVsJ3Mgb3BpbmlvbiwgYnV0IHRoZQo+IGNvbXBhdGliaWxpdHkgc3RyaW5ncywgKGZvciB3 aGljaCByb2JoIGhhcyBnaXZlbiBhICdyZXZpZXdlZCBieScgdGFnKSBpbgo+IHZlcnNpb24gNCBk b24ndCBmaXQgd2l0aCB0aGlzIGZvcm1hdC4KCldoYXQgZG8geW91IG1lYW4/IElzIHRoZSBmaWxl IG5hbWUgcmVzdHJpY3RlZCBzb21laG93PyBJIGp1c3QgZG9uJ3QKd2FudCBhIGNvbXBhdGlibGUg d2l0aCBqdXN0ICJuYW5kIiBpbiBpdCBiZWNhdXNlIHRoaXMgd29yZCBpcyB0b28gdmFndWUKYXMg aXQgZGVmaW5lczogYSBidXMsIGEgc3BlYywgYSBjaGlwLCBwZW9wbGUgYXJlIGFsc28gY29uZnVz aW5nIGl0IHdpdGgKdGhlIGNvbnRyb2xsZXIgYW5kIHNvbWV0aW1lcyB3aXRoIHRoZSBFQ0MgZW5n aW5lIHRvby4gIm5mYyIgaXMgb2theQp0aG91Z2guCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQg ZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH v5 1/7] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Date: Wed, 29 Apr 2020 11:13:14 +0200 Message-ID: <20200429111314.5f15d72b@xps13> References: <20200426100250.14678-1-yifeng.zhao@rock-chips.com> <20200426100250.14678-2-yifeng.zhao@rock-chips.com> <4a83e5d2-90cc-1db7-cdfd-47b7ceb4fcef@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <4a83e5d2-90cc-1db7-cdfd-47b7ceb4fcef-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Jonker Cc: Yifeng Zhao , richard-/L3Ra7n9ekc@public.gmane.org, vigneshr-l0cyMroinI0@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-rockchip.vger.kernel.org Hi Johan, Johan Jonker wrote on Wed, 29 Apr 2020 10:53:30 +0200: > Hi Yifeng, > > > On Sun, Apr 26, 2020 at 06:02:44PM +0800, Yifeng Zhao wrote: > >> Documentation support for Rockchip RK3xxx NAND flash controllers > >> > >> Signed-off-by: Yifeng Zhao > >> --- > >> > >> Changes in v5: > >> - Fix some wrong define > >> - Add boot-medium define > >> - Remove some compatible define > >> > >> Changes in v4: > >> - The compatible define with rkxx_nfc > >> - Add assigned-clocks > >> - Fix some wrong define > >> > >> Changes in v3: > >> - Change the title for the dt-bindings > >> > >> Changes in v2: None > >> > >> .../mtd/rockchip,nand-controller.yaml | 124 ++++++++++++++++++ > >> 1 file changed, 124 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > > The name of this file is based on Miquel's opinion, but the > compatibility strings, (for which robh has given a 'reviewed by' tag) in > version 4 don't fit with this format. What do you mean? Is the file name restricted somehow? I just don't want a compatible with just "nand" in it because this word is too vague as it defines: a bus, a spec, a chip, people are also confusing it with the controller and sometimes with the ECC engine too. "nfc" is okay though. Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F19C83003 for ; Wed, 29 Apr 2020 09:13:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86B2320775 for ; Wed, 29 Apr 2020 09:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726470AbgD2JNT convert rfc822-to-8bit (ORCPT ); Wed, 29 Apr 2020 05:13:19 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:34861 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbgD2JNT (ORCPT ); Wed, 29 Apr 2020 05:13:19 -0400 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 4AC02FF803; Wed, 29 Apr 2020 09:13:16 +0000 (UTC) Date: Wed, 29 Apr 2020 11:13:14 +0200 From: Miquel Raynal To: Johan Jonker Cc: Yifeng Zhao , richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, heiko@sntech.de, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v5 1/7] dt-bindings: mtd: Describe Rockchip RK3xxx NAND flash controller Message-ID: <20200429111314.5f15d72b@xps13> In-Reply-To: <4a83e5d2-90cc-1db7-cdfd-47b7ceb4fcef@gmail.com> References: <20200426100250.14678-1-yifeng.zhao@rock-chips.com> <20200426100250.14678-2-yifeng.zhao@rock-chips.com> <4a83e5d2-90cc-1db7-cdfd-47b7ceb4fcef@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Johan, Johan Jonker wrote on Wed, 29 Apr 2020 10:53:30 +0200: > Hi Yifeng, > > > On Sun, Apr 26, 2020 at 06:02:44PM +0800, Yifeng Zhao wrote: > >> Documentation support for Rockchip RK3xxx NAND flash controllers > >> > >> Signed-off-by: Yifeng Zhao > >> --- > >> > >> Changes in v5: > >> - Fix some wrong define > >> - Add boot-medium define > >> - Remove some compatible define > >> > >> Changes in v4: > >> - The compatible define with rkxx_nfc > >> - Add assigned-clocks > >> - Fix some wrong define > >> > >> Changes in v3: > >> - Change the title for the dt-bindings > >> > >> Changes in v2: None > >> > >> .../mtd/rockchip,nand-controller.yaml | 124 ++++++++++++++++++ > >> 1 file changed, 124 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > >> > >> diff --git a/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/rockchip,nand-controller.yaml > > The name of this file is based on Miquel's opinion, but the > compatibility strings, (for which robh has given a 'reviewed by' tag) in > version 4 don't fit with this format. What do you mean? Is the file name restricted somehow? I just don't want a compatible with just "nand" in it because this word is too vague as it defines: a bus, a spec, a chip, people are also confusing it with the controller and sometimes with the ECC engine too. "nfc" is okay though. Thanks, Miquèl