From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Michal Kubecek <mkubecek@suse.cz>,
David Jander <david@protonic.nl>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
mkl@pengutronix.de, Marek Vasut <marex@denx.de>,
Christian Herber <christian.herber@nxp.com>
Subject: Re: [PATCH net-next v3 2/2] net: phy: tja11xx: add support for master-slave configuration
Date: Wed, 29 Apr 2020 20:20:53 +0200 [thread overview]
Message-ID: <20200429182053.GM30459@lunn.ch> (raw)
In-Reply-To: <20200428075308.2938-3-o.rempel@pengutronix.de>
> +static int tja11xx_config_aneg(struct phy_device *phydev)
> +{
> + u16 ctl = 0;
> + int ret;
> +
> + switch (phydev->master_slave_set) {
> + case PORT_MODE_CFG_MASTER_FORCE:
> + case PORT_MODE_CFG_MASTER_PREFERRED:
> + ctl |= MII_CFG1_MASTER_SLAVE;
> + break;
> + case PORT_MODE_CFG_SLAVE_FORCE:
> + case PORT_MODE_CFG_SLAVE_PREFERRED:
> + break;
> + case PORT_MODE_CFG_UNKNOWN:
> + return 0;
> + default:
> + phydev_warn(phydev, "Unsupported Master/Slave mode\n");
> + return -ENOTSUPP;
> + }
Does the hardware actually support PORT_MODE_CFG_SLAVE_PREFERRED and
PORT_MODE_CFG_MASTER_PREFERRED? I thought that required autoneg, which
this PHY does not support? So i would of expected these two values to
return ENOTSUPP?
Andrew
next prev parent reply other threads:[~2020-04-29 18:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 7:53 [PATCH net-next v3 0/2] provide support for PHY master/slave configuration Oleksij Rempel
2020-04-28 7:53 ` [PATCH net-next v3 1/2] ethtool: provide UAPI " Oleksij Rempel
2020-04-29 18:16 ` Andrew Lunn
2020-04-30 4:37 ` Oleksij Rempel
2020-04-30 14:24 ` Andrew Lunn
2020-04-29 19:52 ` Michal Kubecek
2020-04-30 5:00 ` Oleksij Rempel
2020-04-30 8:20 ` Michal Kubecek
2020-04-30 12:09 ` Oleksij Rempel
2020-04-30 12:25 ` Michal Kubecek
2020-04-28 7:53 ` [PATCH net-next v3 2/2] net: phy: tja11xx: add support for master-slave configuration Oleksij Rempel
2020-04-29 18:20 ` Andrew Lunn [this message]
2020-04-30 5:03 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429182053.GM30459@lunn.ch \
--to=andrew@lunn.ch \
--cc=christian.herber@nxp.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=mkl@pengutronix.de \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.