From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF761C8300B for ; Thu, 30 Apr 2020 10:16:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 909DB2082E for ; Thu, 30 Apr 2020 10:16:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="BPAQAVg2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 909DB2082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jU6Ej-00051K-9P; Thu, 30 Apr 2020 10:16:09 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jU6Eh-00050b-8w for xen-devel@lists.xenproject.org; Thu, 30 Apr 2020 10:16:07 +0000 X-Inumbo-ID: 9a126efc-8acb-11ea-b9cf-bc764e2007e4 Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 9a126efc-8acb-11ea-b9cf-bc764e2007e4; Thu, 30 Apr 2020 10:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1588241766; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=gHM5xaEnupw7A89FhNhhvExQxC2eIu4fTQ1Mu+651Go=; b=BPAQAVg2Z+rhepVeLxxnBHLg9SdmQ/jneQy3hIzdD0gcSwqk9XW7OyQD XkTQvW7yvCBjflKSgDaZmEJA8OywYetOEAS1Eo0N4mwvt1DwcATLJtdQE RfL5lls2SjoMMJDMo7LAoefKMGKOsemx3XT0wNYRfyev+VIjqvJghrTMd c=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: cDUZ/JW8Rb9GDPYHkVGwiHA93AGCj4sImeakv5AsCDn74Nzn9SQMCH33b8ci8hYPO1IHQ7sT7C GF1UdCSEk/YhlJoBAj7MLa+tkeXfuEv/jdCPJZt8HWv4/hwfTrei8yDwkjhUhOpxlHbAcltRmY g6aaD7ODNTNSvXu/n0OOOGRpstXM1StNXrohoWaD5LPxqi1P5m2CLAawPTiGhdCVRbtMrEWdf6 UQe2ePLmnTzoDN+wP/Dghhb6NdDHP8G+fpA0FXJMfUSr/jfHhrZ+6CnVUQXDLcuLYQnoq2j9Ul FYo= X-SBRS: 2.7 X-MesageID: 16509149 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.73,334,1583211600"; d="scan'208";a="16509149" Date: Thu, 30 Apr 2020 12:15:58 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Wei Liu Subject: Re: [PATCH] x86/hyperv: stash and use the configured max VP index Message-ID: <20200430101558.GA28601@Air-de-Roger> References: <20200429104144.17816-1-liuwe@microsoft.com> <20200429114718.zclpy6r6sbxuo6ph@liuwe-devbox-debian-v2.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200429114718.zclpy6r6sbxuo6ph@liuwe-devbox-debian-v2.j3c5onc20sse1dnehy4noqpfcg.zx.internal.cloudapp.net> X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Paul Durrant , Andrew Cooper , Michael Kelley , Jan Beulich , Xen Development List Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Wed, Apr 29, 2020 at 11:47:18AM +0000, Wei Liu wrote: > On Wed, Apr 29, 2020 at 11:41:44AM +0100, Wei Liu wrote: > > The value returned from CPUID is the maximum number for virtual > > processors supported by Hyper-V. It could be larger than the maximum > > number of virtual processors configured. > > > > Stash the configured number into a variable and use it in calculations. > > > > Signed-off-by: Wei Liu > > --- > > xen/arch/x86/guest/hyperv/hyperv.c | 4 ++++ > > xen/arch/x86/guest/hyperv/private.h | 1 + > > xen/arch/x86/guest/hyperv/tlb.c | 2 +- > > xen/arch/x86/guest/hyperv/util.c | 2 +- > > 4 files changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/xen/arch/x86/guest/hyperv/hyperv.c b/xen/arch/x86/guest/hyperv/hyperv.c > > index 91a6782cd986..84221b751453 100644 > > --- a/xen/arch/x86/guest/hyperv/hyperv.c > > +++ b/xen/arch/x86/guest/hyperv/hyperv.c > > @@ -33,6 +33,7 @@ DEFINE_PER_CPU_READ_MOSTLY(void *, hv_input_page); > > DEFINE_PER_CPU_READ_MOSTLY(void *, hv_vp_assist); > > DEFINE_PER_CPU_READ_MOSTLY(unsigned int, hv_vp_index); > > > > +unsigned int __read_mostly hv_max_vp_index; > > static bool __read_mostly hcall_page_ready; > > > > static uint64_t generate_guest_id(void) > > @@ -143,6 +144,9 @@ static int setup_hypercall_pcpu_arg(void) > > rdmsrl(HV_X64_MSR_VP_INDEX, vp_index_msr); > > this_cpu(hv_vp_index) = vp_index_msr; > > > > + if ( vp_index_msr > hv_max_vp_index ) > > + hv_max_vp_index = vp_index_msr; > > + > > return 0; > > } > > > > diff --git a/xen/arch/x86/guest/hyperv/private.h b/xen/arch/x86/guest/hyperv/private.h > > index 354fc7f685a7..fea3e291e944 100644 > > --- a/xen/arch/x86/guest/hyperv/private.h > > +++ b/xen/arch/x86/guest/hyperv/private.h > > @@ -28,6 +28,7 @@ > > DECLARE_PER_CPU(void *, hv_input_page); > > DECLARE_PER_CPU(void *, hv_vp_assist); > > DECLARE_PER_CPU(unsigned int, hv_vp_index); > > +extern unsigned int hv_max_vp_index; > > > > static inline unsigned int hv_vp_index(unsigned int cpu) > > { > > diff --git a/xen/arch/x86/guest/hyperv/tlb.c b/xen/arch/x86/guest/hyperv/tlb.c > > index 1d723d6ee679..0a44071481bd 100644 > > --- a/xen/arch/x86/guest/hyperv/tlb.c > > +++ b/xen/arch/x86/guest/hyperv/tlb.c > > @@ -166,7 +166,7 @@ int hyperv_flush_tlb(const cpumask_t *mask, const void *va, > > { > > unsigned int vpid = hv_vp_index(cpu); > > > > - if ( vpid >= ms_hyperv.max_vp_index ) > > + if ( vpid >= hv_max_vp_index ) > > I think the >= should be changed to > here. I agree. With this fixed: Reviewed-by: Roger Pau Monné Thanks!