From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 03/11] xfs: remove the xfs_inode_log_item_t typedef
Date: Thu, 30 Apr 2020 07:03:08 -0400 [thread overview]
Message-ID: <20200430110308.GC5349@bfoster> (raw)
In-Reply-To: <20200429150511.2191150-4-hch@lst.de>
On Wed, Apr 29, 2020 at 05:05:03PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/libxfs/xfs_inode_fork.c | 2 +-
> fs/xfs/libxfs/xfs_trans_inode.c | 2 +-
> fs/xfs/xfs_inode.c | 4 ++--
> fs/xfs/xfs_inode_item.c | 2 +-
> fs/xfs/xfs_inode_item.h | 4 ++--
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_inode_fork.c b/fs/xfs/libxfs/xfs_inode_fork.c
> index 518c6f0ec3a61..3e9a42f1e23b9 100644
> --- a/fs/xfs/libxfs/xfs_inode_fork.c
> +++ b/fs/xfs/libxfs/xfs_inode_fork.c
> @@ -592,7 +592,7 @@ void
> xfs_iflush_fork(
> xfs_inode_t *ip,
> xfs_dinode_t *dip,
> - xfs_inode_log_item_t *iip,
> + struct xfs_inode_log_item *iip,
> int whichfork)
> {
> char *cp;
> diff --git a/fs/xfs/libxfs/xfs_trans_inode.c b/fs/xfs/libxfs/xfs_trans_inode.c
> index 2b8ccb5b975df..b5dfb66548422 100644
> --- a/fs/xfs/libxfs/xfs_trans_inode.c
> +++ b/fs/xfs/libxfs/xfs_trans_inode.c
> @@ -27,7 +27,7 @@ xfs_trans_ijoin(
> struct xfs_inode *ip,
> uint lock_flags)
> {
> - xfs_inode_log_item_t *iip;
> + struct xfs_inode_log_item *iip;
>
> ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
> if (ip->i_itemp == NULL)
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
> index d1772786af29d..0e2ef3f56be41 100644
> --- a/fs/xfs/xfs_inode.c
> +++ b/fs/xfs/xfs_inode.c
> @@ -2602,7 +2602,7 @@ xfs_ifree_cluster(
> xfs_daddr_t blkno;
> xfs_buf_t *bp;
> xfs_inode_t *ip;
> - xfs_inode_log_item_t *iip;
> + struct xfs_inode_log_item *iip;
> struct xfs_log_item *lip;
> struct xfs_perag *pag;
> struct xfs_ino_geometry *igeo = M_IGEO(mp);
> @@ -2662,7 +2662,7 @@ xfs_ifree_cluster(
> */
> list_for_each_entry(lip, &bp->b_li_list, li_bio_list) {
> if (lip->li_type == XFS_LI_INODE) {
> - iip = (xfs_inode_log_item_t *)lip;
> + iip = (struct xfs_inode_log_item *)lip;
> ASSERT(iip->ili_logged == 1);
> lip->li_cb = xfs_istale_done;
> xfs_trans_ail_copy_lsn(mp->m_ail,
> diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c
> index f779cca2346f3..75b74bbe38e43 100644
> --- a/fs/xfs/xfs_inode_item.c
> +++ b/fs/xfs/xfs_inode_item.c
> @@ -780,7 +780,7 @@ xfs_iflush_abort(
> xfs_inode_t *ip,
> bool stale)
> {
> - xfs_inode_log_item_t *iip = ip->i_itemp;
> + struct xfs_inode_log_item *iip = ip->i_itemp;
>
> if (iip) {
> if (test_bit(XFS_LI_IN_AIL, &iip->ili_item.li_flags)) {
> diff --git a/fs/xfs/xfs_inode_item.h b/fs/xfs/xfs_inode_item.h
> index 07a60e74c39c8..ad667fd4ae622 100644
> --- a/fs/xfs/xfs_inode_item.h
> +++ b/fs/xfs/xfs_inode_item.h
> @@ -13,7 +13,7 @@ struct xfs_bmbt_rec;
> struct xfs_inode;
> struct xfs_mount;
>
> -typedef struct xfs_inode_log_item {
> +struct xfs_inode_log_item {
> struct xfs_log_item ili_item; /* common portion */
> struct xfs_inode *ili_inode; /* inode ptr */
> xfs_lsn_t ili_flush_lsn; /* lsn at last flush */
> @@ -23,7 +23,7 @@ typedef struct xfs_inode_log_item {
> unsigned int ili_last_fields; /* fields when flushed */
> unsigned int ili_fields; /* fields to be logged */
> unsigned int ili_fsync_fields; /* logged since last fsync */
> -} xfs_inode_log_item_t;
> +};
>
> static inline int xfs_inode_clean(xfs_inode_t *ip)
> {
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-04-30 11:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 15:05 deferred operations cleanup Christoph Hellwig
2020-04-29 15:05 ` [PATCH 01/11] xfs: remove the xfs_efi_log_item_t typedef Christoph Hellwig
2020-04-30 11:02 ` Brian Foster
2020-04-29 15:05 ` [PATCH 02/11] xfs: remove the xfs_efd_log_item_t typedef Christoph Hellwig
2020-04-30 11:03 ` Brian Foster
2020-04-29 15:05 ` [PATCH 03/11] xfs: remove the xfs_inode_log_item_t typedef Christoph Hellwig
2020-04-30 11:03 ` Brian Foster [this message]
2020-04-29 15:05 ` [PATCH 04/11] xfs: factor out a xfs_defer_create_intent helper Christoph Hellwig
2020-04-30 11:03 ` Brian Foster
2020-04-29 15:05 ` [PATCH 05/11] xfs: merge the ->log_item defer op into ->create_intent Christoph Hellwig
2020-04-30 11:04 ` Brian Foster
2020-04-29 15:05 ` [PATCH 06/11] xfs: merge the ->diff_items " Christoph Hellwig
2020-04-30 11:04 ` Brian Foster
2020-04-29 15:05 ` [PATCH 07/11] xfs: turn dfp_intent into a xfs_log_item Christoph Hellwig
2020-04-30 11:04 ` Brian Foster
2020-04-29 15:05 ` [PATCH 08/11] xfs: refactor xfs_defer_finish_noroll Christoph Hellwig
2020-04-30 11:04 ` Brian Foster
2020-04-29 15:05 ` [PATCH 09/11] xfs: turn dfp_done into a xfs_log_item Christoph Hellwig
2020-04-30 11:04 ` Brian Foster
2020-04-29 15:05 ` [PATCH 10/11] xfs: use a xfs_btree_cur for the ->finish_cleanup state Christoph Hellwig
2020-04-30 11:04 ` Brian Foster
2020-04-29 15:05 ` [PATCH 11/11] xfs: spell out the parameter name for ->cancel_item Christoph Hellwig
2020-04-30 11:04 ` Brian Foster
2020-04-30 15:35 ` deferred operations cleanup Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430110308.GC5349@bfoster \
--to=bfoster@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.