From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: bug: Kbuild seems to require "make prepare-objtool" in order to use (some) new config vars
Date: Thu, 30 Apr 2020 13:17:15 +0200 [thread overview]
Message-ID: <20200430131715.32c1a1f6@coco.lan> (raw)
Hi Masahiro,
Not sure if this was already reported (or eventually fixed) upstream.
While doing a Kconfig reorg on media, I noticed a few weird things,
requiring me to call, on a few situations, "make modules_prepare"
manually after some changes.
I'm now working on a patchset to yet to be merged upstream aiming to
resurrect a driver from staging. It is currently on this tree
(with is based at the media development tree, on the top of 5.7-rc1):
https://git.linuxtv.org/mchehab/experimental.git/log/?h=atomisp_v2
There, I was able to identify a misbehavior that it is probably
what forced me to need calling "make modules_prepare".
The atomisp driver is on a very bad shape. Among its problems, it has a
set of header definitions that should be different for two different
variants of the supported devices. In order to be able to compile for
either one of the variants, I added a new config var:
CONFIG_VIDEO_ATOMISP_ISP2401.
The problem is that calling just
./scripts/config -e CONFIG_VIDEO_ATOMISP_ISP2401
or
./scripts/config -d CONFIG_VIDEO_ATOMISP_ISP2401
is not enough anymore for the build to actually use the new config value.
It just keeps silently using the old config value.
I double-checked it by adding this macro at the Makefile:
$(info ************ ISP2401: $(CONFIG_VIDEO_ATOMISP_ISP2401) ************)
The Makefile doesn't see the change, except if I explicitly call
"make modules_prepare" or "make prepare-objtool".
Even calling "make oldconfig" doesn't make it use the new CONFIG_*
value.
Thanks,
Mauro
next reply other threads:[~2020-04-30 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 11:17 Mauro Carvalho Chehab [this message]
2020-04-30 13:51 ` bug: Kbuild seems to require "make prepare-objtool" in order to use (some) new config vars Masahiro Yamada
2020-04-30 16:49 ` Mauro Carvalho Chehab
2020-04-30 17:20 ` Masahiro Yamada
2020-04-30 19:10 ` Mauro Carvalho Chehab
2020-04-30 19:25 ` [PATCH RFC] Kbuild: Makefile: warn if auto.conf is obsolete Mauro Carvalho Chehab
2020-05-01 3:27 ` Masahiro Yamada
2020-05-01 2:31 ` bug: Kbuild seems to require "make prepare-objtool" in order to use (some) new config vars Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430131715.32c1a1f6@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.