From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ti-ads8344: optimize consumption
Date: Thu, 30 Apr 2020 22:17:59 +0200 [thread overview]
Message-ID: <20200430201759.GY51277@piout.net> (raw)
In-Reply-To: <20200418161322.71b2b353@archlinux>
Hi,
On 18/04/2020 16:13:22+0100, Jonathan Cameron wrote:
> On Thu, 16 Apr 2020 22:54:28 +0200
> Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
>
> > Set the clock mode only once, at probe time and then keep the ADC powered
> > down between conversions.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Looks fine to me. I'd like to be lazy and not take this until the fix is
> in my upstream (even though I suspect the merge would be fine).
>
> Give me a poke if I seem to have forgotten this after that is true!
>
It now landed in your upstream but I guess you want to take Gregory's
patch as a fix first. To be honest I don't think any of the fixes are
urgent as it seems we are the only users of the particular ADC.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-04-30 20:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 20:54 [PATCH v2 0/2] iio: adc: ti-ads8344: driver improvements Alexandre Belloni
2020-04-16 20:54 ` [PATCH v2 1/2] iio: adc: ti-ads8344: properly byte swap value Alexandre Belloni
2020-04-17 10:44 ` Andy Shevchenko
2020-04-17 10:47 ` Andy Shevchenko
2020-04-17 11:13 ` Alexandre Belloni
2020-04-17 13:43 ` Andy Shevchenko
2020-04-17 13:45 ` Andy Shevchenko
2020-04-17 14:23 ` Alexandre Belloni
2020-04-18 15:06 ` Jonathan Cameron
2020-04-16 20:54 ` [PATCH v2 2/2] iio: adc: ti-ads8344: optimize consumption Alexandre Belloni
2020-04-18 15:13 ` Jonathan Cameron
2020-04-30 20:17 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430201759.GY51277@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=gregory.clement@bootlin.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.