From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: johannes.berg@intel.com, kvalo@codeaurora.org,
luciano.coelho@intel.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] iwlwifi: mvm: limit maximum queue appropriately" failed to apply to 4.19-stable tree
Date: Thu, 30 Apr 2020 20:44:10 -0400 [thread overview]
Message-ID: <20200501004410.GC13035@sasha-vm> (raw)
In-Reply-To: <1588003092239253@kroah.com>
On Mon, Apr 27, 2020 at 05:58:12PM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 4.19-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From e5b72e3bc4763152e24bf4b8333bae21cc526c56 Mon Sep 17 00:00:00 2001
>From: Johannes Berg <johannes.berg@intel.com>
>Date: Fri, 17 Apr 2020 10:08:12 +0300
>Subject: [PATCH] iwlwifi: mvm: limit maximum queue appropriately
>
>Due to some hardware issues, queue 31 isn't usable on devices that have
>32 queues (7000, 8000, 9000 families), which is correctly reflected in
>the configuration and TX queue initialization.
>
>However, the firmware API and queue allocation code assumes that there
>are 32 queues, and if something actually attempts to use #31 this leads
>to a NULL-pointer dereference since it's not allocated.
>
>Fix this by limiting to 31 in the IWL_MVM_DQA_MAX_DATA_QUEUE, and also
>add some code to catch this earlier in the future, if the configuration
>changes perhaps.
>
>Cc: stable@vger.kernel.org # v4.9+
>Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>Link: https://lore.kernel.org/r/iwlwifi.20200417100405.98a79be2db6a.I3a4af6b03b87a6bc18db9b1ff9a812f397bee1fc@changeid
iwl_mvm_find_free_queue() lives in a different file. Fixed and queued up
for 4.9+.
--
Thanks,
Sasha
prev parent reply other threads:[~2020-05-01 0:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 15:58 FAILED: patch "[PATCH] iwlwifi: mvm: limit maximum queue appropriately" failed to apply to 4.19-stable tree gregkh
2020-05-01 0:44 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501004410.GC13035@sasha-vm \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes.berg@intel.com \
--cc=kvalo@codeaurora.org \
--cc=luciano.coelho@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.