From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5723C4724C for ; Fri, 1 May 2020 00:57:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A270206C0 for ; Fri, 1 May 2020 00:57:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="Db44IUCm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2dpHcfa2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A270206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B6974836; Fri, 1 May 2020 02:56:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B6974836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1588294668; bh=qzVIbLzLR1waAT8wlVFyTN88f+j4YehVbaac6sHmrqg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Db44IUCmj62nt9/O96oNn2hv2VVSTiELTRmcDB5K73GWhBoHxF8T6qXbciMyIkksT tvC1hzy4WcCH6V3gKIsQM4NKFNLc2KHbpRpXvw13zfJNz2KOcrfvV14xHxIy0Nd2TB acc2CU9LB84dPSpITRNUD+qHFR6Z0KYUQi7vPyTk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 457BDF80123; Fri, 1 May 2020 02:56:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6D5E9F801EB; Fri, 1 May 2020 02:56:52 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1D57DF80123 for ; Fri, 1 May 2020 02:56:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1D57DF80123 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2dpHcfa2" Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F128206C0; Fri, 1 May 2020 00:56:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588294598; bh=qzVIbLzLR1waAT8wlVFyTN88f+j4YehVbaac6sHmrqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2dpHcfa2x6CWh90gpUjnXE6dUI69GmXxQwjq0IWsjL0YhUq3U2tGgrcuVqXjB90MX H1jQG+xAN+jdyLJz6GqCfPvJGD2K22GTYUadDRhGRGWqMWbJIY5rsXKUPZl5prEJAC 7x7XxBnFtK5xqJvRl2tnkSTkDzCCjNwGm6TQfHhA= Date: Thu, 30 Apr 2020 20:56:37 -0400 From: Sasha Levin To: Takashi Iwai Subject: Re: [PATCH AUTOSEL 4.9 03/13] ALSA: hda: Keep the controller initialization even if no codecs found Message-ID: <20200501005637.GD13035@sasha-vm> References: <20200424122447.10882-1-sashal@kernel.org> <20200424122447.10882-3-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, Roy Spliet , linux-kernel@vger.kernel.org, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Apr 24, 2020 at 02:45:55PM +0200, Takashi Iwai wrote: >On Fri, 24 Apr 2020 14:24:36 +0200, >Sasha Levin wrote: >> >> From: Takashi Iwai >> >> [ Upstream commit 9479e75fca370a5220784f7596bf598c4dad0b9b ] >> >> Currently, when the HD-audio controller driver doesn't detect any >> codecs, it tries to abort the probe. But this abort happens at the >> delayed probe, i.e. the primary probe call already returned success, >> hence the driver is never unbound until user does so explicitly. >> As a result, it may leave the HD-audio device in the running state >> without the runtime PM. More badly, if the device is a HD-audio bus >> that is tied with a GPU, GPU cannot reach to the full power down and >> consumes unnecessarily much power. >> >> This patch changes the logic after no-codec situation; it continues >> probing without the further codec initialization but keep the >> controller driver running normally. >> >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207043 >> Tested-by: Roy Spliet >> Link: https://lore.kernel.org/r/20200413082034.25166-5-tiwai@suse.de >> Signed-off-by: Takashi Iwai >> Signed-off-by: Sasha Levin > >Applying this without other commits isn't recommended, especially for >the older branches. Maybe OK up from 4.19, but I'd avoid applying for >the older. Okay, I've dropped it from branches older than 4.19. Thanks! -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C877FC47247 for ; Fri, 1 May 2020 00:56:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99D0B2074A for ; Fri, 1 May 2020 00:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588294599; bh=qzVIbLzLR1waAT8wlVFyTN88f+j4YehVbaac6sHmrqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YdrY0D5+fpcZGv/o2vHtdL013DXMvjYK8Ks+CksPf90k3xVjACCzI9rOmQTHZeonw obPOLYknfQdVX4+4Oi7Jy8RxM0CYgtsLbVQvUlncTafagxJrqMhnpVQ4GVdOQv2I4O h3EbyVrnOcRZZazNHTt7UvZPD5bgGTxvZbXPSQeo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728001AbgEAA4j (ORCPT ); Thu, 30 Apr 2020 20:56:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:58054 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726384AbgEAA4i (ORCPT ); Thu, 30 Apr 2020 20:56:38 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F128206C0; Fri, 1 May 2020 00:56:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588294598; bh=qzVIbLzLR1waAT8wlVFyTN88f+j4YehVbaac6sHmrqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2dpHcfa2x6CWh90gpUjnXE6dUI69GmXxQwjq0IWsjL0YhUq3U2tGgrcuVqXjB90MX H1jQG+xAN+jdyLJz6GqCfPvJGD2K22GTYUadDRhGRGWqMWbJIY5rsXKUPZl5prEJAC 7x7XxBnFtK5xqJvRl2tnkSTkDzCCjNwGm6TQfHhA= Date: Thu, 30 Apr 2020 20:56:37 -0400 From: Sasha Levin To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Roy Spliet , alsa-devel@alsa-project.org Subject: Re: [PATCH AUTOSEL 4.9 03/13] ALSA: hda: Keep the controller initialization even if no codecs found Message-ID: <20200501005637.GD13035@sasha-vm> References: <20200424122447.10882-1-sashal@kernel.org> <20200424122447.10882-3-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 24, 2020 at 02:45:55PM +0200, Takashi Iwai wrote: >On Fri, 24 Apr 2020 14:24:36 +0200, >Sasha Levin wrote: >> >> From: Takashi Iwai >> >> [ Upstream commit 9479e75fca370a5220784f7596bf598c4dad0b9b ] >> >> Currently, when the HD-audio controller driver doesn't detect any >> codecs, it tries to abort the probe. But this abort happens at the >> delayed probe, i.e. the primary probe call already returned success, >> hence the driver is never unbound until user does so explicitly. >> As a result, it may leave the HD-audio device in the running state >> without the runtime PM. More badly, if the device is a HD-audio bus >> that is tied with a GPU, GPU cannot reach to the full power down and >> consumes unnecessarily much power. >> >> This patch changes the logic after no-codec situation; it continues >> probing without the further codec initialization but keep the >> controller driver running normally. >> >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207043 >> Tested-by: Roy Spliet >> Link: https://lore.kernel.org/r/20200413082034.25166-5-tiwai@suse.de >> Signed-off-by: Takashi Iwai >> Signed-off-by: Sasha Levin > >Applying this without other commits isn't recommended, especially for >the older branches. Maybe OK up from 4.19, but I'd avoid applying for >the older. Okay, I've dropped it from branches older than 4.19. Thanks! -- Thanks, Sasha