From: Al Viro <viro@zeniv.linux.org.uk>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT
Date: Fri, 1 May 2020 04:58:20 +0100 [thread overview]
Message-ID: <20200501035820.GH23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <273d8294-2508-a4c2-f96e-a6a394f94166@kernel.dk>
On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote:
> Pipe read/write only checks for the file O_NONBLOCK flag, but we should
> also check for IOCB_NOWAIT for whether or not we should handle this read
> or write in a non-blocking fashion. If we don't, then we will block on
> data or space for iocbs that explicitly asked for non-blocking
> operation. This messes up callers that explicitly ask for non-blocking
> operations.
Why does io_uring allow setting IOCB_NOWAIT without FMODE_NOWAIT, anyway?
next prev parent reply other threads:[~2020-05-01 3:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 16:24 [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT Jens Axboe
2020-04-30 17:58 ` Matthew Wilcox
2020-04-30 18:47 ` Jens Axboe
2020-04-30 19:51 ` Jens Axboe
2020-04-30 19:56 ` Jens Axboe
2020-05-01 3:58 ` Al Viro [this message]
2020-05-01 4:14 ` Jens Axboe
2020-05-01 4:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501035820.GH23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.