From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/4] syscalls/fanotify09: Check merging of events on directories
Date: Fri, 1 May 2020 17:17:42 +1000 [thread overview]
Message-ID: <20200501071740.GA2217@morpheus.bobrowski.net> (raw)
In-Reply-To: <20200421065002.12417-2-amir73il@gmail.com>
On Tue, Apr 21, 2020 at 09:49:59AM +0300, Amir Goldstein wrote:
> +static void event_res(int ttype, int group,
> + struct fanotify_event_metadata *event)
> +{
> + int len;
> + sprintf(symlnk, "/proc/self/fd/%d", event->fd);
> + len = readlink(symlnk, fdpath, sizeof(fdpath));
> + if (len < 0)
> + len = 0;
> + fdpath[len] = 0;
> + tst_res(ttype, "group %d got event: mask %llx pid=%u fd=%d path=%s",
> + group, (unsigned long long)event->mask,
> + (unsigned)event->pid, event->fd, fdpath);
> +}
Nice helper, although it would be nice not to see all these statements
clunked together like this.
> - * generate FAN_CLOSE_NOWRITE event on a child subdir.
> + * generate FAN_CLOSE_NOWRITE event on a testdir (subdir or ".")
^ s/g/G :P
Reviewed-by: Matthew Bobrowski <mbobrowski@mbobrowski.org>
/M
next prev parent reply other threads:[~2020-05-01 7:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 6:49 [LTP] [PATCH 0/4] fanotify ltp tests for v5.7-rc1 Amir Goldstein
2020-04-21 6:49 ` [LTP] [PATCH 1/4] syscalls/fanotify09: Check merging of events on directories Amir Goldstein
2020-04-27 17:27 ` Petr Vorel
2020-05-01 7:17 ` Matthew Bobrowski [this message]
2020-05-01 9:05 ` Amir Goldstein
2020-05-01 9:46 ` Matthew Bobrowski
2020-04-21 6:50 ` [LTP] [PATCH 2/4] syscalls/fanotify15: Minor corrections Amir Goldstein
2020-04-27 19:30 ` Petr Vorel
2020-04-29 15:08 ` Cyril Hrubis
2020-05-01 8:09 ` Matthew Bobrowski
2020-04-21 6:50 ` [LTP] [PATCH 3/4] syscalls/fanotify15: Add a test case for inode marks Amir Goldstein
2020-04-27 19:43 ` Petr Vorel
2020-04-28 9:20 ` Petr Vorel
2020-04-29 15:28 ` Cyril Hrubis
2020-05-02 7:09 ` Matthew Bobrowski
2020-05-02 13:17 ` Amir Goldstein
2020-04-21 6:50 ` [LTP] [PATCH 4/4] syscalls/fanotify: New test for FAN_MODIFY_DIR Amir Goldstein
2020-04-27 16:49 ` Petr Vorel
2020-04-28 9:22 ` Petr Vorel
2020-04-28 9:51 ` Amir Goldstein
2020-04-29 16:02 ` Cyril Hrubis
2020-05-02 9:39 ` Matthew Bobrowski
2020-05-02 14:58 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501071740.GA2217@morpheus.bobrowski.net \
--to=mbobrowski@mbobrowski.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.