Re: [PATCH 00/17] mtd: rawnand: cafe: Convert to exec_op() (and more)

From: Boris Brezillon <boris.brezillon@collabora.com>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Tudor Ambarus <tudor.ambarus@microchip.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 00/17] mtd: rawnand: cafe: Convert to exec_op() (and more)
Date: Fri, 1 May 2020 08:21:28 +0200	[thread overview]
Message-ID: <20200501082128.23b81dab@collabora.com> (raw)
In-Reply-To: <20200501055209.GA44510@furthur.local>

On Fri, 1 May 2020 07:52:09 +0200
Lubomir Rintel <lkundrak@v3.sk> wrote:

> On Wed, Apr 29, 2020 at 10:28:41AM +0200, Boris Brezillon wrote:
> > Hi Thomas,
> > 
> > On Wed, 29 Apr 2020 08:37:35 +0200
> > Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> >   
> > > Hello,
> > > 
> > > +Lubomir Rintel in Cc.
> > > 
> > > On Mon, 27 Apr 2020 10:20:10 +0200
> > > Boris Brezillon <boris.brezillon@collabora.com> wrote:
> > >   
> > > > A bit of context to explain the motivation behind those conversions
> > > > I've been sending for the last couple of weeks. The raw NAND subsystem
> > > > carries a lot of history which makes any rework not only painful, but
> > > > also subject to regressions which we only detect when someone dares to
> > > > update its kernel on one of those ancient HW. While carrying drivers
> > > > for old HW is not a problem per se, carrying ancient and unmaintained
> > > > drivers that are not converted to new APIs is a maintenance burden,
> > > > hence this massive conversion attempt I'm conducting here.
> > > > 
> > > > So here it is, a series converting the CAFE NAND controller driver to
> > > > exec_op(), plus a bunch of minor improvements done along the way.
> > > > I hope I'll find someone to test those changes, but if there's no one
> > > > still owning OLPC HW or no interest in keeping it supported in recent
> > > > kernel versions, we should definitely consider removing the driver
> > > > instead.    
> > > 
> > > Lubomir Rintel (in Cc) has very recently added defconfigs to Buildroot
> > > to support the two OLPC platforms (the Intel based one and the Marvell
> > > MMP based one). I suppose this means he has access to the hardware, so
> > > hopefully he should be able to test these NAND driver changes.  
> > 
> > Oh, that's great news! Thanks a lot for letting me know.
> > 
> > Lubomir, let me know if you'd be okay to test those changes. I can
> > provide a branch if that's easier.  
> 
> Boris, I'd be happy to test the changes. A branch would help.

Here it is [1].

> I've
> applied the patches on top of 5.7-rc3 and while they applied cleanly,
> they've failed to build:
> 
>   drivers/mtd/nand/raw/cafe_nand.c: In function ‘cafe_nand_exec_subop’:
>   drivers/mtd/nand/raw/cafe_nand.c:581:19: error: ‘const struct nand_subop’ has no member named ‘cs’
>     581 |  if (WARN_ON(subop->cs > 1))
>         |  
                 ^~

Yep, it depends on a patch that was part of a separate series.

I'm here to help if you have any issues.

Thanks,

Boris

[1]https://github.com/bbrezillon/linux/tree/nand/exec-op-conversion

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/