From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: Leonardo Bras <leobras.c@gmail.com>
Cc: git@vger.kernel.org, Jan Viktorin <viktorin@rehivetech.com>,
Michal Nazarewicz <mina86@mina86.com>
Subject: Re: [PATCH] send-email: Defines smtpPassCmd config option
Date: Fri, 1 May 2020 05:53:08 -0700 [thread overview]
Message-ID: <20200501125308.GE33264@Carlos-MBP> (raw)
In-Reply-To: <20200501105131.297457-1-leobras.c@gmail.com>
On Fri, May 01, 2020 at 07:51:31AM -0300, Leonardo Bras wrote:
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> index 0a69810147..8e9da5ed64 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -203,8 +203,9 @@ independently of `--smtp-user`
> Furthermore, passwords need not be specified in configuration files
> or on the command line. If a username has been specified (with
> `--smtp-user` or a `sendemail.smtpUser`), but no password has been
> -specified (with `--smtp-pass` or `sendemail.smtpPass`), then
> -a password is obtained using 'git-credential'.
> +specified (with `--smtp-pass` or `sendemail.smtpPass`, or as an output
> +of `sendemail.smtpPassCmd`), then a password is obtained using
> +'git-credential'.
this last part on git credential is just undocumented, since it is already
doing so since 4d31a44a08 (git-send-email: use git credential to obtain
password, 2013-02-12)
and of course, assuming you use a credential helper that keeps the password
encrypted you could use that instead of this new feature.
having said that, this looks like a good alternative, but might need to
make sure if die makes sense below or would be better to see if you can
still get a password through git credential even if that fails.
maybe the rule of what to do might even need some configuration itself.
Carlo
next prev parent reply other threads:[~2020-05-01 12:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 10:51 [PATCH] send-email: Defines smtpPassCmd config option Leonardo Bras
2020-05-01 12:53 ` Carlo Marcelo Arenas Belón [this message]
2020-05-01 15:50 ` Junio C Hamano
2020-05-01 22:27 ` Taylor Blau
2020-05-01 23:59 ` brian m. carlson
2020-05-03 9:43 ` Jeff King
2020-05-03 16:27 ` brian m. carlson
2020-05-03 23:48 ` Carlo Marcelo Arenas Belón
2020-05-04 19:49 ` Leonardo Bras
2020-05-04 20:35 ` Jeff King
2020-05-04 21:29 ` Leonardo Bras
2020-05-04 19:09 ` Leonardo Bras
2020-05-04 19:02 ` Leonardo Bras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501125308.GE33264@Carlos-MBP \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=leobras.c@gmail.com \
--cc=mina86@mina86.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.