From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 725B9C47253 for ; Fri, 1 May 2020 13:10:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B9D2208DB for ; Fri, 1 May 2020 13:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728828AbgEANKH (ORCPT ); Fri, 1 May 2020 09:10:07 -0400 Received: from verein.lst.de ([213.95.11.211]:46158 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728586AbgEANKH (ORCPT ); Fri, 1 May 2020 09:10:07 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 9444168BFE; Fri, 1 May 2020 15:10:01 +0200 (CEST) Date: Fri, 1 May 2020 15:10:01 +0200 From: "hch@lst.de" To: "Williams, Dan J" Cc: "hch@lst.de" , "david.e.box@linux.intel.com" , "linux-nvme@lists.infradead.org" , "sagi@grimberg.me" , "lenb@kernel.org" , "rjw@rjwysocki.net" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-pci@vger.kernel.org" , "axboe@fb.com" , "kbusch@kernel.org" , "bhelgaas@google.com" Subject: Re: [PATCH 0/2] Add support for StorageD3Enable _DSD property Message-ID: <20200501131001.GA6600@lst.de> References: <20200428003214.3764-1-david.e.box@linux.intel.com> <20200428051312.GB17146@lst.de> <20200428142247.GB5439@lst.de> <296064bbcf702744bf603932c9d849307db2e5b7.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <296064bbcf702744bf603932c9d849307db2e5b7.camel@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Apr 29, 2020 at 05:20:09AM +0000, Williams, Dan J wrote: > > The platform can know which pm policies will save the most power. But > > since the solution doesn't apply to all PCIe devices (despite BIOS > > specifying it that way) I'll withdraw this patch. Thanks. > > Wait, why withdraw? In this case the platform is unfortunately > preventing the standard driver from making a proper determination. So > while I agree that it's not the BIOSes job, when the platform actively > prevents proper operation due to some ill conceived non-standard > platform property what is Linux left to do on these systems? > > The *patch* is not trying to overrule NVME, and the best I can say is > that the Intel Linux team was not in the loop when this was being > decided between the platform BIOS implemenation and whomever thought > they could just publish random ACPI properties that impacted NVME > operation [1]. > > So now David is trying to get these platform unbroken because they are > already shipping with this b0rkage. So can we please clearly mark this as a quirk and warn in the kernel log about a buggy BIOS? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E5A7C4724C for ; Fri, 1 May 2020 13:10:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05DFA2166E for ; Fri, 1 May 2020 13:10:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YIGx7lRI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05DFA2166E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bWyXyJb8xskUoS28a69TzXq+SPQlQTeJzr/tdQBxQkM=; b=YIGx7lRIgwY62s UbYPS5pKq9h1uODxYmn44paockVo3u1EQIwfMEgFYwZD0tX5hhdqbEakH2VuCMQGE1wkwOerGPdOm e8q2YFtfTVLR6ni/JXK9OG9Nw43kOQBZaZCoPa7b1MIU1IAObpJRHQHq7U6HpbWpvfM6y/zVX3weO 8K7gjrq3+3C35kwmdDd4CxzKMRXRuulBIFg0Y4r9nethrG9IxQ0NW+BxQ/OF03xinVuNeIQ+Bo/Yb i+H7sSoT4mMtvVqo7pCCxEU6xGvheDGm9IHpHq8uRPPnmXbg2IhbuKQ2Dw5ZOX20kHhYpQWqou+Mz iILk1ADe9Lh9Acmhs94w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUVQf-0000Dt-Vh; Fri, 01 May 2020 13:10:09 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jUVQc-0007mz-My for linux-nvme@lists.infradead.org; Fri, 01 May 2020 13:10:08 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 9444168BFE; Fri, 1 May 2020 15:10:01 +0200 (CEST) Date: Fri, 1 May 2020 15:10:01 +0200 From: "hch@lst.de" To: "Williams, Dan J" Subject: Re: [PATCH 0/2] Add support for StorageD3Enable _DSD property Message-ID: <20200501131001.GA6600@lst.de> References: <20200428003214.3764-1-david.e.box@linux.intel.com> <20200428051312.GB17146@lst.de> <20200428142247.GB5439@lst.de> <296064bbcf702744bf603932c9d849307db2e5b7.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <296064bbcf702744bf603932c9d849307db2e5b7.camel@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200501_061006_926188_A6E8D53C X-CRM114-Status: GOOD ( 14.02 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "sagi@grimberg.me" , "linux-pci@vger.kernel.org" , "rjw@rjwysocki.net" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "axboe@fb.com" , "linux-acpi@vger.kernel.org" , "david.e.box@linux.intel.com" , "kbusch@kernel.org" , "bhelgaas@google.com" , "hch@lst.de" , "lenb@kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Apr 29, 2020 at 05:20:09AM +0000, Williams, Dan J wrote: > > The platform can know which pm policies will save the most power. But > > since the solution doesn't apply to all PCIe devices (despite BIOS > > specifying it that way) I'll withdraw this patch. Thanks. > > Wait, why withdraw? In this case the platform is unfortunately > preventing the standard driver from making a proper determination. So > while I agree that it's not the BIOSes job, when the platform actively > prevents proper operation due to some ill conceived non-standard > platform property what is Linux left to do on these systems? > > The *patch* is not trying to overrule NVME, and the best I can say is > that the Intel Linux team was not in the loop when this was being > decided between the platform BIOS implemenation and whomever thought > they could just publish random ACPI properties that impacted NVME > operation [1]. > > So now David is trying to get these platform unbroken because they are > already shipping with this b0rkage. So can we please clearly mark this as a quirk and warn in the kernel log about a buggy BIOS? _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme