From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA6EC47258 for ; Fri, 1 May 2020 13:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D69162166E for ; Fri, 1 May 2020 13:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339657; bh=9z4LahtgSkFQavSR0Kpqso99n4FDvhhsFpPIpUuuUlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ErM+R5od9837niYw0QlX6i9CNWj5OkYi5iYUQIhvwnJAfFv9+InBb2JAMvg9sRGQk AS9Z++LXKrTnU0vMwl8MoG5WF0zU3Qung6kqVWkrcq5ijlol+YSR328eDxR/7gJAZD NL182bKbuAYFaUFLkKcYKv5Qssr+knM4aZDUhDWY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729495AbgEAN1h (ORCPT ); Fri, 1 May 2020 09:27:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:49924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729486AbgEAN1e (ORCPT ); Fri, 1 May 2020 09:27:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FE0420757; Fri, 1 May 2020 13:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339652; bh=9z4LahtgSkFQavSR0Kpqso99n4FDvhhsFpPIpUuuUlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GyCimMYF5dGfvlGAUSPvlLmgp6nwHDrDLY/cSK/zXkdMBFjLXv/mjxHBe4qli9Gs5 Tzov2ZKpggBb3FCYdvjS6aUEV732kbO5fyg2AISnyXYA1CioVElH/kijnWYrLCIb2h UV3W4UsvJl2zAK2MLRB17P1e7jEMCM/dAwTBxN4A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Clement Leger , Bjorn Andersson , Doug Anderson Subject: [PATCH 4.4 54/70] remoteproc: Fix wrong rvring index computation Date: Fri, 1 May 2020 15:21:42 +0200 Message-Id: <20200501131529.831555248@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131513.302599262@linuxfoundation.org> References: <20200501131513.302599262@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Clement Leger commit 00a0eec59ddbb1ce966b19097d8a8d2f777e726a upstream. Index of rvring is computed using pointer arithmetic. However, since rvring->rvdev->vring is the base of the vring array, computation of rvring idx should be reversed. It previously lead to writing at negative indices in the resource table. Signed-off-by: Clement Leger Link: https://lore.kernel.org/r/20191004073736.8327-1-cleger@kalray.eu Signed-off-by: Bjorn Andersson Cc: Doug Anderson Signed-off-by: Greg Kroah-Hartman --- drivers/remoteproc/remoteproc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -288,7 +288,7 @@ void rproc_free_vring(struct rproc_vring { int size = PAGE_ALIGN(vring_size(rvring->len, rvring->align)); struct rproc *rproc = rvring->rvdev->rproc; - int idx = rvring->rvdev->vring - rvring; + int idx = rvring - rvring->rvdev->vring; struct fw_rsc_vdev *rsc; dma_free_coherent(rproc->dev.parent, size, rvring->va, rvring->dma);