All of lore.kernel.org
 help / color / mirror / Atom feed
From: sbabic at denx.de <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 2/3] imx: imx8m*: Remove do_reset from board files
Date: Fri,  1 May 2020 18:33:03 +0200 (CEST)	[thread overview]
Message-ID: <20200501163303.6AB8881DC0@phobos.denx.de> (raw)
In-Reply-To: <25277ba3658920ff3be7464020438070844f05da.1583328917.git.hws@denx.de>

> From: Claudius Heine <ch@denx.de>
> Use the `do_reset` implementation of `arch/arm/lib/reset.c` in SPL
> instead.  It is very close to what is done here, anyway, and plays
> more nicely with the rest of U-Boot than adding a custom `do_reset`
> implementation into board files.
> `do_reset` from `arch/arm/lib/reset.c` calls `reset_cpu` with 0 as the
> addr parameter while the boards are passing WDOG1_BASE_ADDR.  This is
> ok because the `reset_cpu` implementation uses WDOG1_BASE_ADDR by
> default if 0 is passed in.
> Co-Authored-by: Harald Seiler <hws@denx.de>
> Signed-off-by: Claudius Heine <ch@denx.de>
> Signed-off-by: Harald Seiler <hws@denx.de>
> Reviewed-by: Marek Vasut <marex@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  parent reply	other threads:[~2020-05-01 16:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 14:23 [PATCH 0/3] ARM: Fix reset in SPL if SYSRESET is not used Harald Seiler
2020-03-04 14:23 ` [PATCH 1/3] ARM: reset: use do_reset in SPL/TPL if SYSRESET was not enabled for them Harald Seiler
2020-03-04 14:26   ` Marek Vasut
2020-05-01 16:31   ` sbabic at denx.de
2020-03-04 14:23 ` [PATCH 2/3] imx: imx8m*: Remove do_reset from board files Harald Seiler
2020-03-04 14:29   ` Marek Vasut
2020-05-01 16:33   ` sbabic at denx.de [this message]
2020-03-04 14:23 ` [PATCH 3/3] imx: imx8m: Don't use the addr parameter of reset_cpu Harald Seiler
2020-03-04 14:30   ` Marek Vasut
2020-03-04 14:35     ` Harald Seiler
2020-05-01 16:32   ` sbabic at denx.de
2020-04-23 11:18 ` [PATCH 0/3] ARM: Fix reset in SPL if SYSRESET is not used Harald Seiler
2020-04-23 11:23   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200501163303.6AB8881DC0@phobos.denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.