Re: [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary CPPFLAGS and LDFLAGS adjustments

["Denys Dmytriyenko" <denis@denix.org>]

On Fri, May 01, 2020 at 10:03:15AM -0400, Jon Mason wrote:
> On Fri, May 01, 2020 at 06:46:08AM +0000, Diego Sueiro wrote:
> > > -----Original Message-----
> > > From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> > > On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
> > > Sent: 30 April 2020 05:10
> > > To: meta-arm@lists.yoctoproject.org
> > > Cc: Denys Dmytriyenko <denys@ti.com>
> > > Subject: [meta-arm] [PATCH 1/4] tcmode-external-arm: drop unnecessary
> > > CPPFLAGS and LDFLAGS adjustments
> > > 
> > > From: Denys Dmytriyenko <denys@ti.com>
> > > 
> > > These were there from the very beginning and they were used as crutches to
> > > prop up the build by pointing directly to the external toolchain location, in
> > > case early versions of external-arm-toolchain missed staging/packaging
> > > something from there.
> > > 
> > > First of all, it is unnecessary to adjust CPPFLAGS and LDFLAGS in this way, as
> > > external-arm-toolchain is supposed to stage everything needed from the
> > > toolchain in internal sysroot.
> > > 
> > > And second, these settings can be harmful and conflict with component's
> > > own CPPFLAGS/LDFLAGS. For example, OpenCV 4.1 fails to link internal
> > > libraries because of incorrect -Wl,-rpath-link passed down the build.
> > > 
> > > After dropping these, I was able to verify that everything still builds, including
> > > BSP, Wayland/Weston, Qt5, gstreamer, OpenCV, etc for Aarch64 and Armv7a
> > > platforms.
> > > 
> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > 
> > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> 
> Series (except the patch you said to ignore) pulled into the master branch.

Thanks, Jon!

I don't see them in master, though:
http://git.yoctoproject.org/cgit/cgit.cgi/meta-arm/

Denys


> > > ---
> > >  meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > > b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > > index 8ddaf53..9171380 100644
> > > --- a/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > > +++ b/meta-arm-toolchain/conf/distro/include/tcmode-external-arm.inc
> > > @@ -44,8 +44,6 @@ PREFERRED_PROVIDER_glibc-thread-db = "external-
> > > arm-toolchain"
> > >  PREFERRED_PROVIDER_glibc-mtrace = "external-arm-toolchain"
> > >  PREFERRED_PROVIDER_libc-mtrace = "external-arm-toolchain"
> > >  PREFERRED_PROVIDER_virtual/linux-libc-headers = "external-arm-toolchain"
> > > -TARGET_CPPFLAGS_prepend = " -
> > > isystem${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/include "
> > > -TARGET_LDFLAGS_prepend = " -
> > > L${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib -Wl,-rpath-
> > > link,${EXTERNAL_TOOLCHAIN}/${EAT_TARGET_SYS}/lib "
> > > 
> > >  TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_HOST}"
> > > 
> > > --
> > > 2.7.4
> > 
> 
> > 
> 

>