From: Danh Doan <congdanhqx@gmail.com>
To: Jeff King <peff@peff.net>
Cc: clime <clime7@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys
Date: Sun, 3 May 2020 18:44:02 +0700 [thread overview]
Message-ID: <20200503114351.GA28680@danh.dev> (raw)
In-Reply-To: <20200503091157.GA170902@coredump.intra.peff.net>
On 2020-05-03 05:11:57-0400, Jeff King <peff@peff.net> wrote:
> +test_expect_success 'for-each-ref --ignore-case works on multiple sort keys' '
> + # name refs numerically to avoid case-insensitive filesystem conflicts
> + nr=0 &&
> + for email in a A b B
> + do
> + for subject in a A b B
> + do
> + GIT_COMMITTER_EMAIL="$email@example.com" \
> + git tag -m "tag $subject" icase-$(printf %02d $nr) &&
> + nr=$((nr+1))||
The CodingGuidelines said we want to spell `$nr` instead of `nr`
inside arithmetic expansion for dash older than 0.5.4
I'm not sure if we should go with just `$((nr+1))` or it's better to
loosen our Guidelines. Since Debian Jessie (oldest supported Debian)
ships 0.5.7. I don't know about other systems.
--
Danh
next prev parent reply other threads:[~2020-05-03 11:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 20:31 git for-each-ref - sorting by multiple keys clime
2020-05-03 9:09 ` Jeff King
2020-05-03 9:11 ` [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys Jeff King
2020-05-03 11:44 ` Danh Doan [this message]
2020-05-04 15:13 ` Jeff King
2020-05-04 15:37 ` Junio C Hamano
2020-05-04 16:07 ` [PATCH] CodingGuidelines: drop arithmetic expansion advice to use "$x" Jeff King
2020-05-04 16:28 ` Carlo Marcelo Arenas Belón
2020-05-04 16:33 ` Jeff King
2020-05-04 19:47 ` Junio C Hamano
2020-05-04 23:32 ` Danh Doan
2020-05-05 20:40 ` Junio C Hamano
2020-05-05 21:07 ` Jeff King
2020-05-05 21:30 ` Junio C Hamano
2020-05-04 21:00 ` [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys Junio C Hamano
2020-05-05 0:11 ` Jeff King
2020-05-05 0:13 ` Taylor Blau
2020-05-03 9:13 ` [PATCH 2/2] ref-filter: apply fallback refname sort only after all user sorts Jeff King
2020-05-04 21:05 ` Junio C Hamano
2020-05-05 0:14 ` Taylor Blau
2020-05-03 10:16 ` git for-each-ref - sorting by multiple keys clime
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200503114351.GA28680@danh.dev \
--to=congdanhqx@gmail.com \
--cc=clime7@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.