From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6611C28CBC for ; Mon, 4 May 2020 01:35:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9614F206E6 for ; Mon, 4 May 2020 01:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726906AbgEDBfY (ORCPT ); Sun, 3 May 2020 21:35:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726377AbgEDBfY (ORCPT ); Sun, 3 May 2020 21:35:24 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D83FBC061A0E; Sun, 3 May 2020 18:35:23 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVQ0j-000SR4-3a; Mon, 04 May 2020 01:35:09 +0000 Date: Mon, 4 May 2020 02:35:09 +0100 From: Al Viro To: ira.weiny@intel.com Cc: linux-kernel@vger.kernel.org, Andrew Morton , Christian Koenig , Huang Rui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Chris Zankel , Max Filippov , Dan Williams , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code Message-ID: <20200504013509.GU23230@ZenIV.linux.org.uk> References: <20200504010912.982044-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200504010912.982044-1-ira.weiny@intel.com> Sender: linux-csky-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Sun, May 03, 2020 at 06:09:01PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kmap infrastructure has been copied almost verbatim to every architecture. > This series consolidates obvious duplicated code by defining core functions > which call into the architectures only when needed. > > Some of the k[un]map_atomic() implementations have some similarities but the > similarities were not sufficient to warrant further changes. > > In addition we remove a duplicate implementation of kmap() in DRM. > > Testing was done by 0day to cover all the architectures I can't readily > build/test. OK... Looking through my old notes on kmap unification (this winter, never went anywhere), * arch/mips/mm/cache.c ought to use linux/highmem.h, not asm/highmem.h I suspect that your series doesn't build on some configs there. Hadn't verified that, though. * kmap_atomic_to_page() is dead, but not quite gone - csky and nds32 brought the damn thing back (nds32 - only an extern). It needs killin'... * parisc is (arguably) abusing kunmap()/kunmap_atomic() for cache flushing. Replace the bulk of its highmem.h with #define ARCH_HAS_FLUSH_ON_KUNMAP #define arch_before_kunmap flush_kernel_dcache_page_addr and have default kunmap()/kunmap_atomic() do #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(page_address(page)); #endif and #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(addr); #endif resp. Kills ARCH_HAS_KMAP along with ifdefs on it, makes parisc use somewhat less hacky. I'd suggest checking various configs on mips - that's likely to cause headache. Said that, my analysis of include chains back then is pretty much worthless by now - I really hate the amount of indirect include chains leading to that sucker on some, but not all configs ;-/ IIRC, the proof that everything using kmap*/kunmap* would pull linux/highmem.h regardless of config took several hours of digging, ran for several pages and had been hopelessly brittle. arch/mips/mm/cache.c was the only exception caught by it, but these days there might be more. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA9C8C28CBC for ; Mon, 4 May 2020 01:35:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DE9E206E6 for ; Mon, 4 May 2020 01:35:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d6lCaSXJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DE9E206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KbAeiWR/aIJHqN1IUBm/at7SuzYwUOWJcvFG4S7mYes=; b=d6lCaSXJgVJxCw ZllmjXl7tZe2jZbfbRR916t3xZ0j3dyYiANFeNyxWCHWWtB+13y7Nb0ofb/cJAkf3zamw4tCq9KLJ UwhqV4XGWE0fD8lfFFOHR97DPWbzbilp/GvjV3BCsLHw+NLEu8UhXAmjM5HgPgJ7h2Xuei1iaWjK3 wk//6KuAOZdkNHlDolYmlKmvEHpvdG2O+DU5S2rN+qJYKOBdeLr7yhfcLzR8oaJlpYzOaECRUflr/ RG947hhlS/1BrkIXhwY3V7B/f5dvcyjqHRyRmFd4Ua+NiaPK1ir+kHqljLuR5d+w3TfyTYYvl18Vs 1eVrBAAUnscsI1AsglFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVQ1V-0000mr-G1; Mon, 04 May 2020 01:35:57 +0000 Received: from [2002:c35c:fd02::1] (helo=ZenIV.linux.org.uk) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVQ1R-0000lr-Ix; Mon, 04 May 2020 01:35:56 +0000 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVQ0j-000SR4-3a; Mon, 04 May 2020 01:35:09 +0000 Date: Mon, 4 May 2020 02:35:09 +0100 From: Al Viro To: ira.weiny@intel.com Subject: Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code Message-ID: <20200504013509.GU23230@ZenIV.linux.org.uk> References: <20200504010912.982044-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200504010912.982044-1-ira.weiny@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200503_183553_622329_4D363A26 X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Huang Rui , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org On Sun, May 03, 2020 at 06:09:01PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kmap infrastructure has been copied almost verbatim to every architecture. > This series consolidates obvious duplicated code by defining core functions > which call into the architectures only when needed. > > Some of the k[un]map_atomic() implementations have some similarities but the > similarities were not sufficient to warrant further changes. > > In addition we remove a duplicate implementation of kmap() in DRM. > > Testing was done by 0day to cover all the architectures I can't readily > build/test. OK... Looking through my old notes on kmap unification (this winter, never went anywhere), * arch/mips/mm/cache.c ought to use linux/highmem.h, not asm/highmem.h I suspect that your series doesn't build on some configs there. Hadn't verified that, though. * kmap_atomic_to_page() is dead, but not quite gone - csky and nds32 brought the damn thing back (nds32 - only an extern). It needs killin'... * parisc is (arguably) abusing kunmap()/kunmap_atomic() for cache flushing. Replace the bulk of its highmem.h with #define ARCH_HAS_FLUSH_ON_KUNMAP #define arch_before_kunmap flush_kernel_dcache_page_addr and have default kunmap()/kunmap_atomic() do #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(page_address(page)); #endif and #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(addr); #endif resp. Kills ARCH_HAS_KMAP along with ifdefs on it, makes parisc use somewhat less hacky. I'd suggest checking various configs on mips - that's likely to cause headache. Said that, my analysis of include chains back then is pretty much worthless by now - I really hate the amount of indirect include chains leading to that sucker on some, but not all configs ;-/ IIRC, the proof that everything using kmap*/kunmap* would pull linux/highmem.h regardless of config took several hours of digging, ran for several pages and had been hopelessly brittle. arch/mips/mm/cache.c was the only exception caught by it, but these days there might be more. _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A452CC28CBC for ; Mon, 4 May 2020 01:37:51 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55FD0206E6 for ; Mon, 4 May 2020 01:37:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55FD0206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49Flq118NGzDqdl for ; Mon, 4 May 2020 11:37:49 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=ftp.linux.org.uk (client-ip=2002:c35c:fd02::1; helo=zeniv.linux.org.uk; envelope-from=viro@ftp.linux.org.uk; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49Flmw42gKzDqc6 for ; Mon, 4 May 2020 11:36:00 +1000 (AEST) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVQ0j-000SR4-3a; Mon, 04 May 2020 01:35:09 +0000 Date: Mon, 4 May 2020 02:35:09 +0100 From: Al Viro To: ira.weiny@intel.com Subject: Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code Message-ID: <20200504013509.GU23230@ZenIV.linux.org.uk> References: <20200504010912.982044-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200504010912.982044-1-ira.weiny@intel.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Huang Rui , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, May 03, 2020 at 06:09:01PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kmap infrastructure has been copied almost verbatim to every architecture. > This series consolidates obvious duplicated code by defining core functions > which call into the architectures only when needed. > > Some of the k[un]map_atomic() implementations have some similarities but the > similarities were not sufficient to warrant further changes. > > In addition we remove a duplicate implementation of kmap() in DRM. > > Testing was done by 0day to cover all the architectures I can't readily > build/test. OK... Looking through my old notes on kmap unification (this winter, never went anywhere), * arch/mips/mm/cache.c ought to use linux/highmem.h, not asm/highmem.h I suspect that your series doesn't build on some configs there. Hadn't verified that, though. * kmap_atomic_to_page() is dead, but not quite gone - csky and nds32 brought the damn thing back (nds32 - only an extern). It needs killin'... * parisc is (arguably) abusing kunmap()/kunmap_atomic() for cache flushing. Replace the bulk of its highmem.h with #define ARCH_HAS_FLUSH_ON_KUNMAP #define arch_before_kunmap flush_kernel_dcache_page_addr and have default kunmap()/kunmap_atomic() do #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(page_address(page)); #endif and #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(addr); #endif resp. Kills ARCH_HAS_KMAP along with ifdefs on it, makes parisc use somewhat less hacky. I'd suggest checking various configs on mips - that's likely to cause headache. Said that, my analysis of include chains back then is pretty much worthless by now - I really hate the amount of indirect include chains leading to that sucker on some, but not all configs ;-/ IIRC, the proof that everything using kmap*/kunmap* would pull linux/highmem.h regardless of config took several hours of digging, ran for several pages and had been hopelessly brittle. arch/mips/mm/cache.c was the only exception caught by it, but these days there might be more. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Mon, 04 May 2020 01:35:09 +0000 Subject: Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code Message-Id: <20200504013509.GU23230@ZenIV.linux.org.uk> List-Id: References: <20200504010912.982044-1-ira.weiny@intel.com> In-Reply-To: <20200504010912.982044-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ira.weiny@intel.com Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Huang Rui , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Sun, May 03, 2020 at 06:09:01PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kmap infrastructure has been copied almost verbatim to every architecture. > This series consolidates obvious duplicated code by defining core functions > which call into the architectures only when needed. > > Some of the k[un]map_atomic() implementations have some similarities but the > similarities were not sufficient to warrant further changes. > > In addition we remove a duplicate implementation of kmap() in DRM. > > Testing was done by 0day to cover all the architectures I can't readily > build/test. OK... Looking through my old notes on kmap unification (this winter, never went anywhere), * arch/mips/mm/cache.c ought to use linux/highmem.h, not asm/highmem.h I suspect that your series doesn't build on some configs there. Hadn't verified that, though. * kmap_atomic_to_page() is dead, but not quite gone - csky and nds32 brought the damn thing back (nds32 - only an extern). It needs killin'... * parisc is (arguably) abusing kunmap()/kunmap_atomic() for cache flushing. Replace the bulk of its highmem.h with #define ARCH_HAS_FLUSH_ON_KUNMAP #define arch_before_kunmap flush_kernel_dcache_page_addr and have default kunmap()/kunmap_atomic() do #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(page_address(page)); #endif and #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(addr); #endif resp. Kills ARCH_HAS_KMAP along with ifdefs on it, makes parisc use somewhat less hacky. I'd suggest checking various configs on mips - that's likely to cause headache. Said that, my analysis of include chains back then is pretty much worthless by now - I really hate the amount of indirect include chains leading to that sucker on some, but not all configs ;-/ IIRC, the proof that everything using kmap*/kunmap* would pull linux/highmem.h regardless of config took several hours of digging, ran for several pages and had been hopelessly brittle. arch/mips/mm/cache.c was the only exception caught by it, but these days there might be more. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1410CC47257 for ; Mon, 4 May 2020 01:36:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E005C206E6 for ; Mon, 4 May 2020 01:35:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fgzebOea" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E005C206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/5KhjaaQp8DguZx9jqtFnLFxKsswhAUETAIkJOUN7nY=; b=fgzebOeaIczMea HdznTicT82D/N270be0pBmo3+Kua8MJYjilaM8jkUvo5PIlb5j31uxI1/xcM6XAxIUdQNgd+C4X7L cgwAMNPc7enfKcwptGXnYCXaBGPfdPmt98ZGC6rJZJqth8giLQrnYQGS4Tupsvh9V4BsjAHCv306B bRoK/OLAR0sxfxMlbu7zPPzG3buZy6b91aleFl+YuTpw1iPIMlfEqExvTQ/jvzFfxxa0OgIV6Z5MS yAjLgyuRmoZwqCtSvwYHrNm1Ieyevw6q7C0pBvx78qMaj5MGXSIthL24Ag8s5qPWrV7xvbCZP83Cg 0bgr1fAh+nZY5qdwoq5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVQ1W-0000n6-5R; Mon, 04 May 2020 01:35:58 +0000 Received: from [2002:c35c:fd02::1] (helo=ZenIV.linux.org.uk) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVQ1R-0000lr-Ix; Mon, 04 May 2020 01:35:56 +0000 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVQ0j-000SR4-3a; Mon, 04 May 2020 01:35:09 +0000 Date: Mon, 4 May 2020 02:35:09 +0100 From: Al Viro To: ira.weiny@intel.com Subject: Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code Message-ID: <20200504013509.GU23230@ZenIV.linux.org.uk> References: <20200504010912.982044-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200504010912.982044-1-ira.weiny@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200503_183553_622329_4D363A26 X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Huang Rui , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, May 03, 2020 at 06:09:01PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kmap infrastructure has been copied almost verbatim to every architecture. > This series consolidates obvious duplicated code by defining core functions > which call into the architectures only when needed. > > Some of the k[un]map_atomic() implementations have some similarities but the > similarities were not sufficient to warrant further changes. > > In addition we remove a duplicate implementation of kmap() in DRM. > > Testing was done by 0day to cover all the architectures I can't readily > build/test. OK... Looking through my old notes on kmap unification (this winter, never went anywhere), * arch/mips/mm/cache.c ought to use linux/highmem.h, not asm/highmem.h I suspect that your series doesn't build on some configs there. Hadn't verified that, though. * kmap_atomic_to_page() is dead, but not quite gone - csky and nds32 brought the damn thing back (nds32 - only an extern). It needs killin'... * parisc is (arguably) abusing kunmap()/kunmap_atomic() for cache flushing. Replace the bulk of its highmem.h with #define ARCH_HAS_FLUSH_ON_KUNMAP #define arch_before_kunmap flush_kernel_dcache_page_addr and have default kunmap()/kunmap_atomic() do #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(page_address(page)); #endif and #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(addr); #endif resp. Kills ARCH_HAS_KMAP along with ifdefs on it, makes parisc use somewhat less hacky. I'd suggest checking various configs on mips - that's likely to cause headache. Said that, my analysis of include chains back then is pretty much worthless by now - I really hate the amount of indirect include chains leading to that sucker on some, but not all configs ;-/ IIRC, the proof that everything using kmap*/kunmap* would pull linux/highmem.h regardless of config took several hours of digging, ran for several pages and had been hopelessly brittle. arch/mips/mm/cache.c was the only exception caught by it, but these days there might be more. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F17C47259 for ; Mon, 4 May 2020 07:17:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43A3720721 for ; Mon, 4 May 2020 07:17:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43A3720721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DFF736E33C; Mon, 4 May 2020 07:17:21 +0000 (UTC) Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 938CA89F71 for ; Mon, 4 May 2020 01:35:59 +0000 (UTC) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVQ0j-000SR4-3a; Mon, 04 May 2020 01:35:09 +0000 Date: Mon, 4 May 2020 02:35:09 +0100 From: Al Viro To: ira.weiny@intel.com Subject: Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code Message-ID: <20200504013509.GU23230@ZenIV.linux.org.uk> References: <20200504010912.982044-1-ira.weiny@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200504010912.982044-1-ira.weiny@intel.com> X-Mailman-Approved-At: Mon, 04 May 2020 07:17:19 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, "James E.J. Bottomley" , Max Filippov , Huang Rui , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Dan Williams , Helge Deller , x86@kernel.org, linux-csky@vger.kernel.org, Ingo Molnar , linux-snps-arc@lists.infradead.org, linux-xtensa@linux-xtensa.org, Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Chris Zankel , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Koenig , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, May 03, 2020 at 06:09:01PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The kmap infrastructure has been copied almost verbatim to every architecture. > This series consolidates obvious duplicated code by defining core functions > which call into the architectures only when needed. > > Some of the k[un]map_atomic() implementations have some similarities but the > similarities were not sufficient to warrant further changes. > > In addition we remove a duplicate implementation of kmap() in DRM. > > Testing was done by 0day to cover all the architectures I can't readily > build/test. OK... Looking through my old notes on kmap unification (this winter, never went anywhere), * arch/mips/mm/cache.c ought to use linux/highmem.h, not asm/highmem.h I suspect that your series doesn't build on some configs there. Hadn't verified that, though. * kmap_atomic_to_page() is dead, but not quite gone - csky and nds32 brought the damn thing back (nds32 - only an extern). It needs killin'... * parisc is (arguably) abusing kunmap()/kunmap_atomic() for cache flushing. Replace the bulk of its highmem.h with #define ARCH_HAS_FLUSH_ON_KUNMAP #define arch_before_kunmap flush_kernel_dcache_page_addr and have default kunmap()/kunmap_atomic() do #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(page_address(page)); #endif and #ifdef ARCH_HAS_FLUSH_ON_KUNMAP arch_before_kunmap(addr); #endif resp. Kills ARCH_HAS_KMAP along with ifdefs on it, makes parisc use somewhat less hacky. I'd suggest checking various configs on mips - that's likely to cause headache. Said that, my analysis of include chains back then is pretty much worthless by now - I really hate the amount of indirect include chains leading to that sucker on some, but not all configs ;-/ IIRC, the proof that everything using kmap*/kunmap* would pull linux/highmem.h regardless of config took several hours of digging, ran for several pages and had been hopelessly brittle. arch/mips/mm/cache.c was the only exception caught by it, but these days there might be more. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel