From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8E4C3A5A9 for ; Mon, 4 May 2020 09:34:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B40A3206D9 for ; Mon, 4 May 2020 09:34:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iv9AiXgW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B40A3206D9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVXUC-0001cf-Rt for qemu-devel@archiver.kernel.org; Mon, 04 May 2020 05:34:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVXTK-0001Ap-4h for qemu-devel@nongnu.org; Mon, 04 May 2020 05:33:10 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:26348 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jVXTI-0002hK-Q8 for qemu-devel@nongnu.org; Mon, 04 May 2020 05:33:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588584787; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G1hbQsc66mjmhIM3trK0GP+ZdLwFsOugD84qTDlbGT8=; b=iv9AiXgWShzm7eaNpRMGa3MAePOHqsBrBEnzpIPO3vCT1UXGuXOWu9GxvEC8BtWYCdP7xO w87IQa1FyVT6UXvoIYEtSAq1zREy10Nne5nIbxRDlSsSRdwU+Zap4LHI4esh0rx0pU3Mqr b9d0fZFZLKMRC3rD4wDOCaRig4GE9Pg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-Jbw370KAOlO8nXpv1ueAoQ-1; Mon, 04 May 2020 05:33:02 -0400 X-MC-Unique: Jbw370KAOlO8nXpv1ueAoQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5FD7A19200C1 for ; Mon, 4 May 2020 09:33:01 +0000 (UTC) Received: from redhat.com (unknown [10.36.110.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D850B60300; Mon, 4 May 2020 09:32:59 +0000 (UTC) Date: Mon, 4 May 2020 10:32:56 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Subject: Re: [PATCH 02/17] qom: Clean up inconsistent use of gchar * vs. char * Message-ID: <20200504093256.GE115875@redhat.com> References: <20200428163419.4483-1-armbru@redhat.com> <20200428163419.4483-3-armbru@redhat.com> <79e0bb4c-d524-994d-865e-3422702f44db@redhat.com> <87y2qb6i3l.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87y2qb6i3l.fsf@dusky.pond.sub.org> User-Agent: Mutt/1.13.4 (2020-02-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.120; envelope-from=berrange@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 05:09:11 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_EXCESS_BASE64=0.979, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, May 02, 2020 at 07:06:38AM +0200, Markus Armbruster wrote: > Eric Blake writes: >=20 > > On 4/28/20 11:34 AM, Markus Armbruster wrote: > >> Uses of gchar * in qom/object.h: > >> > > > > Nice audit. I don't know if we can blindly assume that 'gchar' is a > > (stupid) typedef to 'char', or if they can ever differ, but avoiding > > gchar where possible always makes sense to me. >=20 > GLib's "basic types" are one of the most misguided aspects of its > interface. There is work to re-define them in terms of stdint.h https://gitlab.gnome.org/GNOME/glib/issues/1484 with long term possible plan to deprecate them > Quote https://developer.gnome.org/glib/stable/glib-Basic-Types.html >=20 > GLib defines a number of commonly used types, which can be divided > into several groups: >=20 > New types which are not part of standard C (but are defined in > various C standard library header files) =E2=80=94 gboolean, gssi= ze. >=20 > Stuck in the 90s. snip > Purge with fire. Note gboolean is a trap door. Any code integrating with GLib APIs that use "gboolean" in their signature must keep using that. It is *NOT* interchangable with the "bool" from stdbool.h. "gboolean" is a typedef for "gint" "bool" is a "_Bool" which is just a single byte. Also note TRUE and true are not the same value. 'TRUE' is bitwise !FALSE 'true' is 1 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|