From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5D75C3A5A9 for ; Mon, 4 May 2020 08:44:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82B1824957 for ; Mon, 4 May 2020 08:44:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aDeth1uc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82B1824957 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PmgpBm+kQn2Tw4YmpQoknz8FrI72hbCTQN9Zi/KMvRM=; b=aDeth1uc1zF7VN bzrJSkHsuRlO5V6joxPuyylGhoPRD02iiwR2V4iSvdyC+4kFZaXshpeP/Tg+A5Rq/a+UO1BOgHNer GRMZBWFwNm5tmjLiGsF8MWxV9ffPtaVZHPRK3WdyUPkJleLIJWrQ/jdlg2zfx5d4LH5HzhR1FqABu vDCk5wxhMlXlHzUMIwu5mlrNg5cBmGpcUP/maeGUwxTTSgqpRnaCDT34GG5fLRqfwKQnyRgyDUegX zrVmI5VF6G8KBhiZQIGnHzkz1qPcgOarIQcswJNR/7CIaGxN3DHOjeQD/eIcTbiL67ycqXrVH4FIi qjC9JNDnkEu9kuOIMTKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVWhr-0000Vd-1V; Mon, 04 May 2020 08:44:07 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jVWhn-0000Th-Q9 for linux-mtd@lists.infradead.org; Mon, 04 May 2020 08:44:05 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 8DCEF240014; Mon, 4 May 2020 08:43:40 +0000 (UTC) Date: Mon, 4 May 2020 10:43:39 +0200 From: Miquel Raynal To: Ricardo Ribalda Delgado Subject: Re: [PATCH] mtd: Fix mtd not registered due to nvmem name collision Message-ID: <20200504104339.31b4a858@xps13> In-Reply-To: <20200430131721.360064-1-ricardo@ribalda.com> References: <20200430131721.360064-1-ricardo@ribalda.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200504_014403_979094_0214D250 X-CRM114-Status: GOOD ( 17.36 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ricardo Ribalda Delgado , Vignesh Raghavendra , Richard Weinberger , linux-kernel@vger.kernel.org, Boris Brezillon , Alban Bedel , linux-mtd@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgUmljaGFyZCwKClJpY2FyZG8gUmliYWxkYSBEZWxnYWRvIDxyaWNhcmRvQHJpYmFsZGEuY29t PiB3cm90ZSBvbiBUaHUsIDMwIEFwciAyMDIwCjE1OjE3OjIxICswMjAwOgoKPiBGcm9tOiBSaWNh cmRvIFJpYmFsZGEgRGVsZ2FkbyA8cmliYWxkYUBrZXJuZWwub3JnPgo+IAo+IFdoZW4gdGhlIG52 bWVtIGZyYW1ld29yayBpcyBlbmFibGVkLCBhIG52bWVtIGRldmljZSBpcyBjcmVhdGVkIHBlciBt dGQKPiBkZXZpY2UvcGFydGl0aW9uLgo+IAo+IEl0IGlzIG5vdCB1bmNvbW1vbiB0aGF0IGEgZGV2 aWNlIGNhbiBoYXZlIG11bHRpcGxlIG10ZCBkZXZpY2VzIHdpdGgKPiBwYXJ0aXRpb25zIHRoYXQg aGF2ZSB0aGUgc2FtZSBuYW1lLiBFZywgd2hlbiB0aGVyZSBEVCBvdmVybGF5IGlzIGFsbG93ZWQK PiBhbmQgdGhlIHNhbWUgZGV2aWNlIHdpdGggbXRkIGlzIGF0dGFjaGVkIHR3aWNlLgo+IAo+IFVu ZGVyIHRoYXQgY2lyY3Vtc3RhbmNlcywgdGhlIG10ZCBmYWlscyB0byByZWdpc3RlciBkdWUgdG8g YSBuYW1lCj4gZHVwbGljYXRpb24gb24gdGhlIG52bWVtIGZyYW1ld29yay4KPiAKPiBXaXRoIHRo aXMgcGF0Y2ggd2UgdXNlIHRoZSBtdGRYIG5hbWUgaW5zdGVhZCBvZiB0aGUgcGFydGl0aW9uIG5h bWUsCj4gd2hpY2ggaXMgdW5pcXVlLgo+IAo+IFsgICAgOC45NDg5OTFdIHN5c2ZzOiBjYW5ub3Qg Y3JlYXRlIGR1cGxpY2F0ZSBmaWxlbmFtZSAnL2J1cy9udm1lbS9kZXZpY2VzL1Byb2R1Y3Rpb24g RGF0YScKPiBbICAgIDguOTQ4OTkyXSBDUFU6IDcgUElEOiAyNDYgQ29tbTogc3lzdGVtZC11ZGV2 ZCBOb3QgdGFpbnRlZCA1LjUuMC1xdGVjLXN0YW5kYXJkICMxMwo+IFsgICAgOC45NDg5OTNdIEhh cmR3YXJlIG5hbWU6IEFNRCBEaWJibGVyL0RpYmJsZXIsIEJJT1MgMDUuMjIuMDQuMDAxOSAxMC8y Ni8yMDE5Cj4gWyAgICA4Ljk0ODk5NF0gQ2FsbCBUcmFjZToKPiBbICAgIDguOTQ4OTk2XSAgZHVt cF9zdGFjaysweDUwLzB4NzAKPiBbICAgIDguOTQ4OTk4XSAgc3lzZnNfd2Fybl9kdXAuY29sZCsw eDE3LzB4MmQKPiBbICAgIDguOTQ5MDAwXSAgc3lzZnNfZG9fY3JlYXRlX2xpbmtfc2QuaXNyYS4w KzB4YzIvMHhkMAo+IFsgICAgOC45NDkwMDJdICBidXNfYWRkX2RldmljZSsweDc0LzB4MTQwCj4g WyAgICA4Ljk0OTAwNF0gIGRldmljZV9hZGQrMHgzNGIvMHg4NTAKPiBbICAgIDguOTQ5MDA2XSAg bnZtZW1fcmVnaXN0ZXIucGFydC4wKzB4MWJmLzB4NjQwCj4gLi4uCj4gWyAgICA4Ljk0ODkyNl0g bXRkIG10ZDg6IEZhaWxlZCB0byByZWdpc3RlciBOVk1FTSBkZXZpY2UKPiAKPiBGaXhlczogYzRk ZmEyNWFiMzA3ICgibXRkOiBhZGQgc3VwcG9ydCBmb3IgcmVhZGluZyBNVEQgZGV2aWNlcyB2aWEg dGhlIG52bWVtIEFQSSIpCj4gU2lnbmVkLW9mZi1ieTogUmljYXJkbyBSaWJhbGRhIERlbGdhZG8g PHJpYmFsZGFAa2VybmVsLm9yZz4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbXRkY29yZS5jIHwgMiAr LQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbXRkY29yZS5jIGIvZHJpdmVycy9tdGQvbXRkY29yZS5j Cj4gaW5kZXggMjkxNjY3NDIwOGIzLi4yOWQ0MTAwM2Q2ZTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9tdGQvbXRkY29yZS5jCj4gKysrIGIvZHJpdmVycy9tdGQvbXRkY29yZS5jCj4gQEAgLTU1NSw3 ICs1NTUsNyBAQCBzdGF0aWMgaW50IG10ZF9udm1lbV9hZGQoc3RydWN0IG10ZF9pbmZvICptdGQp Cj4gIAo+ICAJY29uZmlnLmlkID0gLTE7Cj4gIAljb25maWcuZGV2ID0gJm10ZC0+ZGV2Owo+IC0J Y29uZmlnLm5hbWUgPSBtdGQtPm5hbWU7Cj4gKwljb25maWcubmFtZSA9IGRldl9uYW1lKCZtdGQt PmRldik7Cj4gIAljb25maWcub3duZXIgPSBUSElTX01PRFVMRTsKPiAgCWNvbmZpZy5yZWdfcmVh ZCA9IG10ZF9udm1lbV9yZWdfcmVhZDsKPiAgCWNvbmZpZy5zaXplID0gbXRkLT5zaXplOwoKV2Ug aG9wZSB0aGlzIHdpbGwgZGVmaW5pdGVseSBmaXggdGhlIE5WTUVNIGR1cGxpY2F0ZSBuYW1lIGlz c3VlLiBJZiBpdApkb2VzIG5vdCByZWxpYWJseSwgd2UgbWlnaHQgd2FudCB0byByZXZlcnQgdGhp cyBwYXRjaCBhbmQgY3JlYXRlIGFuIE1URAp1bmlxdWUgSUQgZmllbGQgd2hpY2gsIGZvciBlYWNo IE1URCBkZXZpY2UsIGNvbmNhdGVuYXRlcyB0aGUgbmFtZSBvZgppdHMgcGFyZW50IGFuZCBpdHMg b3duIG10ZC0+bmFtZS4KCkFja2VkLWJ5OiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJv b3RsaW4uY29tPgoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBs aXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRk Lwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EFD1C3A5A9 for ; Mon, 4 May 2020 08:44:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5438B20721 for ; Mon, 4 May 2020 08:44:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727930AbgEDIoE convert rfc822-to-8bit (ORCPT ); Mon, 4 May 2020 04:44:04 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:14459 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbgEDIoE (ORCPT ); Mon, 4 May 2020 04:44:04 -0400 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 8DCEF240014; Mon, 4 May 2020 08:43:40 +0000 (UTC) Date: Mon, 4 May 2020 10:43:39 +0200 From: Miquel Raynal To: Ricardo Ribalda Delgado Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Boris Brezillon , Alban Bedel , Ricardo Ribalda Delgado Subject: Re: [PATCH] mtd: Fix mtd not registered due to nvmem name collision Message-ID: <20200504104339.31b4a858@xps13> In-Reply-To: <20200430131721.360064-1-ricardo@ribalda.com> References: <20200430131721.360064-1-ricardo@ribalda.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, Ricardo Ribalda Delgado wrote on Thu, 30 Apr 2020 15:17:21 +0200: > From: Ricardo Ribalda Delgado > > When the nvmem framework is enabled, a nvmem device is created per mtd > device/partition. > > It is not uncommon that a device can have multiple mtd devices with > partitions that have the same name. Eg, when there DT overlay is allowed > and the same device with mtd is attached twice. > > Under that circumstances, the mtd fails to register due to a name > duplication on the nvmem framework. > > With this patch we use the mtdX name instead of the partition name, > which is unique. > > [ 8.948991] sysfs: cannot create duplicate filename '/bus/nvmem/devices/Production Data' > [ 8.948992] CPU: 7 PID: 246 Comm: systemd-udevd Not tainted 5.5.0-qtec-standard #13 > [ 8.948993] Hardware name: AMD Dibbler/Dibbler, BIOS 05.22.04.0019 10/26/2019 > [ 8.948994] Call Trace: > [ 8.948996] dump_stack+0x50/0x70 > [ 8.948998] sysfs_warn_dup.cold+0x17/0x2d > [ 8.949000] sysfs_do_create_link_sd.isra.0+0xc2/0xd0 > [ 8.949002] bus_add_device+0x74/0x140 > [ 8.949004] device_add+0x34b/0x850 > [ 8.949006] nvmem_register.part.0+0x1bf/0x640 > ... > [ 8.948926] mtd mtd8: Failed to register NVMEM device > > Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API") > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/mtd/mtdcore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index 2916674208b3..29d41003d6e0 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -555,7 +555,7 @@ static int mtd_nvmem_add(struct mtd_info *mtd) > > config.id = -1; > config.dev = &mtd->dev; > - config.name = mtd->name; > + config.name = dev_name(&mtd->dev); > config.owner = THIS_MODULE; > config.reg_read = mtd_nvmem_reg_read; > config.size = mtd->size; We hope this will definitely fix the NVMEM duplicate name issue. If it does not reliably, we might want to revert this patch and create an MTD unique ID field which, for each MTD device, concatenates the name of its parent and its own mtd->name. Acked-by: Miquel Raynal Thanks, Miquèl