From: Kees Cook <keescook@chromium.org>
To: Pavel Tatashin <pasha.tatashin@soleen.com>
Cc: jmorris@namei.org, sashal@kernel.org,
linux-kernel@vger.kernel.org, pmladek@suse.com,
sergey.senozhatsky@gmail.com, rostedt@goodmis.org,
anton@enomsg.org, ccross@android.com, tony.luck@intel.com,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 0/3] allow ramoops to collect all kmesg_dump events
Date: Mon, 4 May 2020 11:14:28 -0700 [thread overview]
Message-ID: <202005041112.F3C8117F67@keescook> (raw)
In-Reply-To: <20200502143555.543636-1-pasha.tatashin@soleen.com>
On Sat, May 02, 2020 at 10:35:52AM -0400, Pavel Tatashin wrote:
> Currently, ramoops is capable to collect dmesg buffer only during
> panic and oops events. However, it is desirable for shutdown performance
> analysis reasons to optionally allow collecting dmesg buffers during other
> events as well: reboot, kexec, emergency reboot etc.
>
> How to quickly test:
>
> virtme-run --mods=auto --kdir --mods=auto --kdir . \
> -a memmap=1G$8G -a ramoops.mem_address=0x200000000 \
> -a ramoops.mem_size=0x100000 -a ramoops.record_size=32768 \
> -a ramoops.dump_all=1 -a quiet --qemu-opts -m 8G
> ..
> # reboot -f
>
> After VM is back:
>
> # mount -t pstore pstore /mnt
> # head /mnt/dmesg-ramoops-0
> Restart#1 Part1
Is there a reason that using ramoops.console_size isn't sufficient for
this?
I'm not strictly opposed to making these changes, but traditionally the
granularity of dmesg output has been pretty easily "all or crashes"
instead of a range within.
--
Kees Cook
next prev parent reply other threads:[~2020-05-04 18:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 14:35 [PATCH v1 0/3] allow ramoops to collect all kmesg_dump events Pavel Tatashin
2020-05-02 14:35 ` [PATCH v1 1/3] printk: honor the max_reason field in kmsg_dumper Pavel Tatashin
2020-05-04 17:15 ` Steven Rostedt
2020-05-04 17:56 ` Pavel Tatashin
2020-05-04 18:12 ` Kees Cook
2020-05-04 18:40 ` Pavel Tatashin
2020-05-05 1:02 ` Sergey Senozhatsky
2020-05-05 2:52 ` Pavel Tatashin
2020-05-05 3:12 ` Pavel Tatashin
2020-05-05 4:21 ` Pavel Tatashin
2020-05-05 10:50 ` Sergey Senozhatsky
2020-05-02 14:35 ` [PATCH v1 2/3] pstore/ram: allow to dump kmesg during regular reboot Pavel Tatashin
2020-05-04 19:29 ` Kees Cook
2020-05-04 20:30 ` Pavel Tatashin
2020-05-04 20:54 ` Kees Cook
2020-05-02 14:35 ` [PATCH v1 3/3] ramoops: add dump_all optional field to ramoops DT node Pavel Tatashin
2020-05-04 19:29 ` Kees Cook
2020-05-04 20:00 ` Pavel Tatashin
2020-05-05 15:14 ` Pavel Tatashin
2020-05-04 18:14 ` Kees Cook [this message]
2020-05-04 18:47 ` [PATCH v1 0/3] allow ramoops to collect all kmesg_dump events Pavel Tatashin
2020-05-04 19:12 ` Kees Cook
2020-05-04 19:17 ` Pavel Tatashin
2020-05-04 19:30 ` Kees Cook
2020-05-04 20:00 ` Pavel Tatashin
2020-05-05 12:36 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005041112.F3C8117F67@keescook \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pmladek@suse.com \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.