From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 4/4] syscalls/fanotify: Use fanotify_save_fid() helper
Date: Mon, 4 May 2020 14:33:53 +0200 [thread overview]
Message-ID: <20200504123353.GA14280@dell5510> (raw)
In-Reply-To: <20200502162744.9589-5-amir73il@gmail.com>
Hi Amir,
> Reduce some boiler plate code in FAN_REPORT_FID tests and
> save fid only once per object instead of once per expected event.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
+1
> static int setup_marks(unsigned int fd, struct test_case_t *tc)
> @@ -130,8 +125,8 @@ static int setup_marks(unsigned int fd, struct test_case_t *tc)
> "kernel");
> return 1;
> } else if (errno == ENODEV &&
> - !event_set[i].fsid.val[0] &&
> - !event_set[i].fsid.val[1]) {
> + !FSID_VAL_MEMBER(objects[i].fid.fsid, 0) &&
> + !FSID_VAL_MEMBER(objects[i].fid.fsid, 1)) {
For the same reasons as the previous commits this diff is needed:
- !FSID_VAL_MEMBER(objects[i].fid.fsid, 0) &&
- !FSID_VAL_MEMBER(objects[i].fid.fsid, 1)) {
+ !objects[i].fid.fsid.val[0] &&
+ !objects[i].fid.fsid.val[1]) {
Kind regards,
Petr
next prev parent reply other threads:[~2020-05-04 12:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 16:27 [LTP] [PATCH v2 0/4] fanotify ltp tests for v5.7-rc1 Amir Goldstein
2020-05-02 16:27 ` [LTP] [PATCH v2 1/4] syscalls/fanotify15: Minor corrections Amir Goldstein
2020-05-02 16:27 ` [LTP] [PATCH v2 2/4] syscalls/fanotify15: Add a test case for inode marks Amir Goldstein
2020-05-04 8:07 ` Jan Kara
2020-05-04 8:51 ` Amir Goldstein
2020-05-04 14:15 ` Jan Kara
2020-05-04 18:49 ` Petr Vorel
2020-05-04 20:27 ` Jan Kara
2020-05-05 12:03 ` Petr Vorel
2020-05-02 16:27 ` [LTP] [PATCH v2 3/4] syscalls/fanotify: New test for FAN_MODIFY_DIR Amir Goldstein
2020-05-04 12:07 ` Petr Vorel
2020-05-04 15:31 ` Amir Goldstein
2020-05-02 16:27 ` [LTP] [PATCH v2 4/4] syscalls/fanotify: Use fanotify_save_fid() helper Amir Goldstein
2020-05-03 8:43 ` Matthew Bobrowski
2020-05-04 12:33 ` Petr Vorel [this message]
2020-05-04 5:53 ` [LTP] [PATCH v2 0/4] fanotify ltp tests for v5.7-rc1 Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504123353.GA14280@dell5510 \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.