From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E606EC47257 for ; Mon, 4 May 2020 13:39:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C676320752 for ; Mon, 4 May 2020 13:39:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C676320752 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6065D6E3F7; Mon, 4 May 2020 13:39:07 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 546E76E3F7 for ; Mon, 4 May 2020 13:39:05 +0000 (UTC) IronPort-SDR: iZEGa+4gsny6yk4IPFthK7Hw1JKKE59Tjbl/AuWJfQJ20kex4udLIMfd4RgcM4VMIfDv7iBsW6 2XiXBcp0G79Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2020 06:39:04 -0700 IronPort-SDR: 9tlhy0yB/jVg0+uNo7gj9NQAVX3zrmYljAsiVgzHDimBiw8UN+meutQv26vzXOYpLvdIYAxggn IIoFufZ6L9vQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,352,1583222400"; d="scan'208";a="248219466" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 04 May 2020 06:39:02 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 04 May 2020 16:39:01 +0300 Date: Mon, 4 May 2020 16:39:01 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Imre Deak Message-ID: <20200504133901.GZ6112@intel.com> References: <20200504075828.20348-1-imre.deak@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200504075828.20348-1-imre.deak@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl+: Fix interrupt handling for DP AUX transactions X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, May 04, 2020 at 10:58:28AM +0300, Imre Deak wrote: > Unmask/enable AUX interrupts on all ports on TGL+. So far the interrupts > worked only on port A, which meant each transaction on other ports took > 10ms. > = > Cc: # v5.4+ > Signed-off-by: Imre Deak Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/i915_irq.c | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_= irq.c > index bd722d0650c8..0b8b0c069ce3 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -3361,7 +3361,7 @@ static void gen8_de_irq_postinstall(struct drm_i915= _private *dev_priv) > u32 de_pipe_masked =3D gen8_de_pipe_fault_mask(dev_priv) | > GEN8_PIPE_CDCLK_CRC_DONE; > u32 de_pipe_enables; > - u32 de_port_masked =3D GEN8_AUX_CHANNEL_A; > + u32 de_port_masked =3D gen8_de_port_aux_mask(dev_priv); > u32 de_port_enables; > u32 de_misc_masked =3D GEN8_DE_EDP_PSR; > enum pipe pipe; > @@ -3369,18 +3369,8 @@ static void gen8_de_irq_postinstall(struct drm_i91= 5_private *dev_priv) > if (INTEL_GEN(dev_priv) <=3D 10) > de_misc_masked |=3D GEN8_DE_MISC_GSE; > = > - if (INTEL_GEN(dev_priv) >=3D 9) { > - de_port_masked |=3D GEN9_AUX_CHANNEL_B | GEN9_AUX_CHANNEL_C | > - GEN9_AUX_CHANNEL_D; > - if (IS_GEN9_LP(dev_priv)) > - de_port_masked |=3D BXT_DE_PORT_GMBUS; > - } > - > - if (INTEL_GEN(dev_priv) >=3D 11) > - de_port_masked |=3D ICL_AUX_CHANNEL_E; > - > - if (IS_CNL_WITH_PORT_F(dev_priv) || INTEL_GEN(dev_priv) >=3D 11) > - de_port_masked |=3D CNL_AUX_CHANNEL_F; > + if (IS_GEN9_LP(dev_priv)) > + de_port_masked |=3D BXT_DE_PORT_GMBUS; > = > de_pipe_enables =3D de_pipe_masked | GEN8_PIPE_VBLANK | > GEN8_PIPE_FIFO_UNDERRUN; > -- = > 2.23.1 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5A11C3A5A9 for ; Mon, 4 May 2020 13:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FD232075A for ; Mon, 4 May 2020 13:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727783AbgEDNjF (ORCPT ); Mon, 4 May 2020 09:39:05 -0400 Received: from mga17.intel.com ([192.55.52.151]:46989 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727104AbgEDNjF (ORCPT ); Mon, 4 May 2020 09:39:05 -0400 IronPort-SDR: i0xiI5/Vqkwg4eQ0NQP01vDCh+XEP3vw0Z+qTYcvY3uOlv1HNipQuA6YvYiyRPhvZzNAPA1IYb oI0SBi1Rx6Dg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2020 06:39:04 -0700 IronPort-SDR: 9tlhy0yB/jVg0+uNo7gj9NQAVX3zrmYljAsiVgzHDimBiw8UN+meutQv26vzXOYpLvdIYAxggn IIoFufZ6L9vQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,352,1583222400"; d="scan'208";a="248219466" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 04 May 2020 06:39:02 -0700 Received: by stinkbox (sSMTP sendmail emulation); Mon, 04 May 2020 16:39:01 +0300 Date: Mon, 4 May 2020 16:39:01 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Imre Deak Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl+: Fix interrupt handling for DP AUX transactions Message-ID: <20200504133901.GZ6112@intel.com> References: <20200504075828.20348-1-imre.deak@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200504075828.20348-1-imre.deak@intel.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, May 04, 2020 at 10:58:28AM +0300, Imre Deak wrote: > Unmask/enable AUX interrupts on all ports on TGL+. So far the interrupts > worked only on port A, which meant each transaction on other ports took > 10ms. > > Cc: # v5.4+ > Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_irq.c | 16 +++------------- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index bd722d0650c8..0b8b0c069ce3 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -3361,7 +3361,7 @@ static void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv) > u32 de_pipe_masked = gen8_de_pipe_fault_mask(dev_priv) | > GEN8_PIPE_CDCLK_CRC_DONE; > u32 de_pipe_enables; > - u32 de_port_masked = GEN8_AUX_CHANNEL_A; > + u32 de_port_masked = gen8_de_port_aux_mask(dev_priv); > u32 de_port_enables; > u32 de_misc_masked = GEN8_DE_EDP_PSR; > enum pipe pipe; > @@ -3369,18 +3369,8 @@ static void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv) > if (INTEL_GEN(dev_priv) <= 10) > de_misc_masked |= GEN8_DE_MISC_GSE; > > - if (INTEL_GEN(dev_priv) >= 9) { > - de_port_masked |= GEN9_AUX_CHANNEL_B | GEN9_AUX_CHANNEL_C | > - GEN9_AUX_CHANNEL_D; > - if (IS_GEN9_LP(dev_priv)) > - de_port_masked |= BXT_DE_PORT_GMBUS; > - } > - > - if (INTEL_GEN(dev_priv) >= 11) > - de_port_masked |= ICL_AUX_CHANNEL_E; > - > - if (IS_CNL_WITH_PORT_F(dev_priv) || INTEL_GEN(dev_priv) >= 11) > - de_port_masked |= CNL_AUX_CHANNEL_F; > + if (IS_GEN9_LP(dev_priv)) > + de_port_masked |= BXT_DE_PORT_GMBUS; > > de_pipe_enables = de_pipe_masked | GEN8_PIPE_VBLANK | > GEN8_PIPE_FIFO_UNDERRUN; > -- > 2.23.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel