From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com, liu.denton@gmail.com
Subject: Re: [PATCH v3] submodule: port subcommand 'set-url' from shell to C
Date: Mon, 4 May 2020 23:09:36 +0530 [thread overview]
Message-ID: <20200504173936.GA8919@konoha> (raw)
In-Reply-To: <xmqqd07jitjz.fsf@gitster.c.googlers.com>
On 04/05 08:55, Junio C Hamano wrote:
> > + argc = parse_options(argc, argv, prefix, set_url_options,
> > + usage, 0);
> > +
> > + if (quiet)
> > + quiet |= OPT_QUIET;
>
> This is bogus. "command --quiet --quiet" would count-up quiet twice
> and would make it 2, and you or OPT_QUIET==1 in to make it 3, but
> your intention is quite clear that you want to pass 1 to
> sync_submodule() in such a case.
This is a grave mistake from my side. Though I do not understand how
will `quiet` be counted twice. Let's say we pass `--quiet` option in the
command, then `quiet` is set to 1. And now if we do `quiet|= OPT_QUIET`,
this will make `quiet` 1 again right? Could you please tell me what am I
missing out here?
The fix you suggested (quiet ? OPT_QUIET : 0), we use this because we
want to ensure `quiet` goes into sync as either 1/0 right? Not any other
non-zero positive integer right?
next prev parent reply other threads:[~2020-05-04 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 7:27 [PATCH v3] submodule: port subcommand 'set-url' from shell to C Shourya Shukla
2020-05-04 15:55 ` Junio C Hamano
2020-05-04 17:39 ` Shourya Shukla [this message]
2020-05-04 19:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504173936.GA8919@konoha \
--to=shouryashukla.oo@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.