Re: [PATCH 0/5] drm/mgag200: Embed DRM device in struct mga_device

[Sam Ravnborg <sam@ravnborg.org>]

Hi Thomas.

On Tue, May 05, 2020 at 11:56:44AM +0200, Thomas Zimmermann wrote:
> After receiving reviews on the conversion of mgag200 to atomic mode
> setting, I thought it would make sense to embed the DRM device in
> struct mga_device first. Several comments in the atomic-conversion
> reviews refer to that.
I would have preferred that this was on top of at least some of the
existing patches, as they are tested by at least one other person
and reveiwed too (at least some of them, but maybe only by me).

Anyway, now you did it like this and Daniel has reviewed so let's
move on from here.

	Sam
> 
> Patches 1 to 3 do some cleanups and preparation work. Patch 4 changes
> the the init functions to allocate struct mga_device before struct
> drm_device. Patch 5 does the conversion.
> 
> I did not switch over struct mga_device to the new managed release
> code. I found that this justifies another round of cleanup patches,
> which I did not want to put into this patchset.
> 
> The patches were tested on mgag200 hardware.
> 
> Thomas Zimmermann (5):
>   drm/mgag200: Convert struct drm_device to struct mga_device with macro
>   drm/mgag200: Integrate init function into load function
>   drm/mgag200: Remove several references to struct mga_device.dev
>   drm/mgag200: Init and finalize devices in mgag200_device_{init,fini}()
>   drm/mgag200: Embed DRM device instance in struct mga_device
> 
>  drivers/gpu/drm/mgag200/mgag200_cursor.c |  10 +-
>  drivers/gpu/drm/mgag200/mgag200_drv.c    |  29 +++---
>  drivers/gpu/drm/mgag200/mgag200_drv.h    |   8 +-
>  drivers/gpu/drm/mgag200/mgag200_i2c.c    |  10 +-
>  drivers/gpu/drm/mgag200/mgag200_main.c   | 114 +++++++++++------------
>  drivers/gpu/drm/mgag200/mgag200_mode.c   |  35 +++----
>  drivers/gpu/drm/mgag200/mgag200_ttm.c    |   4 +-
>  7 files changed, 101 insertions(+), 109 deletions(-)
> 
> --
> 2.26.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel