From: Ye Xiaolong <xiaolong.ye@intel.com>
To: zhihongx.peng@intel.com
Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org,
liang-min.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD
Date: Wed, 6 May 2020 13:22:12 +0800 [thread overview]
Message-ID: <20200506052212.GC71070@intel.com> (raw)
In-Reply-To: <20200417035212.16587-1-zhihongx.peng@intel.com>
On 04/16, zhihongx.peng@intel.com wrote:
>From: Peng Zhihong <zhihongx.peng@intel.com>
>
>DPDK does not implement interrupt mechanism on BSD,
>so force NIC status synchronization.
>
>Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF)
>Cc: liang-min.wang@intel.com
>
>Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index 2c5797635..efd8aced4 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -4262,6 +4262,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
> if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0)
> wait = 0;
>
>+/* BSD has no interrupt mechanism, so force NIC status synchronization. */
>+#ifdef RTE_EXEC_ENV_FREEBSD
>+ wait = 1;
>+#endif
>+
> if (vf)
> diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait);
> else
>--
>2.17.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
prev parent reply other threads:[~2020-05-06 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 3:52 [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD zhihongx.peng
2020-04-28 10:19 ` Huang, ZhiminX
2020-05-06 5:22 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506052212.GC71070@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=liang-min.wang@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.