From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 535B8C28CBC for ; Wed, 6 May 2020 06:31:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2853220747 for ; Wed, 6 May 2020 06:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588746669; bh=MFpFVaI2hBqLIIEtg/NvItpJR0h+j14MNwgPOuWazmw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=p6JENOXPAlCgfBnvPk158ruw0MVbFOSrr+J9LGoi8GKnQhWo2lPRfDRJlnVJOPDob cDgaQ7G9IIghd1+LLvwVa3JguATrOOZ8tthrsi9ZcZI5GF5esYJ0aFmR4AXQRWhR8x q4bK40g25V+vWH8pc3KGc3mjmzg4cs/dsnqHvcPo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726946AbgEFGbI (ORCPT ); Wed, 6 May 2020 02:31:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:51994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725882AbgEFGbI (ORCPT ); Wed, 6 May 2020 02:31:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FABC206E6; Wed, 6 May 2020 06:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588746668; bh=MFpFVaI2hBqLIIEtg/NvItpJR0h+j14MNwgPOuWazmw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EpM8LnS4QQfFuOoQTFa7n+QHGjWh3YEmilYrQugomeBUci0nAmOVSwBUCYpiqr60y gkhA4deBwBb7/bnir48213vvxpxHX/VqDE/7fxQjxRhiEDCBKswqdfvM+McIIzbG5z gUc+hqPi1yv77BCXNTrLlhzVnorh7IqsuBJjc0/E= Date: Wed, 6 May 2020 08:31:05 +0200 From: 'Greg Kroah-Hartman' To: Hyunki Koo Cc: 'Kukjin Kim' , 'Krzysztof Kozlowski' , 'Jiri Slaby' , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg Message-ID: <20200506063105.GA2246050@kroah.com> References: <20200420013300.17249-1-hyunki00.koo@samsung.com> <20200505142325.GA816056@kroah.com> <000001d62335$33d03410$9b709c30$@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <000001d62335$33d03410$9b709c30$@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, May 06, 2020 at 08:30:46AM +0900, Hyunki Koo wrote: > On Tuesday, May 5, 2020 at 2020 11:23:00 PM +0900, Greg Kroah-Hartman wrote: > > On Mon, Apr 20, 2020 at 10:32:56AM +0900, Hyunki Koo wrote: > > > This patch change the name of macro for general usage. > > > > > > Signed-off-by: Hyunki Koo > > > > This patch series creates the following build error, which is not > > allowed: > > > > CC [M] drivers/tty/serial/samsung_tty.o > > drivers/tty/serial/samsung_tty.c:186:13: warning: ‘wr_reg_barrier’ > > defined but not used [-Wunused-function] > > 186 | static void wr_reg_barrier(struct uart_port *port, u32 reg, u32 val) > > | ^~~~~~~~~~~~~~ > > > > Please fix up and resend. Always make sure you keep the reviewed-by > > tags from others as well. > > > > greg k-h > > I tested on latest kernel today one more time, there is no error and warning on my side, not only patch 1/3 and patch 3/3 > Line 1735: CC drivers/tty/serial/samsung_tty.o > Line 343: CC drivers/tty/serial/samsung_tty.o > > wr_reg_barrier is not defined in patch 1/3, > and wr_reg_barrier is define and used in patch3/3 > it might be no warning. After I apply this series, I got the above build warning on my normal x86 system, so I can not take the patches. Please fix up and resend. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB33EC28CBC for ; Wed, 6 May 2020 06:31:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95536206F9 for ; Wed, 6 May 2020 06:31:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="smnyjtQF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EpM8LnS4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95536206F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oCKpLbbhOjzYtGSyGFCQWr3wVTmvkz/qCMotGZozUYQ=; b=smnyjtQFC7cJP6 Ay4QlHII61OUX4HmwWnraAVD7WZdxL21q5u2n/s83QtfQp3rEh1DU6xpb7NnjTRuT/R8A2ZT6tFdd LUK8CpkNlh/zzsdkyLslDoWQt3vrdLQN1xQxdAy3fCxk/Qu2hGam98TryS4C5wVQSJq8j/kM1VBvX vmm3wE3ShkVJJFKPxwwq/1FYjwJ/3ljZR2i83YV10Es80vT62eVRMiaOP5ECuS56TlrNvuFtIhIn0 lGTO5B2505EW05pw8YizV4U0rlGa4kzXeLRC11PLInqbg3WueD0ReEZemqBZv5NKNgfDIoDeENk6l J5eRjCvqVhK2rF6JddTQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWDaJ-0004pc-V3; Wed, 06 May 2020 06:31:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jWDaH-0004os-1R for linux-arm-kernel@lists.infradead.org; Wed, 06 May 2020 06:31:10 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FABC206E6; Wed, 6 May 2020 06:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588746668; bh=MFpFVaI2hBqLIIEtg/NvItpJR0h+j14MNwgPOuWazmw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EpM8LnS4QQfFuOoQTFa7n+QHGjWh3YEmilYrQugomeBUci0nAmOVSwBUCYpiqr60y gkhA4deBwBb7/bnir48213vvxpxHX/VqDE/7fxQjxRhiEDCBKswqdfvM+McIIzbG5z gUc+hqPi1yv77BCXNTrLlhzVnorh7IqsuBJjc0/E= Date: Wed, 6 May 2020 08:31:05 +0200 From: 'Greg Kroah-Hartman' To: Hyunki Koo Subject: Re: [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg Message-ID: <20200506063105.GA2246050@kroah.com> References: <20200420013300.17249-1-hyunki00.koo@samsung.com> <20200505142325.GA816056@kroah.com> <000001d62335$33d03410$9b709c30$@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <000001d62335$33d03410$9b709c30$@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200505_233109_097757_9361CEE1 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, 'Krzysztof Kozlowski' , 'Kukjin Kim' , linux-serial@vger.kernel.org, 'Jiri Slaby' , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXkgMDYsIDIwMjAgYXQgMDg6MzA6NDZBTSArMDkwMCwgSHl1bmtpIEtvbyB3cm90 ZToKPiBPbiBUdWVzZGF5LCBNYXkgNSwgMjAyMCBhdCAyMDIwIDExOjIzOjAwIFBNICswOTAwLCBH cmVnIEtyb2FoLUhhcnRtYW4gd3JvdGU6Cj4gPiBPbiBNb24sIEFwciAyMCwgMjAyMCBhdCAxMDoz Mjo1NkFNICswOTAwLCBIeXVua2kgS29vIHdyb3RlOgo+ID4gPiBUaGlzIHBhdGNoIGNoYW5nZSB0 aGUgbmFtZSBvZiBtYWNybyBmb3IgZ2VuZXJhbCB1c2FnZS4KPiA+ID4KPiA+ID4gU2lnbmVkLW9m Zi1ieTogSHl1bmtpIEtvbyA8aHl1bmtpMDAua29vQHNhbXN1bmcuY29tPgo+ID4gCj4gPiBUaGlz IHBhdGNoIHNlcmllcyBjcmVhdGVzIHRoZSBmb2xsb3dpbmcgYnVpbGQgZXJyb3IsIHdoaWNoIGlz IG5vdAo+ID4gYWxsb3dlZDoKPiA+IAo+ID4gICBDQyBbTV0gIGRyaXZlcnMvdHR5L3NlcmlhbC9z YW1zdW5nX3R0eS5vCj4gPiBkcml2ZXJzL3R0eS9zZXJpYWwvc2Ftc3VuZ190dHkuYzoxODY6MTM6 IHdhcm5pbmc6IOKAmHdyX3JlZ19iYXJyaWVy4oCZCj4gPiBkZWZpbmVkIGJ1dCBub3QgdXNlZCBb LVd1bnVzZWQtZnVuY3Rpb25dCj4gPiAgIDE4NiB8IHN0YXRpYyB2b2lkIHdyX3JlZ19iYXJyaWVy KHN0cnVjdCB1YXJ0X3BvcnQgKnBvcnQsIHUzMiByZWcsIHUzMiB2YWwpCj4gPiAgICAgICB8ICAg ICAgICAgICAgIF5+fn5+fn5+fn5+fn5+Cj4gPiAKPiA+IFBsZWFzZSBmaXggdXAgYW5kIHJlc2Vu ZC4gIEFsd2F5cyBtYWtlIHN1cmUgeW91IGtlZXAgdGhlIHJldmlld2VkLWJ5Cj4gPiB0YWdzIGZy b20gb3RoZXJzIGFzIHdlbGwuCj4gPiAKPiA+IGdyZWcgay1oCj4gCj4gSSB0ZXN0ZWQgb24gbGF0 ZXN0IGtlcm5lbCB0b2RheSBvbmUgbW9yZSB0aW1lLCB0aGVyZSBpcyBubyBlcnJvciBhbmQgd2Fy bmluZyBvbiBteSBzaWRlLCBub3Qgb25seSBwYXRjaCAxLzMgYW5kIHBhdGNoIDMvMwo+IExpbmUg MTczNTogICBDQyAgICAgIGRyaXZlcnMvdHR5L3NlcmlhbC9zYW1zdW5nX3R0eS5vCj4gTGluZSAz NDM6ICAgQ0MgICAgICBkcml2ZXJzL3R0eS9zZXJpYWwvc2Ftc3VuZ190dHkubwo+IAo+IHdyX3Jl Z19iYXJyaWVyIGlzIG5vdCBkZWZpbmVkIGluIHBhdGNoIDEvMywgCj4gYW5kIHdyX3JlZ19iYXJy aWVyIGlzIGRlZmluZSBhbmQgdXNlZCBpbiBwYXRjaDMvMwo+IGl0IG1pZ2h0IGJlIG5vIHdhcm5p bmcuCgpBZnRlciBJIGFwcGx5IHRoaXMgc2VyaWVzLCBJIGdvdCB0aGUgYWJvdmUgYnVpbGQgd2Fy bmluZyBvbiBteSBub3JtYWwKeDg2IHN5c3RlbSwgc28gSSBjYW4gbm90IHRha2UgdGhlIHBhdGNo ZXMuICBQbGVhc2UgZml4IHVwIGFuZCByZXNlbmQuCgpncmVnIGstaAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=