From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCH 3/3] nvmet: add async event tracing support
Date: Wed, 6 May 2020 09:14:19 +0200 [thread overview]
Message-ID: <20200506071419.GC12145@lst.de> (raw)
In-Reply-To: <20200506014629.39509-4-chaitanya.kulkarni@wdc.com>
On Tue, May 05, 2020 at 06:46:29PM -0700, Chaitanya Kulkarni wrote:
> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
> index 219bcf21d4bf..d4f11078a578 100644
> --- a/drivers/nvme/target/core.c
> +++ b/drivers/nvme/target/core.c
> @@ -151,6 +151,8 @@ static void nvmet_async_events_process(struct nvmet_ctrl *ctrl, u16 status)
> kfree(aen);
>
> mutex_unlock(&ctrl->lock);
> + trace_nvmet_async_event(ctrl,
> + (req->cqe->result.u32 & 0xff00) >> 8);
Can you move the extraction into trace_nvmet_async_event so that it
isn't executed when tracing isn't enabled?
Otherwise this looks fine.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-05-06 7:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 1:46 [PATCH 0/3] nvmet: add target ns revalidate support Chaitanya Kulkarni
2020-05-06 1:46 ` [PATCH 1/3] nvmet: add helper to revalidate bdev and file ns Chaitanya Kulkarni
2020-05-06 7:11 ` Christoph Hellwig
2020-05-06 23:41 ` Chaitanya Kulkarni
2020-05-06 1:46 ` [PATCH 2/3] nvmet: on ns size change generate AEN from configfs Chaitanya Kulkarni
2020-05-06 7:13 ` Christoph Hellwig
2020-05-06 23:42 ` Chaitanya Kulkarni
2020-05-06 1:46 ` [PATCH 3/3] nvmet: add async event tracing support Chaitanya Kulkarni
2020-05-06 7:14 ` Christoph Hellwig [this message]
2020-05-06 23:43 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506071419.GC12145@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.